Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the String component #12440

Merged
merged 1 commit into from Oct 14, 2019

Conversation

@javiereguiluz
Copy link
Member

commented Oct 7, 2019

Fixes #12376 and #12404. This is an early WIP to test if this is correct.

@nicolas-grekas the full API is very long because there are a ton of methods ... so I thought about grouping them by "topic". Would you agree with that?

Thanks!

@javiereguiluz javiereguiluz added the String label Oct 7, 2019
@javiereguiluz javiereguiluz added this to the 5.0 milestone Oct 7, 2019
@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Works for me, thank you.

@OskarStark

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Great work so far Javier 🙂👍🏻

@javiereguiluz

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2019

The article is now ready for review. The only missing part is the Slugger, which I'll add soon too. Thanks.

Copy link
Member

left a comment

That's cool thank you :)
Here are some comments.

components/string.rst Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
components/string.rst Show resolved Hide resolved
components/string.rst Outdated Show resolved Hide resolved
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Oct 11, 2019
…as-grekas)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[String] add $lastGlue argument to join() methods

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

An idea that came when reviewing symfony/symfony-docs#12440

Commits
-------

714d629 [String] add $lastGlue argument to join() methods
@javiereguiluz javiereguiluz force-pushed the javiereguiluz:fix_12376 branch from 84bd97d to 9d08de4 Oct 14, 2019
@javiereguiluz javiereguiluz merged commit 9d08de4 into symfony:master Oct 14, 2019
0 of 2 checks passed
0 of 2 checks passed
DOCtor-RST DOCtor-RST
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@javiereguiluz javiereguiluz deleted the javiereguiluz:fix_12376 branch Oct 14, 2019
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Oct 14, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[String] wrap(): test and fix

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs/pull/12440

Commits
-------

015b81a [String] wrap(): test and fix
symfony-splitter pushed a commit to symfony/string that referenced this pull request Oct 14, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[String] wrap(): test and fix

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs/pull/12440

Commits
-------

015b81a2f5 [String] wrap(): test and fix
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Oct 14, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[String] bytesAt() and codePointsAt()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #33923
| License       | MIT
| Doc PR        | symfony/symfony-docs/pull/12440

Commits
-------

f8d2faa [String] bytesAt() and codePointsAt()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.