Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[2.1] Fixed build errors #2445

Merged
merged 3 commits into from Apr 1, 2013

Conversation

Projects
None yet
2 participants
Member

wouterj commented Apr 1, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.1+

There were some build errors. This PR, among with other PRs on some 3th party bundles, tries to fix them all.

@wouterj wouterj commented on the diff Apr 1, 2013

cookbook/form/dynamic_form_modification.rst
@@ -161,12 +161,11 @@ How to Dynamically Generate Forms based on user data
====================================================
Sometimes you want a form to be generated dynamically based not only on data
-from this form (see :doc:`Dynamic form generation</cookbook/dynamic_form_generation>`)
@wouterj

wouterj Apr 1, 2013

Member

This was an error (because it should be /cookbook/form/dynamic_form_generation). But I did removed it because it's a link to this document, I don't think that's needed. If someone finds the doc where this link should go to, I'm happy to change it!

@wouterj wouterj referenced this pull request Apr 1, 2013

Merged

[2.2] Fixed build errors #2446

weaverryan added a commit that referenced this pull request Apr 1, 2013

@weaverryan weaverryan merged commit cd9eda4 into symfony:2.1 Apr 1, 2013

Member

weaverryan commented Apr 1, 2013

Awesome! Removing the link makes sense to me.

@wouterj wouterj deleted the wouterj:fix_errors_21 branch Apr 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment