Update http_cache.rst #4098
Update http_cache.rst #4098
Conversation
Explained how the parameters are passed to the controller - named parameters
| public function content($max_per_page = 10, $type = "news") | ||
| { | ||
|
|
||
|
|
There was a problem hiding this comment.
Hmm, I agree we can highlight this better. But it's also true of render, not only render_esi. Also, I think the standards are maxPerPage and the controller name should be contentAction (since most people are probably using the normal shortcut syntax for the controller.
We do show the $max variable being passed as an argument in the next example. Perhaps we just need to add a note about that. For example:
.. tip::
Any extra variables you pass (like ``max`` in the above example) will become arguments
to your controller (e.g. ``$max``). You can see this in the controller below.What do you think?
There was a problem hiding this comment.
I agree, but I think we need to be explicit with the named part. Those variables were just made up to be honest, Easy to change :)
There was a problem hiding this comment.
@Farkie You want to be explicit with the named part? So what do you mean/propose exactly? Sorry, I don't understand - I think you agree with changing the variable names but I'm not sure what you think about my other points :). Can you make the changes you think make sense? That might help.
Thanks!
This PR was merged into the 2.3 branch. Discussion ---------- ESI Variable Details Continuation This continues #4098. | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Thanks! Commits ------- ded7577 Clarifying a bit more that you're passing variables into your controller 5877d02 Update http_cache.rst
Explained how the parameters are passed to the controller - named parameters