Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a caution note about StringUtils::equals() which is no longer true #5619

Closed
wants to merge 1 commit into from
Closed

Remove a caution note about StringUtils::equals() which is no longer true #5619

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #5618

@OskarStark
Copy link
Contributor

you should fix the headline of this PR cauion to cauTion

@javiereguiluz javiereguiluz changed the title Remove a cauion note about StringUtils::equals() which is no longer true Remove a caution note about StringUtils::equals() which is no longer true Aug 12, 2015
@javiereguiluz
Copy link
Member Author

Done :)

@OskarStark
Copy link
Contributor

😄

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

👍

@paragonie-scott
Copy link

Looks good to me 👍

@wouterj
Copy link
Member

wouterj commented Sep 5, 2015

👍

@wouterj
Copy link
Member

wouterj commented Sep 5, 2015

Thank you Javier.

wouterj added a commit that referenced this pull request Sep 5, 2015
@wouterj
minor #5619 Remove a caution note about StringUtils::equals() which i…
1f79d9d 
…s no longer true (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Remove a caution note about StringUtils::equals() which is no longer true

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5618

Commits
-------

d0f1a4e Remove a cauion note about StringUtils::equals() which is no longer true
@wouterj wouterj closed this Sep 5, 2015
@javiereguiluz javiereguiluz deleted the fix_5618 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@javiereguiluz @OskarStark @xabbuh @paragonie-scott @wouterj