New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Code of Conduct #9394

Merged
merged 8 commits into from Apr 30, 2018

Conversation

@egircys
Member

egircys commented Mar 5, 2018

Adding the Contributor Covenant Code of Conduct version 1.4.
Relates to symfony/diversity#1

TODO

  • Add the link to the enforcement team page
  • Add the link to the enforcement process
  • Add the link to concrete real-world examples of unwanted behavior
  • Change "Project maintainers" to "Enforcement team members"

Part of #9340 and #9393

Replaces symfony/symfony#24896

@lsmith77

This comment has been minimized.

Contributor

lsmith77 commented Mar 5, 2018

Great! I guess we still need symfony/symfony#24896, just stripped down to point to this doc page.

@egircys egircys referenced this pull request Mar 6, 2018

Merged

Add CODE_OF_CONDUCT.md #24896

* Public or private harassment
* Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 6, 2018

Member

I'm still 👎 about this phrase:

  • Other conduct which could reasonably be considered inappropriate in a professional setting.

The reason, as explained multiple times in the other pull request, is that this clause is a backdoor to potential power abuse by the enforcement team.

The other items of the list are perfectly reasonable and perfectly defined: sexualized language, trolling, harassment, doxxing, etc. But the last phrase is a "catch-all" clause that says: we'll ban anything that we consider inappropriate.

This comment has been minimized.

@lsmith77

lsmith77 Mar 6, 2018

Contributor

Noted .. just for the record my previously stated response to this objection:
we cannot realistically list every objectionable behavior. this is not a legal document as we lack the infrastructure to handle rules at this level of detail. I understand the concern for a "power grab", but since the enforcement team is appointed by the core-team, there is still a way to stop the enforcement team if they ever do get out of hand.

This comment has been minimized.

@lsmith77

lsmith77 Mar 15, 2018

Contributor

I have thought about this some more and consulted an expert in code of conduct enforcement. My conclusion is that opening up the records to the entire core team is too much in conflict with insuring privacy. As such I would say its sufficient that if the core team suspects that there is overreach happening, that they simply use the power to change the members in the enforcement team. Of course members of the core team can then also become members of the enforcement team as part of this process. But the goal is to better protect privacy by:

  • limiting access to the records to as few people as possible
  • limiting access to people that have invested time into educating themselves on the topic (and ideally received some formal training).

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 15, 2018

Member

I would say its sufficient that if the core team suspects that there is overreach happening, that they simply use the power to change the members in the enforcement team

And how can we know or suspect that if we don't have access to any information? If the entire Core Team is too much, then please give access to a small representation of the Core Team (three people for example).

This comment has been minimized.

@lsmith77

lsmith77 Mar 15, 2018

Contributor

If people from the core team are interested in the topic enough, then why don't they just become part of the enforcement team?

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 15, 2018

Member

It's not about being part of the ET (Enforcement Team) ... we need an outside control of ET to ensure that they don't exceed their competences, that they don't act arbitrarily, etc. It'd be nice if someone (or a small group of people) from the CT (Core Team) watches the ET.

I propose myself as a candidate for that role: overseeing the ET. My proposed workflow would be that the designated person would have full access to all reports and all decisions from the ET. That person won't attend meetings of ET, won't make any decision, won't revoke any decision and won't change anything. If that person thinks that the ET is acting wrongly in some case, he/she will report it to the CT so the entire core team members can make a decision about that.

This comment has been minimized.

@lsmith77

lsmith77 Mar 15, 2018

Contributor

imho this creates more problems than it potentially solves .. not even the ET will have automatic access to all reports since depending on the people involved people will recuse themselves or reports may wish to not include specific people due to certain experiences.

now we would have to also keep some people in the loop that are not even part of the process.

This comment has been minimized.

@ph-il

ph-il Mar 21, 2018

Contributor

Power Abuse is also a point we can add to the code of conduct.

Enforcement team members who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by other
members of the project's leadership.

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 6, 2018

Member

This is too vague: as determined by other members of the project's leadership. Who exactly is going to watch the enforcement team actions and which will be their tools to do that?

This comment has been minimized.

@lsmith77

lsmith77 Mar 6, 2018

Contributor

We should update this section to be "core team" I would propose.

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 6, 2018

Member

OK. Don't forget to please detail how the Core Team will oversee the Enforcement Team (I guess we'll need full private access to all decisions and reports to deem if there's been an inappropriate conduct by some Enforcement member). Thanks!

This comment has been minimized.

@lsmith77

lsmith77 Mar 6, 2018

Contributor

that is a good point .. how much transparency on the records is needed for oversight.
the enforcement team is likely going to receive formal training. furthermore incidents records may not even be shared with the entire enforcement team, depending on if they recuse themselves or people involved specifically wish they don't get involved.

as such its a bit tricky to give blanket full access to the records to the core team. but I very much acknowledge that in case over reach is suspected, access the the records may be critical to make a final judgement by the core team.

so this seems like an important topic to also cover within the process.

/cc @Nyholm @michaelcullum @egircys

contributors and maintainers pledge to making participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, gender identity and expression, level of experience,
education, socio-economic status, nationality, personal appearance, race,

This comment has been minimized.

@dunglas

dunglas Mar 6, 2018

Member

It's maybe a cultural difference, but are we sure we want to use the "race" word?

Quoting Wikipedia:

Since the second half of the 20th century, the association of race with the ideologies and theories of scientific racism has led to the use of the word race itself becoming problematic. Although still used in general contexts, race has often been replaced by less ambiguous and loaded terms: populations, people(s), ethnic groups, or communities, depending on context.
...
European Union

According to European Council:

The European Union rejects theories which attempt to determine the existence of separate human races.

— Directive 2000/43/EC[144]

The European Union uses the terms racial origin and ethnic origin synonymously in its documents and according to it "the use of the term 'racial origin' in this directive does not imply an acceptance of such [racial] theories".[144][145][full citation needed] Haney López warns that using "race" as a category within the law tends to legitimize its existence in the popular imagination. In the diverse geographic context of Europe, ethnicity and ethnic origin are arguably more resonant and are less encumbered by the ideological baggage associated with "race". In European context, historical resonance of "race" underscores its problematic nature. In some states, it is strongly associated with laws promulgated by the Nazi and Fascist governments in Europe during the 1930s and 1940s. Indeed, in 1996, the European Parliament adopted a resolution stating that "the term should therefore be avoided in all official texts".

The concept of racial origin relies on the notion that human beings can be separated into biologically distinct "races", an idea generally rejected by the scientific community. Since all human beings belong to the same species, the ECRI (European Commission against Racism and Intolerance) rejects theories based on the existence of different "races". However, in its Recommendation ECRI uses this term in order to ensure that those persons who are generally and erroneously perceived as belonging to "another race" are not excluded from the protection provided for by the legislation. The law claims to reject the existence of "race", yet penalize situations where someone is treated less favourably on this ground.

This comment has been minimized.

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 7, 2018

Member

We could follow the same practices of European bureaucrats and replace ethnicity and race by just ethnic origin. It conveys the same meaning but it's less controversial for some people.

@egircys egircys referenced this pull request Mar 7, 2018

Open

Human Race(s?) #476

In the interest of fostering an open and welcoming environment, we as
contributors and maintainers pledge to making participation in our project and
our community a harassment-free experience for everyone, regardless of age, body
size, disability, ethnicity, gender identity and expression, level of experience,

This comment has been minimized.

@javiereguiluz

javiereguiluz Mar 7, 2018

Member

After the last change, ethnicity and ethnic origin are used in the same paragraph. We should remove ethnicity and keep just ethnic origin.

behavior and are expected to take appropriate and fair corrective action in
response to any instances of unacceptable behavior.
Enforcement team members have the right and responsibility to remove, edit, or

This comment has been minimized.

@javiereguiluz

javiereguiluz Apr 19, 2018

Member

I'd like a reword of this:

Enforcement team members have the right [...] to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

The phrase reads: "if enforcement members don't consider something appropriate, you will be banned". But it should read, "if enforcement members find something inappropriate according to the CoC, you will be banned".

The enforcement members don't have unlimited power. Punishments must be based on the CoC, not on this team people's opinions.

This comment has been minimized.

@sstok

sstok Apr 19, 2018

Contributor

I guess you commented on the wrong line number? 😃

:doc:`may be reported </contributing/code_of_conduct/reporting_guidelines>`
by contacting the :doc:`enforcement team members </contributing/code_of_conduct/enforcement_team>`.
All complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is

This comment has been minimized.

@javiereguiluz

javiereguiluz Apr 19, 2018

Member

The project team -> The enforcement team

This comment has been minimized.

@sroze

sroze Apr 19, 2018

Member

Actually, I'd argue that the entire project team is "obligated to maintain confidentiality".

This comment has been minimized.

@javiereguiluz

javiereguiluz Apr 19, 2018

Member

OK ... but we need to define somewhere what "project team" means. E.g. "project team = core team + enforcement team"

This comment has been minimized.

@egircys

egircys Apr 20, 2018

Member

I think it's meant that the enforcement team would keep the reporter confidential. The project team does not really need to know by whom was it reported.

Further details of specific enforcement policies may be posted separately.
Enforcement team members who do not follow or enforce the Code of Conduct in good
faith may face temporary or permanent repercussions as determined by the core team.

This comment has been minimized.

@javiereguiluz

javiereguiluz Apr 19, 2018

Member

the core team could be a link to /current/contributing/code/core_team

response to any instances of unacceptable behavior.
Enforcement team members have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions

This comment has been minimized.

@sroze

sroze Apr 19, 2018

Member

Shouldn't it be wiki pages instead of wiki edits ?

This comment has been minimized.

@egircys

egircys Apr 20, 2018

Member

I believe wiki edits has the adding of new wiki pages and the editing of existing ones covered

:doc:`may be reported </contributing/code_of_conduct/reporting_guidelines>`
by contacting the :doc:`enforcement team members </contributing/code_of_conduct/enforcement_team>`.
All complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. The project team is

This comment has been minimized.

@sroze

sroze Apr 19, 2018

Member

Actually, I'd argue that the entire project team is "obligated to maintain confidentiality".

Enforcement team members have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions
that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,

This comment has been minimized.

@sroze

sroze Apr 19, 2018

Member

Might already have been answered (and sorry if it's the case) but what does that mean to "ban a contributor"? Can't we also "ban" non-contributors? Also, it might be worth clarifying what a "contributor" is because I suspect here we also refer to people who write comments only while somewhere else on the website, "contributors" or just the people who have commits within the codebase.

This comment has been minimized.

@egircys

egircys Apr 23, 2018

Member

I can't remember it was asked, at least not directly. As I understand it's possible to ban a contributor only on the managed platforms, i.e. github (https://help.github.com/articles/blocking-a-user-from-your-organization/), slack and so on. A contribution is mentioned above as comments, commits, code, wiki edits, issues, and other contributions. While the other contributions is open for interpretation (e.g. a slack conversation).

This comment has been minimized.

@lsmith77

lsmith77 Apr 24, 2018

Contributor

I would see slack included here .. I am hestitant to explicitly mention all our “official” platforms of communication, since it means we need to update this frequently. but if it helps clarity maybe we should?

so what are the official places?

  • github
  • symfony.com
  • slack
  • symfony events

That being said, I am also hoping that some projects within our eco-system start adopting our CoC and enforcement process. So in that respect explicit listing might not be ideal. I was hoping for us to implement GDPR which would have entailed actually asking people to consent to the CoC on all our platforms, which in turn would mean that if anyone also adopts our CoC, they would then ask for consent on those additional platforms.

@javiereguiluz

This comment has been minimized.

Member

javiereguiluz commented Apr 19, 2018

I've reviewed this again and I like it a lot ... except for two phrases which in my opinion are back doors to power abuse:

Examples of unacceptable behavior: [...] Other conduct which could reasonably be
considered inappropriate in a professional setting.

Enforcement team members have the right [...] to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate.

If we could remove the first phrase and reword the second one, I would vote 👍 on this. Thanks!

@michellesanver

This comment has been minimized.

Contributor

michellesanver commented Apr 20, 2018

I disagree with your statement @javiereguiluz. It is impossible to cover all cases in a CoC, so we do need some way to catch things that may not be explicitly covered. The key to the sentence is "reasonably". This can always be argued, and since it is several enforcers and not just one person, that hopefully the community would trust makes the right judgement calls, I'd not worry. If it's one person the risk for "power abuse" might be higher.

-----------
This Code of Conduct is adapted from the `Contributor Covenant`_, version 1.4,
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html

This comment has been minimized.

@xabbuh

xabbuh Apr 20, 2018

Member

Is that link required here since "Contributor Covenant" is already linked?

This comment has been minimized.

@egircys

egircys Apr 20, 2018

Member

Good catch! The Contributor Covenant should actually link to https://www.contributor-covenant.org

This Code of Conduct is adapted from the `Contributor Covenant`_, version 1.4,
available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
Related documents

This comment has been minimized.

@xabbuh

xabbuh Apr 20, 2018

Member

Documents

@fabpot fabpot changed the base branch from master to 2.7 Apr 30, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Apr 30, 2018

Thanks a lot to all participants! Great collective work.

@fabpot fabpot merged commit 02e4860 into symfony:2.7 Apr 30, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

fabpot added a commit that referenced this pull request Apr 30, 2018

feature #9394 Adding Code of Conduct (egircys)
This PR was submitted for the master branch but it was squashed and merged into the 2.7 branch instead (closes #9394).

Discussion
----------

Adding Code of Conduct

Adding the Contributor Covenant Code of Conduct version 1.4.
Relates to symfony/diversity#1

**TODO**
- [x] Add the link to the enforcement team page
- [x] Add the link to the enforcement process
- [x] Add the link to concrete real-world examples of unwanted behavior
- [x] Change "Project maintainers" to "Enforcement team members"

Part of #9340 and #9393

Replaces symfony/symfony#24896

Commits
-------

02e4860 update contributor covenant link & documents fix
2de768f change project team to enforcement team
0e7b539 add link to core team
e61a403 Replace ethnicity with ethnic origin
2f8aa5d Change "race" to "ethnic origin"
1b0e633 Change "project's leadership" to "core team"
464ea45 add link to examples document
eba3ecf Adding Code of Conduct

fabpot added a commit to symfony/symfony that referenced this pull request Apr 30, 2018

feature #24896 Add CODE_OF_CONDUCT.md (egircys)
This PR was squashed before being merged into the 2.7 branch (closes #24896).

Discussion
----------

Add CODE_OF_CONDUCT.md

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | n/a
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

GitHub allows specifying a code of conduct for an open source project https://help.github.com/articles/adding-a-code-of-conduct-to-your-project/

The rule set seems maybe obvious, but it's good to have it included.

I've adopted the version http://contributor-covenant.org/version/1/4/ with the email coc@sensiolabs.com

Moved initial proposal to symfony/symfony-docs#9394

Commits
-------

bbbafba Add CODE_OF_CONDUCT.md

@sstok sstok referenced this pull request Apr 30, 2018

Closed

adopt a code of conduct #1

@egircys egircys deleted the egircys:code_of_conduct branch Apr 30, 2018

@lsmith77

This comment has been minimized.

Contributor

lsmith77 commented Apr 30, 2018

amazing!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment