Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "!event" deprecation #1046

Merged
merged 1 commit into from Feb 24, 2017

Conversation

@dunglas
Copy link
Member

commented Feb 22, 2017

No description provided.

@stof

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

I would use single quotes. Single-quoted YAML scalars are simpler, because there are no special chars inside them (except the single quote itself)

@dunglas dunglas force-pushed the dunglas:deprecations branch from 02005b4 to 4f6fccf Feb 23, 2017

@dunglas

This comment has been minimized.

Copy link
Member Author

commented Feb 23, 2017

@stof done (I've also replaced all existing double quotes by single quotes for the sake of consistency).

@xabbuh
xabbuh approved these changes Feb 23, 2017
@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Shouldn't this be done in 2.7 instead?

@dunglas

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2017

Why not, but the deprecation is triggered only since 3.3.

@stof

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Replacing existing quotes should indeed be done in 2.7, to make merging branches easier

@dunglas dunglas changed the base branch from master to 2.7 Feb 24, 2017

@dunglas dunglas force-pushed the dunglas:deprecations branch from 4f6fccf to 68a714d Feb 24, 2017

@dunglas dunglas force-pushed the dunglas:deprecations branch from 68a714d to f63ce95 Feb 24, 2017

@dunglas

This comment has been minimized.

Copy link
Member Author

commented Feb 24, 2017

  • Switched to 2.7
  • Uniformized indentation (no align)
  • Unifomized comments
@fabpot

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Thank you @dunglas.

@fabpot fabpot merged commit f63ce95 into symfony:2.7 Feb 24, 2017

1 check passed

fabbot.io Your code looks good.
Details
fabpot added a commit that referenced this pull request Feb 24, 2017
minor #1046 Fix "!event" deprecation (dunglas)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix "!event" deprecation

Commits
-------

f63ce95 Uniformize config files and fix deprecations

@dunglas dunglas deleted the dunglas:deprecations branch Feb 24, 2017

@chalasr

This comment has been minimized.

Copy link
Member

commented on f63ce95 Mar 15, 2017

@fabpot I think something went wrong when merging this up to master, looking at app/config/config.yml it looks like only 2.7, 3.2 and master include the changes made in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.