Add commented framework.validation.cache = apc to prod config #520

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

adrienbrault commented Apr 3, 2013

Hey,

After some XHProf, I found that this setting was important to get the best performance in production.

I think it make sense to have it as a comment like doctrine caches.

fabpot added a commit that referenced this pull request Apr 3, 2013

merged branch adrienbrault/patch-1 (PR #520)
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #520).

Discussion
----------

Add commented framework.validation.cache = apc to prod config

Hey,

After some XHProf, I found that this setting was important to get the best performance in production.

I think it make sense to have it as a comment like doctrine caches.

Commits
-------

2bfdaa0 Add commented framework.validation.cache = apc to prod config

@fabpot fabpot closed this Apr 3, 2013

Contributor

craue commented Apr 11, 2013

Is there any documentation for this? Would enabling it for the dev env cause changes not to be recognized?

Member

stof commented Apr 11, 2013

@craue If you enable it in dev, you have to restart APC each time you change your validation mapping to get the changes

Contributor

craue commented Apr 11, 2013

Thx @stof, this is what I wanted to know. ;)

To be clear its commented because it causes slow downs in prod?

"After some XHProf, I found that this setting was important to get the best performance in production."

i am unclear if this was commented due to commenting it getting best performance?

Member

stof commented Oct 13, 2013

@bandroidx It is commented because we cannot assume that all our users will have APC installed. They may need to use a different cache implementation (especially for people using PHP 5.5 which may choose something else than APCu as the user cache is now separate from the opcode cache).
But having it commented makes it clear that it can be used in prod (uncommenting it is easier than having to read the doc to know it exists)

Contributor

craue commented Oct 14, 2013

@bandroidx: Uncommenting it (and thus using the setting) will yield better performance.

Thanks stof and craue, that clears it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment