New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Incenteev ParameterHandler to ignore the parameters.yml file #522

Merged
merged 1 commit into from May 1, 2013

Conversation

Projects
None yet
@stof
Member

stof commented Apr 6, 2013

This tool allows to create the parameters.yml file when running composer install based on the parameters.yml.dist file, which can then be kept ignored. It will ask interactively for missing values, using the value of the dist file as default value (or using it directly if composer is run non-interactively). More details are available in the Readme.

this should help people avoiding the warning about commited parameters.yml file.

@beberlei

This comment has been minimized.

Show comment
Hide comment
@beberlei

beberlei Apr 6, 2013

Contributor

<3

Contributor

beberlei commented Apr 6, 2013

<3

@egeloen

This comment has been minimized.

Show comment
Hide comment
@egeloen

egeloen commented Apr 6, 2013

👍

1 similar comment
@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 Apr 6, 2013

Contributor

+1

Contributor

lsmith77 commented Apr 6, 2013

+1

@pborreli

This comment has been minimized.

Show comment
Hide comment
@pborreli

pborreli Apr 6, 2013

👍 using it on all my projects

pborreli commented Apr 6, 2013

👍 using it on all my projects

@XWB

This comment has been minimized.

Show comment
Hide comment
@XWB

XWB commented Apr 6, 2013

+1

@pborreli

This comment has been minimized.

Show comment
Hide comment
@pborreli

pborreli Apr 6, 2013

@stof so maybe travis should run composer with --no-interaction option ?

pborreli commented Apr 6, 2013

@stof so maybe travis should run composer with --no-interaction option ?

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Apr 6, 2013

Member

@pborreli yeah, it should. (any Symfony Console based tool should be non-interactive on Travis to be safe)

Member

stof commented Apr 6, 2013

@pborreli yeah, it should. (any Symfony Console based tool should be non-interactive on Travis to be safe)

@pborreli

This comment has been minimized.

Show comment
Hide comment
@pborreli

pborreli Apr 6, 2013

@stof i meant adding the option directly in .travis.yml file

pborreli commented Apr 6, 2013

@stof i meant adding the option directly in .travis.yml file

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Apr 6, 2013

Member

done

Member

stof commented Apr 6, 2013

done

@pborreli

This comment has been minimized.

Show comment
Hide comment
@pborreli

pborreli commented Apr 6, 2013

🍰

@iambrosi

This comment has been minimized.

Show comment
Hide comment
@iambrosi

iambrosi Apr 6, 2013

Contributor

👍

Contributor

iambrosi commented Apr 6, 2013

👍

1 similar comment
@adrienbrault

This comment has been minimized.

Show comment
Hide comment
@adrienbrault

adrienbrault Apr 6, 2013

Contributor

👍

Contributor

adrienbrault commented Apr 6, 2013

👍

@peterjmit

This comment has been minimized.

Show comment
Hide comment
@peterjmit

peterjmit Apr 7, 2013

👍 always use this package, perfect for the standard ed.

peterjmit commented Apr 7, 2013

👍 always use this package, perfect for the standard ed.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Apr 9, 2013

Member

If you are cloning the Standard Edition from Github (instead of installing it via composer create-project), the experience is worse than before as you will have to copy the dist file first, even if you want to configure the projcet via the Web. So, what about providing a CLI tool (in the ParameterHandler repo or in the SE directly) that calls the ParameterHandler so that you can get the same experience whatever means of instsallation you choose?

Member

fabpot commented Apr 9, 2013

If you are cloning the Standard Edition from Github (instead of installing it via composer create-project), the experience is worse than before as you will have to copy the dist file first, even if you want to configure the projcet via the Web. So, what about providing a CLI tool (in the ParameterHandler repo or in the SE directly) that calls the ParameterHandler so that you can get the same experience whatever means of instsallation you choose?

@lsmith77

This comment has been minimized.

Show comment
Hide comment
@lsmith77

lsmith77 Apr 9, 2013

Contributor

the number of people that want to configure the SE via the web that install composer is queue minimal I would guess.

Contributor

lsmith77 commented Apr 9, 2013

the number of people that want to configure the SE via the web that install composer is queue minimal I would guess.

@pborreli

This comment has been minimized.

Show comment
Hide comment
@pborreli

pborreli Apr 9, 2013

@fabpot if you clone the SE from github, first thing to do next is to update composer deps, so it will install ParameterHandler and ask for the params, no ?

pborreli commented Apr 9, 2013

@fabpot if you clone the SE from github, first thing to do next is to update composer deps, so it will install ParameterHandler and ask for the params, no ?

@francoispluchino

This comment has been minimized.

Show comment
Hide comment
@francoispluchino

francoispluchino Apr 12, 2013

👍
@fabpot currently we must install the vendors via CLI before configuring parameters.yml via the web. It might be interesting to install completely stantard edition directly via the web (installation of vendors and generator of parameters.yml). This could solve the problem of double installation.

It would be able to use ParameterHandler in the CLI while keeping a complete installation via only the Web.

francoispluchino commented Apr 12, 2013

👍
@fabpot currently we must install the vendors via CLI before configuring parameters.yml via the web. It might be interesting to install completely stantard edition directly via the web (installation of vendors and generator of parameters.yml). This could solve the problem of double installation.

It would be able to use ParameterHandler in the CLI while keeping a complete installation via only the Web.

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Apr 12, 2013

Member

Don't forget that you can also download an archive with all vendors included. In that case, no need to go to the CLI. So, I need to at least take that into account when packaging Symfony for 2.3. I will see what it means... and yes, we have many download from symfony.com/download for the SE with vendors included.

Member

fabpot commented Apr 12, 2013

Don't forget that you can also download an archive with all vendors included. In that case, no need to go to the CLI. So, I need to at least take that into account when packaging Symfony for 2.3. I will see what it means... and yes, we have many download from symfony.com/download for the SE with vendors included.

@francoispluchino

This comment has been minimized.

Show comment
Hide comment
@francoispluchino

francoispluchino Apr 12, 2013

@fabpot My proposal can still function. The web installer detects the presence of the vendors.
If the vendors exists, the installer skips the vendors installation, or he updates the vendors depending of the choice of the user for example. We would have a configuration wizard for the CLI and the web.

francoispluchino commented Apr 12, 2013

@fabpot My proposal can still function. The web installer detects the presence of the vendors.
If the vendors exists, the installer skips the vendors installation, or he updates the vendors depending of the choice of the user for example. We would have a configuration wizard for the CLI and the web.

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Apr 13, 2013

Member

@fabpot The solution is actually quite simple: when building the archive with vendors included, include the parameters.yml in it too so that it is ready to use. All you need is checking that your build script does not remove the file generated by composer.

Member

stof commented Apr 13, 2013

@fabpot The solution is actually quite simple: when building the archive with vendors included, include the parameters.yml in it too so that it is ready to use. All you need is checking that your build script does not remove the file generated by composer.

@francoispluchino

This comment has been minimized.

Show comment
Hide comment
@francoispluchino

francoispluchino Apr 13, 2013

@stof 👍 But if I download the standard version with the vendors, and I update the vendors with Composer, what's going on? The parameters file is edited or not?

francoispluchino commented Apr 13, 2013

@stof 👍 But if I download the standard version with the vendors, and I update the vendors with Composer, what's going on? The parameters file is edited or not?

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Apr 13, 2013

Member

@francoispluchino if you run composer after that, the ScriptHandler will run, yes. But the ScriptHandler only asks you for missing keys (so it would not ask you anything at this point)

Member

stof commented Apr 13, 2013

@francoispluchino if you run composer after that, the ScriptHandler will run, yes. But the ScriptHandler only asks you for missing keys (so it would not ask you anything at this point)

fabpot added a commit that referenced this pull request May 1, 2013

merged branch stof/parameter_handler (PR #522)
This PR was merged into the master branch.

Discussion
----------

Added Incenteev ParameterHandler to ignore the parameters.yml file

This tool allows to create the parameters.yml file when running ``composer install`` based on the ``parameters.yml.dist`` file, which can then be kept ignored. It will ask interactively for missing values, using the value of the dist file as default value (or using it directly if composer is run non-interactively). More details are available in the [Readme](https://github.com/Incenteev/ParameterHandler/).

this should help people avoiding the warning about commited parameters.yml file.

Commits
-------

8308995 Added Incenteev ParameterHandler to ignore the parameters.yml file

@fabpot fabpot merged commit 8308995 into symfony:master May 1, 2013

@krispypen

This comment has been minimized.

Show comment
Hide comment
@krispypen

krispypen Jul 21, 2013

Since 2.3.0 the symfony/framework-standard-edition zip file created from our satis server has no parameters.yml and no parameters.yml.dist. don't know if this is the perfect location for reporting my problem :)

krispypen commented on 8308995 Jul 21, 2013

Since 2.3.0 the symfony/framework-standard-edition zip file created from our satis server has no parameters.yml and no parameters.yml.dist. don't know if this is the perfect location for reporting my problem :)

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jul 22, 2013

Member

Can you create an issue instead?

Member

fabpot replied Jul 22, 2013

Can you create an issue instead?

@stof stof deleted the stof:parameter_handler branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment