New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved back dep binaries into vendor/dir #772

Merged
merged 1 commit into from Jan 19, 2015

Conversation

Projects
None yet
7 participants
@fabpot
Member

fabpot commented Jan 17, 2015

Move back all binaries from deps in vendor/dir, it's more standard amongst PHP projects using Composer.

@gnugat

This comment has been minimized.

Show comment
Hide comment
@gnugat

gnugat Jan 17, 2015

Not to mention that it allows developers to create their own scripts in the bin folder, now that it is no longer ignored.

gnugat commented Jan 17, 2015

Not to mention that it allows developers to create their own scripts in the bin folder, now that it is no longer ignored.

@wouterj

This comment has been minimized.

Show comment
Hide comment
@wouterj

wouterj Jan 17, 2015

Member

👍

Member

wouterj commented Jan 17, 2015

👍

2 similar comments
@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Jan 17, 2015

Member

👍

Member

stof commented Jan 17, 2015

👍

@hacfi

This comment has been minimized.

Show comment
Hide comment
@hacfi

hacfi commented Jan 17, 2015

👍

@weaverryan

This comment has been minimized.

Show comment
Hide comment
@weaverryan

weaverryan Jan 18, 2015

Member

👍 And I think going into master is correct - it'll cause issues with documentation (hey, why do I get command not found when running bin/XXXX?) and I think doing it in 3.0 will help that a lot.

Member

weaverryan commented Jan 18, 2015

👍 And I think going into master is correct - it'll cause issues with documentation (hey, why do I get command not found when running bin/XXXX?) and I think doing it in 3.0 will help that a lot.

@Pierstoval

This comment has been minimized.

Show comment
Hide comment
@Pierstoval

Pierstoval Jan 19, 2015

Contributor

👍 too, it's a bit confusing to have first "app/console", then "bin/console", but afterwards having console in the same dir as doctrine, because we never use doctrine "manually" , so a single sir for all vendor bin is great !

Contributor

Pierstoval commented Jan 19, 2015

👍 too, it's a bit confusing to have first "app/console", then "bin/console", but afterwards having console in the same dir as doctrine, because we never use doctrine "manually" , so a single sir for all vendor bin is great !

@fabpot fabpot merged commit 02507f0 into master Jan 19, 2015

1 check passed

fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jan 19, 2015

feature #772 moved back dep binaries into vendor/dir (fabpot)
This PR was merged into the 3.0-dev branch.

Discussion
----------

moved back dep binaries into vendor/dir

Move back all binaries from deps in `vendor/dir`, it's more standard amongst PHP projects using Composer.

Commits
-------

02507f0 moved back dep binaries into vendor/dir

@fabpot fabpot deleted the standard-bin-dir branch Jan 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment