Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature #20467 [DomCrawler] Add support for formaction and formmethod…
… attributes (stof) This PR was merged into the 3.3-dev branch. Discussion ---------- [DomCrawler] Add support for formaction and formmethod attributes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This adds supports for the ``formaction`` and ``formmethod`` of submit elements, which override the values defined on the ``<form>`` element. This works only when you call ``$crawler->form()`` on a Crawler containing a button, not when it contains the ``<form>`` itself of course (as the button override is applied only when using this button to submit, not when using another way). Other button-level overrides are not implemented: - ``formtarget`` is useless as we don't implement ``target`` either (the Crawler does not deal with frame-based pages anyway) - ``formnovalidate`` is ignored, as we don't automatically disable the form validation on ``novalidate`` either, but we require an explicit disabling instead (this might be subject to a separate PR though, as it could make sense) - ``formenctype`` is ignored as we also ignore ``enctype`` (we always submit file fields, even when missing the proper enctype) Commits ------- 717cf8a [DomCrawler] Add support for formaction and formmethod attributes
- Loading branch information