Permalink
Browse files

bug #24943 [FrameworkBundle] Wire the translation.reader service inst…

…ead of deprecated translation.loader in commands (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

to get rid of the following deprec:

> The class "Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader" is deprecated since version 3.4 and will be removed in 4.0. Use "Symfony\Component\Translation\Reader\TranslationReader"

Commits
-------

8da283b [FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands
  • Loading branch information...
fabpot committed Nov 13, 2017
2 parents e2ad892 + 8da283b commit 136e3b2d17574c0db5e26dc9609e0b04918ee7f5
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/Symfony/Bundle/FrameworkBundle/Resources/config/console.xml
@@ -76,14 +76,14 @@
<service id="Symfony\Bundle\FrameworkBundle\Command\TranslationDebugCommand">
<argument type="service" id="translator" />
<argument type="service" id="translation.loader" />
<argument type="service" id="translation.reader" />
<argument type="service" id="translation.extractor" />
<tag name="console.command" command="debug:translation" />
</service>
<service id="Symfony\Bundle\FrameworkBundle\Command\TranslationUpdateCommand">
<argument type="service" id="translation.writer" />
<argument type="service" id="translation.loader" />
<argument type="service" id="translation.reader" />
<argument type="service" id="translation.extractor" />
<argument>%kernel.default_locale%</argument>
<tag name="console.command" command="translation:update" />

0 comments on commit 136e3b2

Please sign in to comment.