Permalink
Browse files

feature #24104 Make as many services private as possible (nicolas-gre…

…kas)

This PR was merged into the 3.4 branch.

Discussion
----------

Make as many services private as possible

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | not yet
| Fixed tickets | #23822
| License       | MIT
| Doc PR        | -

- [x] review the list of currently public services and validate which one should be turned private (noted as such with the `container.private` tag in this PR)
- [x] rebase on top of #24103
- [x] implement the behavior described in #23822 (comment)
- [x] add tests

List of services that will be kept public:

### Remaining public aliases

cache.app_clearer <- for the cache:pool:clear command to clear app pools
$commandId <- for non-lazy commands which are get() at runtime
router <- for the base controller
templating <- for the base controller

### Remaining public services

test.client <- for WebTestCase
security.password_encoder <- for use in ContainerAware classes
security.authentication_utils <- for use in ContainerAware classes
filesystem <- for use in ContainerAware classes
kernel <- for use in ContainerAware classes
translator <- for use in ContainerAware classes
validator <- for use in ContainerAware classes
cache_clearer <- for the cache:clear command
cache_warmer <- required to bootstrap the kernel
cache.app <- for userland only
cache.global_clearer <- for the cache:pool:clear command to clear all pools
cache.system <- for userland only
data_collector.dump <- required to have dump() work very early when booting the kernel
event_dispatcher <- required to wire console apps
form.factory <- for the base controller
http_kernel <- required to bootstrap the kernel
profiler <- used in tests
request_stack <- for the base controller
routing.loader <- used by routing
security.authorization_checker <- for the base controller
security.csrf.token_manager <- for the base controller
security.token_storage <- for the base controller
serializer <- for the base controller
session <- for the base controller
state_machine.abstract <- userland state machines
workflow.abstract <- userland workflows
twig <- for the base controller
twig.controller.exception <- controllers referenced by routing
twig.controller.preview_error <- controllers referenced by routing
var_dumper.cloner <- required to have dump() work very early when booting the kernel
web_profiler.controller.exception <- controllers referenced by routing
web_profiler.controller.profiler <- controllers referenced by routing
web_profiler.controller.router <- controllers referenced by routing

Commits
-------

1936491 Make as many services private as possible
  • Loading branch information...
nicolas-grekas committed Sep 13, 2017
2 parents ade060e + 1936491 commit 306bd48ac12e88d8fb9ac287ddc762cb6c67a302
Showing with 758 additions and 185 deletions.
  1. +3 −0 src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php
  2. +3 −0 src/Symfony/Bundle/DebugBundle/DependencyInjection/DebugExtension.php
  3. +2 −2 src/Symfony/Bundle/DebugBundle/Resources/config/services.xml
  4. +4 −1 src/Symfony/Bundle/DebugBundle/composer.json
  5. +154 −7 src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
  6. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/annotations.xml
  7. +5 −5 src/Symfony/Bundle/FrameworkBundle/Resources/config/assets.xml
  8. +8 −8 src/Symfony/Bundle/FrameworkBundle/Resources/config/cache.xml
  9. +2 −2 src/Symfony/Bundle/FrameworkBundle/Resources/config/collectors.xml
  10. +3 −3 src/Symfony/Bundle/FrameworkBundle/Resources/config/debug.xml
  11. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/debug_prod.xml
  12. +2 −2 src/Symfony/Bundle/FrameworkBundle/Resources/config/esi.xml
  13. +4 −13 src/Symfony/Bundle/FrameworkBundle/Resources/config/form.xml
  14. +2 −4 src/Symfony/Bundle/FrameworkBundle/Resources/config/form_csrf.xml
  15. +3 −3 src/Symfony/Bundle/FrameworkBundle/Resources/config/form_debug.xml
  16. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_listener.xml
  17. +5 −5 src/Symfony/Bundle/FrameworkBundle/Resources/config/fragment_renderer.xml
  18. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/profiling.xml
  19. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/property_access.xml
  20. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/property_info.xml
  21. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/request.xml
  22. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/routing.xml
  23. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/serializer.xml
  24. +4 −4 src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml
  25. +5 −5 src/Symfony/Bundle/FrameworkBundle/Resources/config/session.xml
  26. +2 −2 src/Symfony/Bundle/FrameworkBundle/Resources/config/ssi.xml
  27. +2 −2 src/Symfony/Bundle/FrameworkBundle/Resources/config/templating.xml
  28. +11 −11 src/Symfony/Bundle/FrameworkBundle/Resources/config/templating_php.xml
  29. +3 −3 src/Symfony/Bundle/FrameworkBundle/Resources/config/test.xml
  30. +28 −28 src/Symfony/Bundle/FrameworkBundle/Resources/config/translation.xml
  31. +1 −1 src/Symfony/Bundle/FrameworkBundle/Resources/config/translation_debug.xml
  32. +3 −3 src/Symfony/Bundle/FrameworkBundle/Resources/config/validator.xml
  33. +4 −4 src/Symfony/Bundle/FrameworkBundle/Resources/config/web.xml
  34. +3 −3 src/Symfony/Bundle/FrameworkBundle/Resources/config/workflow.xml
  35. +2 −2 src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolClearCommandTest.php
  36. +1 −1 src/Symfony/Bundle/FrameworkBundle/Tests/Functional/PropertyInfoTest.php
  37. +3 −0 src/Symfony/Bundle/FrameworkBundle/Tests/Functional/app/Serializer/config.yml
  38. +18 −3 src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
  39. +0 −1 src/Symfony/Bundle/SecurityBundle/Resources/config/guard.xml
  40. +4 −4 src/Symfony/Bundle/SecurityBundle/Resources/config/security.xml
  41. +3 −3 src/Symfony/Bundle/SecurityBundle/Resources/config/security_acl_dbal.xml
  42. +1 −1 src/Symfony/Bundle/SecurityBundle/Resources/config/security_debug.xml
  43. +1 −1 src/Symfony/Bundle/SecurityBundle/Resources/config/security_rememberme.xml
  44. +2 −2 src/Symfony/Bundle/SecurityBundle/Resources/config/templating_php.xml
  45. +5 −5 src/Symfony/Bundle/SecurityBundle/Tests/Functional/SetAclCommandTest.php
  46. +3 −0 src/Symfony/Bundle/SecurityBundle/Tests/Functional/app/Acl/config.yml
  47. +2 −1 src/Symfony/Bundle/SecurityBundle/composer.json
  48. +3 −2 src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/TwigLoaderPass.php
  49. +7 −0 src/Symfony/Bundle/TwigBundle/DependencyInjection/TwigExtension.php
  50. +1 −1 src/Symfony/Bundle/TwigBundle/Resources/config/form.xml
  51. +5 −5 src/Symfony/Bundle/TwigBundle/Resources/config/twig.xml
  52. +7 −3 src/Symfony/Bundle/TwigBundle/Tests/DependencyInjection/Compiler/TwigLoaderPassTest.php
  53. +4 −3 src/Symfony/Bundle/TwigBundle/composer.json
  54. +1 −0 src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/WebProfilerExtension.php
  55. +1 −1 src/Symfony/Bundle/WebProfilerBundle/Resources/config/toolbar.xml
  56. +3 −3 src/Symfony/Bundle/WebProfilerBundle/composer.json
  57. +34 −0 src/Symfony/Component/DependencyInjection/Alias.php
  58. +1 −1 src/Symfony/Component/DependencyInjection/Compiler/CheckDefinitionValidityPass.php
  59. +3 −1 src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php
  60. +1 −1 src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
  61. +1 −1 src/Symfony/Component/DependencyInjection/Compiler/RemovePrivateAliasesPass.php
  62. +3 −2 src/Symfony/Component/DependencyInjection/Compiler/RemoveUnusedDefinitionsPass.php
  63. +3 −2 src/Symfony/Component/DependencyInjection/Compiler/ReplaceAliasByActualDefinitionPass.php
  64. +23 −0 src/Symfony/Component/DependencyInjection/Compiler/ResolveChildDefinitionsPass.php
  65. +1 −1 src/Symfony/Component/DependencyInjection/Compiler/ResolveReferencesToAliasesPass.php
  66. +3 −1 src/Symfony/Component/DependencyInjection/ContainerBuilder.php
  67. +30 −0 src/Symfony/Component/DependencyInjection/Definition.php
  68. +9 −3 src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
  69. +20 −0 src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveChildDefinitionsPassTest.php
  70. +46 −0 src/Symfony/Component/DependencyInjection/Tests/Dumper/PhpDumperTest.php
  71. +200 −0 src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services_legacy_privates.php
  72. +28 −0 src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services_legacy_privates.yml
@@ -333,6 +333,7 @@ protected function loadCacheDriver($cacheName, $objectManagerName, array $cacheD
$memcachePort = !empty($cacheDriver['port']) || (isset($cacheDriver['port']) && $cacheDriver['port'] === 0) ? $cacheDriver['port'] : '%'.$this->getObjectManagerElementName('cache.memcache_port').'%';
$cacheDef = new Definition($memcacheClass);
$memcacheInstance = new Definition($memcacheInstanceClass);
$memcacheInstance->setPrivate(true);
$memcacheInstance->addMethodCall('connect', array(
$memcacheHost, $memcachePort,
));
@@ -346,6 +347,7 @@ protected function loadCacheDriver($cacheName, $objectManagerName, array $cacheD
$memcachedPort = !empty($cacheDriver['port']) ? $cacheDriver['port'] : '%'.$this->getObjectManagerElementName('cache.memcached_port').'%';
$cacheDef = new Definition($memcachedClass);
$memcachedInstance = new Definition($memcachedInstanceClass);
$memcachedInstance->setPrivate(true);
$memcachedInstance->addMethodCall('addServer', array(
$memcachedHost, $memcachedPort,
));
@@ -359,6 +361,7 @@ protected function loadCacheDriver($cacheName, $objectManagerName, array $cacheD
$redisPort = !empty($cacheDriver['port']) ? $cacheDriver['port'] : '%'.$this->getObjectManagerElementName('cache.redis_port').'%';
$cacheDef = new Definition($redisClass);
$redisInstance = new Definition($redisInstanceClass);
$redisInstance->setPrivate(true);
$redisInstance->addMethodCall('connect', array(
$redisHost, $redisPort,
));
@@ -35,6 +35,9 @@ public function load(array $configs, ContainerBuilder $container)
$loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
$loader->load('services.xml');
$container->getDefinition('debug.dump_listener')->setPrivate(true);
$container->getDefinition('var_dumper.cli_dumper')->setPrivate(true);
$container->getDefinition('var_dumper.cloner')
->addMethodCall('setMaxItems', array($config['max_items']))
->addMethodCall('setMinDepth', array($config['min_depth']))
@@ -22,14 +22,14 @@
<argument>null</argument><!-- var_dumper.cli_dumper when debug.dump_destination is set -->
</service>
<service id="debug.dump_listener" class="Symfony\Component\HttpKernel\EventListener\DumpListener" public="true">
<service id="debug.dump_listener" class="Symfony\Component\HttpKernel\EventListener\DumpListener">
<tag name="kernel.event_subscriber" />
<argument type="service" id="var_dumper.cloner" />
<argument type="service" id="var_dumper.cli_dumper" />
</service>
<service id="var_dumper.cloner" class="Symfony\Component\VarDumper\Cloner\VarCloner" public="true" />
<service id="var_dumper.cli_dumper" class="Symfony\Component\VarDumper\Dumper\CliDumper" public="true">
<service id="var_dumper.cli_dumper" class="Symfony\Component\VarDumper\Dumper\CliDumper">
<argument>null</argument><!-- debug.dump_destination -->
<argument>%kernel.charset%</argument>
<argument>0</argument> <!-- flags -->
@@ -24,9 +24,12 @@
},
"require-dev": {
"symfony/config": "~3.3|~4.0",
"symfony/dependency-injection": "~3.3|~4.0",
"symfony/dependency-injection": "~3.4|~4.0",
"symfony/web-profiler-bundle": "~2.8|~3.0|~4.0"
},
"conflict": {
"symfony/dependency-injection": "<3.4"
},
"suggest": {
"symfony/config": "For service container configuration",
"symfony/dependency-injection": "For using as a service from the container"

Large diffs are not rendered by default.

Oops, something went wrong.
@@ -49,7 +49,7 @@
</argument>
</service>
<service id="annotation_reader" alias="annotations.reader" public="true" />
<service id="annotation_reader" alias="annotations.reader" />
<service id="Doctrine\Common\Annotations\Reader" alias="annotation_reader" />
</services>
</container>
@@ -7,7 +7,7 @@
<services>
<defaults public="false" />
<service id="assets.packages" class="Symfony\Component\Asset\Packages" public="true">
<service id="assets.packages" class="Symfony\Component\Asset\Packages">
<argument type="service" id="assets.empty_package" /> <!-- default package -->
<argument type="collection" /> <!-- named packages -->
</service>
@@ -17,23 +17,23 @@
<argument type="service" id="assets.empty_version_strategy" />
</service>
<service id="assets.context" class="Symfony\Component\Asset\Context\RequestStackContext" public="true">
<service id="assets.context" class="Symfony\Component\Asset\Context\RequestStackContext">
<argument type="service" id="request_stack" />
</service>
<service id="assets.path_package" class="Symfony\Component\Asset\PathPackage" abstract="true" public="true">
<service id="assets.path_package" class="Symfony\Component\Asset\PathPackage" abstract="true">
<argument /> <!-- base path -->
<argument /> <!-- version strategy -->
<argument type="service" id="assets.context" />
</service>
<service id="assets.url_package" class="Symfony\Component\Asset\UrlPackage" abstract="true" public="true">
<service id="assets.url_package" class="Symfony\Component\Asset\UrlPackage" abstract="true">
<argument /> <!-- base URLs -->
<argument /> <!-- version strategy -->
<argument type="service" id="assets.context" />
</service>
<service id="assets.static_version_strategy" class="Symfony\Component\Asset\VersionStrategy\StaticVersionStrategy" abstract="true" public="true">
<service id="assets.static_version_strategy" class="Symfony\Component\Asset\VersionStrategy\StaticVersionStrategy" abstract="true">
<argument /> <!-- version -->
<argument /> <!-- format -->
</service>
@@ -27,7 +27,7 @@
<tag name="cache.pool" />
</service>
<service id="cache.adapter.system" class="Symfony\Component\Cache\Adapter\AdapterInterface" abstract="true" public="true">
<service id="cache.adapter.system" class="Symfony\Component\Cache\Adapter\AdapterInterface" abstract="true">
<factory class="Symfony\Component\Cache\Adapter\AbstractAdapter" method="createSystemCache" />
<tag name="cache.pool" clearer="cache.default_clearer" />
<tag name="monolog.logger" channel="cache" />
@@ -38,7 +38,7 @@
<argument type="service" id="logger" on-invalid="ignore" />
</service>
<service id="cache.adapter.apcu" class="Symfony\Component\Cache\Adapter\ApcuAdapter" abstract="true" public="true">
<service id="cache.adapter.apcu" class="Symfony\Component\Cache\Adapter\ApcuAdapter" abstract="true">
<tag name="cache.pool" clearer="cache.default_clearer" />
<tag name="monolog.logger" channel="cache" />
<argument /> <!-- namespace -->
@@ -49,7 +49,7 @@
</call>
</service>
<service id="cache.adapter.doctrine" class="Symfony\Component\Cache\Adapter\DoctrineAdapter" abstract="true" public="true">
<service id="cache.adapter.doctrine" class="Symfony\Component\Cache\Adapter\DoctrineAdapter" abstract="true">
<tag name="cache.pool" provider="cache.default_doctrine_provider" clearer="cache.default_clearer" />
<tag name="monolog.logger" channel="cache" />
<argument /> <!-- Doctrine provider service -->
@@ -60,7 +60,7 @@
</call>
</service>
<service id="cache.adapter.filesystem" class="Symfony\Component\Cache\Adapter\FilesystemAdapter" abstract="true" public="true">
<service id="cache.adapter.filesystem" class="Symfony\Component\Cache\Adapter\FilesystemAdapter" abstract="true">
<tag name="cache.pool" clearer="cache.default_clearer" />
<tag name="monolog.logger" channel="cache" />
<argument /> <!-- namespace -->
@@ -71,14 +71,14 @@
</call>
</service>
<service id="cache.adapter.psr6" class="Symfony\Component\Cache\Adapter\ProxyAdapter" abstract="true" public="true">
<service id="cache.adapter.psr6" class="Symfony\Component\Cache\Adapter\ProxyAdapter" abstract="true">
<tag name="cache.pool" provider="cache.default_psr6_provider" clearer="cache.default_clearer" />
<argument /> <!-- PSR-6 provider service -->
<argument /> <!-- namespace -->
<argument>0</argument> <!-- default lifetime -->
</service>
<service id="cache.adapter.redis" class="Symfony\Component\Cache\Adapter\RedisAdapter" abstract="true" public="true">
<service id="cache.adapter.redis" class="Symfony\Component\Cache\Adapter\RedisAdapter" abstract="true">
<tag name="cache.pool" provider="cache.default_redis_provider" clearer="cache.default_clearer" />
<tag name="monolog.logger" channel="cache" />
<argument /> <!-- Redis connection service -->
@@ -89,7 +89,7 @@
</call>
</service>
<service id="cache.adapter.memcached" class="Symfony\Component\Cache\Adapter\MemcachedAdapter" abstract="true" public="true">
<service id="cache.adapter.memcached" class="Symfony\Component\Cache\Adapter\MemcachedAdapter" abstract="true">
<tag name="cache.pool" provider="cache.default_memcached_provider" clearer="cache.default_clearer" />
<tag name="monolog.logger" channel="cache" />
<argument /> <!-- Memcached connection service -->
@@ -100,7 +100,7 @@
</call>
</service>
<service id="cache.default_clearer" class="Symfony\Component\HttpKernel\CacheClearer\Psr6CacheClearer" public="true">
<service id="cache.default_clearer" class="Symfony\Component\HttpKernel\CacheClearer\Psr6CacheClearer">
<tag name="kernel.cache_clearer" />
</service>
@@ -12,7 +12,7 @@
<call method="setKernel"><argument type="service" id="kernel" on-invalid="ignore" /></call>
</service>
<service id="data_collector.request" class="Symfony\Bundle\FrameworkBundle\DataCollector\RequestDataCollector" public="true">
<service id="data_collector.request" class="Symfony\Bundle\FrameworkBundle\DataCollector\RequestDataCollector">
<tag name="kernel.event_subscriber" />
<tag name="data_collector" template="@WebProfiler/Collector/request.html.twig" id="request" priority="335" />
</service>
@@ -47,7 +47,7 @@
<tag name="data_collector" template="@WebProfiler/Collector/memory.html.twig" id="memory" priority="325" />
</service>
<service id="data_collector.router" class="Symfony\Bundle\FrameworkBundle\DataCollector\RouterDataCollector" public="true">
<service id="data_collector.router" class="Symfony\Bundle\FrameworkBundle\DataCollector\RouterDataCollector">
<tag name="kernel.event_listener" event="kernel.controller" method="onKernelController"/>
<tag name="data_collector" template="@WebProfiler/Collector/router.html.twig" id="router" priority="285" />
</service>
@@ -7,20 +7,20 @@
<services>
<defaults public="false" />
<service id="debug.event_dispatcher" class="Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher" decorates="event_dispatcher" public="true">
<service id="debug.event_dispatcher" class="Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher" decorates="event_dispatcher">
<tag name="monolog.logger" channel="event" />
<argument type="service" id="debug.event_dispatcher.inner" />
<argument type="service" id="debug.stopwatch" />
<argument type="service" id="logger" on-invalid="null" />
</service>
<service id="debug.controller_resolver" decorates="controller_resolver" class="Symfony\Component\HttpKernel\Controller\TraceableControllerResolver" public="true">
<service id="debug.controller_resolver" decorates="controller_resolver" class="Symfony\Component\HttpKernel\Controller\TraceableControllerResolver">
<argument type="service" id="debug.controller_resolver.inner" />
<argument type="service" id="debug.stopwatch" />
<argument type="service" id="argument_resolver" />
</service>
<service id="debug.argument_resolver" decorates="argument_resolver" class="Symfony\Component\HttpKernel\Controller\TraceableArgumentResolver" public="true">
<service id="debug.argument_resolver" decorates="argument_resolver" class="Symfony\Component\HttpKernel\Controller\TraceableArgumentResolver">
<argument type="service" id="debug.argument_resolver.inner" />
<argument type="service" id="debug.stopwatch" />
</service>
@@ -11,7 +11,7 @@
<services>
<defaults public="false" />
<service id="debug.debug_handlers_listener" class="Symfony\Component\HttpKernel\EventListener\DebugHandlersListener" public="true">
<service id="debug.debug_handlers_listener" class="Symfony\Component\HttpKernel\EventListener\DebugHandlersListener">
<tag name="kernel.event_subscriber" />
<tag name="monolog.logger" channel="php" />
<argument>null</argument><!-- Exception handler -->
@@ -7,9 +7,9 @@
<services>
<defaults public="false" />
<service id="esi" class="Symfony\Component\HttpKernel\HttpCache\Esi" public="true" />
<service id="esi" class="Symfony\Component\HttpKernel\HttpCache\Esi" />
<service id="esi_listener" class="Symfony\Component\HttpKernel\EventListener\SurrogateListener" public="true">
<service id="esi_listener" class="Symfony\Component\HttpKernel\EventListener\SurrogateListener">
<tag name="kernel.event_subscriber" />
<argument type="service" id="esi" on-invalid="ignore" />
</service>
@@ -8,11 +8,11 @@
<defaults public="false" />
<!-- ResolvedFormTypeFactory -->
<service id="form.resolved_type_factory" class="Symfony\Component\Form\ResolvedFormTypeFactory" public="true" />
<service id="form.resolved_type_factory" class="Symfony\Component\Form\ResolvedFormTypeFactory" />
<service id="Symfony\Component\Form\ResolvedFormTypeFactoryInterface" alias="form.resolved_type_factory" />
<!-- FormRegistry -->
<service id="form.registry" class="Symfony\Component\Form\FormRegistry" public="true">
<service id="form.registry" class="Symfony\Component\Form\FormRegistry">
<argument type="collection">
<!--
We don't need to be able to add more extensions.
@@ -191,17 +191,8 @@
<argument type="string">%validator.translation_domain%</argument>
</service>
<service id="deprecated.form.registry" class="stdClass" public="true">
<property name="registry" type="collection">
<property type="service" id="form.type_guesser.validator" />
<property type="service" id="form.type.choice" />
<property type="service" id="form.type.form" />
<property type="service" id="form.type_extension.form.http_foundation" />
<property type="service" id="form.type_extension.form.validator" />
<property type="service" id="form.type_extension.repeated.validator" />
<property type="service" id="form.type_extension.submit.validator" />
<property type="service" id="form.type_extension.upload.validator" />
</property>
<service id="deprecated.form.registry" class="stdClass">
<property name="registry" type="collection" />
<deprecated>The service "%service_id%" is internal and deprecated since Symfony 3.3 and will be removed in Symfony 4.0</deprecated>
</service>
</services>
@@ -17,10 +17,8 @@
<argument type="service" id="form.server_params" />
</service>
<service id="deprecated.form.registry.csrf" class="stdClass" public="true">
<property name="registry" type="collection">
<property type="service" id="form.type_extension.csrf" />
</property>
<service id="deprecated.form.registry.csrf" class="stdClass">
<property name="registry" type="collection" />
<deprecated>The service "%service_id%" is internal and deprecated since Symfony 3.3 and will be removed in Symfony 4.0</deprecated>
</service>
</services>
@@ -7,7 +7,7 @@
<services>
<defaults public="false" />
<service id="form.resolved_type_factory" class="Symfony\Component\Form\Extension\DataCollector\Proxy\ResolvedTypeFactoryDataCollectorProxy" public="true">
<service id="form.resolved_type_factory" class="Symfony\Component\Form\Extension\DataCollector\Proxy\ResolvedTypeFactoryDataCollectorProxy">
<argument type="service">
<service class="Symfony\Component\Form\ResolvedFormTypeFactory" />
</argument>
@@ -21,9 +21,9 @@
</service>
<!-- DataCollector -->
<service id="data_collector.form.extractor" class="Symfony\Component\Form\Extension\DataCollector\FormDataExtractor" public="true" />
<service id="data_collector.form.extractor" class="Symfony\Component\Form\Extension\DataCollector\FormDataExtractor" />
<service id="data_collector.form" class="Symfony\Component\Form\Extension\DataCollector\FormDataCollector" public="true">
<service id="data_collector.form" class="Symfony\Component\Form\Extension\DataCollector\FormDataCollector">
<tag name="data_collector" template="@WebProfiler/Collector/form.html.twig" id="form" priority="310" />
<argument type="service" id="data_collector.form.extractor" />
</service>
@@ -7,7 +7,7 @@
<services>
<defaults public="false" />
<service id="fragment.listener" class="Symfony\Component\HttpKernel\EventListener\FragmentListener" public="true">
<service id="fragment.listener" class="Symfony\Component\HttpKernel\EventListener\FragmentListener">
<tag name="kernel.event_subscriber" />
<argument type="service" id="uri_signer" />
<argument>%fragment.path%</argument>
Oops, something went wrong.

0 comments on commit 306bd48

Please sign in to comment.