Skip to content
Permalink
Browse files

minor #30406 Removed non-existing parameters for LogoutUrlGenerator c…

…alls (King2500)

This PR was squashed before being merged into the 3.4 branch (closes #30406).

Discussion
----------

Removed non-existing parameters for LogoutUrlGenerator calls

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Is there a reason these arguments are in place, though they dont actually exist as parameters for `LogoutUrlGenerator::getLogoutPath` and `::getLogoutUrl`?
see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php#L76
and https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Http/Logout/LogoutUrlGenerator.php#L88

If there is no reason, this PR can be merged, because this parameter makes no sense there. ;-)

Commits
-------

d3ee2b6 Removed non-existing parameters for LogoutUrlGenerator calls
  • Loading branch information...
chalasr committed Mar 2, 2019
2 parents c8d6dec + d3ee2b6 commit 3af6406f5ed013cc003e8d4056239d9a4265bfc4
Showing with 2 additions and 3 deletions.
  1. +2 −3 src/Symfony/Bundle/SecurityBundle/Templating/Helper/LogoutUrlHelper.php
@@ -11,7 +11,6 @@
namespace Symfony\Bundle\SecurityBundle\Templating\Helper;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Symfony\Component\Security\Http\Logout\LogoutUrlGenerator;
use Symfony\Component\Templating\Helper\Helper;
@@ -38,7 +37,7 @@ public function __construct(LogoutUrlGenerator $generator)
*/
public function getLogoutPath($key)
{
return $this->generator->getLogoutPath($key, UrlGeneratorInterface::ABSOLUTE_PATH);
return $this->generator->getLogoutPath($key);
}
/**
@@ -50,7 +49,7 @@ public function getLogoutPath($key)
*/
public function getLogoutUrl($key)
{
return $this->generator->getLogoutUrl($key, UrlGeneratorInterface::ABSOLUTE_URL);
return $this->generator->getLogoutUrl($key);
}
/**

0 comments on commit 3af6406

Please sign in to comment.
You can’t perform that action at this time.