Please sign in to comment.
bug #27088 ResolveBindingsPass: Don't throw error for unused service,…
… missing parent class (weaverryan) This PR was merged into the 3.4 branch. Discussion ---------- ResolveBindingsPass: Don't throw error for unused service, missing parent class | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no-> | Tests pass? | yes | Fixed tickets | symfony/flex#346 (comment) | License | MIT | Doc PR | n/a Hey guys! In short: if you: A) auto-register a class as a service B) That class's parent class is missing C) ... but this class/service is unused Currently, `ResolveBindingsPass` will fail and throw an exception. The change avoids that - only throwing the exception if the service IS used. This is already done in `AutowirePass`. The real issue is DoctrineFixturesBundle, where, on production, the bundle (and so, `Fixtures` base class) is not installed, causing a build error, even though these service classes are unused. Cheers! Commits ------- 309da92 Avoiding an error when an unused service has a missing base class
- Loading branch information...
Showing with 9 additions and 2 deletions.