Skip to content
Permalink
Browse files

minor #32267 [FrameworkBundle] deprecate the framework.templating opt…

…ion (xabbuh)

This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] deprecate the framework.templating option

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #32120
| License       | MIT
| Doc PR        |

The config node has already been removed in the `master` branch in #31800. For DX it would have been better to have this deprecation in 4.3 (see e.g. #32120), but it's probably too late to ship this as a bugfix.

Commits
-------

ba241ce deprecate the framework.templating option
  • Loading branch information...
fabpot committed Jul 3, 2019
2 parents 6bf5d8f + ba241ce commit 51f01bdd9dbc685a672c8e4c403a8b4b77eadde2
@@ -77,6 +77,7 @@ Form
FrameworkBundle
---------------

* Deprecated the `framework.templating` option, use Twig instead.
* Not passing the project directory to the constructor of the `AssetsInstallCommand` is deprecated. This argument will
be mandatory in 5.0.
* Deprecated the "Psr\SimpleCache\CacheInterface" / "cache.app.simple" service, use "Symfony\Contracts\Cache\CacheInterface" / "cache.app" instead.
@@ -169,8 +169,8 @@ Form
FrameworkBundle
---------------

* Remved the `framework.templating` option, use Twig instead.
* The project dir argument of the constructor of `AssetsInstallCommand` is required.

* Removed support for `bundle:controller:action` syntax to reference controllers. Use `serviceOrFqcn::method`
instead where `serviceOrFqcn` is either the service ID when using controllers as services or the FQCN of the controller.

@@ -4,6 +4,7 @@ CHANGELOG
4.3.0
-----

* Deprecated the `framework.templating` option, use Twig instead.
* Added `WebTestAssertionsTrait` (included by default in `WebTestCase`)
* Renamed `Client` to `KernelBrowser`
* Not passing the project directory to the constructor of the `AssetsInstallCommand` is deprecated. This argument will
@@ -605,6 +605,7 @@ private function addTemplatingSection(ArrayNodeDefinition $rootNode)
->arrayNode('templating')
->info('templating configuration')
->canBeEnabled()
->setDeprecated('The "%path%.%node%" configuration is deprecated since Symfony 4.3. Use the "twig" service directly instead.')
->beforeNormalization()
->ifTrue(function ($v) { return false === $v || \is_array($v) && false === $v['enabled']; })
->then(function () { return ['enabled' => false, 'engines' => false]; })
@@ -35,6 +35,9 @@ public function testDefaultConfig()
);
}
/**
* @group legacy
*/
public function testDoNoDuplicateDefaultFormResources()
{
$input = ['templating' => [
@@ -602,6 +602,9 @@ public function testTemplating()
$this->assertEquals('global_hinclude_template', $container->getParameter('fragment.renderer.hinclude.global_template'), '->registerTemplatingConfiguration() registers the global hinclude.js template');
}
/**
* @group legacy
*/
public function testTemplatingCanBeDisabled()
{
$container = $this->createContainerFromFile('templating_disabled');
@@ -867,6 +870,7 @@ public function testTranslatorMultipleFallbacks()
}
/**
* @group legacy
* @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
*/
public function testTemplatingRequiresAtLeastOneEngine()

0 comments on commit 51f01bd

Please sign in to comment.
You can’t perform that action at this time.