Permalink
Browse files

minor #23744 [Form] Removed useless argument $definition (yceruto)

This PR was merged into the 3.3 branch.

Discussion
----------

[Form] Removed useless argument $definition

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

After https://github.com/symfony/symfony/pull/22175/files this argument is not used anymore.

Commits
-------

81396c7 Removed useless argument $definition
  • Loading branch information...
ogizanagi committed Aug 2, 2017
2 parents b98a4a3 + 81396c7 commit 584b7b44df62819538e42dada5f9cf4056aa459b
Showing with 2 additions and 3 deletions.
  1. +2 −3 src/Symfony/Component/Form/DependencyInjection/FormPass.php
@@ -16,7 +16,6 @@
use Symfony\Component\DependencyInjection\Compiler\ServiceLocatorTagPass;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
use Symfony\Component\DependencyInjection\Reference;
@@ -53,12 +52,12 @@ public function process(ContainerBuilder $container)
if (new IteratorArgument(array()) != $definition->getArgument(2)) {
return;
}
$definition->replaceArgument(0, $this->processFormTypes($container, $definition));
$definition->replaceArgument(0, $this->processFormTypes($container));
$definition->replaceArgument(1, $this->processFormTypeExtensions($container));
$definition->replaceArgument(2, $this->processFormTypeGuessers($container));
}
private function processFormTypes(ContainerBuilder $container, Definition $definition)
private function processFormTypes(ContainerBuilder $container)
{
// Get service locator argument
$servicesMap = array();

0 comments on commit 584b7b4

Please sign in to comment.