Skip to content
Permalink
Browse files

minor #30296 [VarDumper] link paths in stack traces to IDE (nicolas-g…

…rekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[VarDumper] link paths in stack traces to IDE

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | not really
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

`./test.php:8` and `./test.php:11` can now be clicked:

![image](https://user-images.githubusercontent.com/243674/52971041-466b1c80-33b6-11e9-9bc1-0e55dc115f63.png)

Commits
-------

6672ac3 [VarDumper] link paths in stack traces to IDE
  • Loading branch information...
nicolas-grekas committed Feb 19, 2019
2 parents e7430f4 + 6672ac3 commit 5909a4766478e82c6c7abe0ee7a0e8977194f86a
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php
@@ -236,7 +236,7 @@ public static function castFrameStub(FrameStub $frame, array $a, Stub $stub, $is
$ellipsis += 1 + \strlen($f['line']);
}
}
$srcAttr .= '&separator= ';
$srcAttr .= sprintf('&separator= &file=%s&line=%d', rawurlencode($f['file']), $f['line']);
} else {
$srcAttr .= '&separator=:';
}

0 comments on commit 5909a47

Please sign in to comment.
You can’t perform that action at this time.