Permalink
Browse files

[Translation] [Loader] Add INI_SCANNER_RAW to parse ini files

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | 
| License       | MIT
| Doc PR        | 

INI_SCANNER_RAW change the default scanner mode of parse_ini_files to parse all values without evaluate. This allow values with single quotes, "no" and "false" and raise an error if you use the deprecated "#" as comment character.
This change is specially good for shared translations, because a translator haven't to know that he can't use a few restricted terms.
And has a residual improvement: it's twice fast that use the default value (INI_SCANNER_NORMAL) in my tests
  • Loading branch information...
TeLiXj committed Jan 29, 2014
1 parent d61f492 commit 5ef60f14945f31e2805ed3fede5c775b54d2e758
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/Symfony/Component/Translation/Loader/IniFileLoader.php
@@ -35,7 +35,7 @@ public function load($resource, $locale, $domain = 'messages')
throw new NotFoundResourceException(sprintf('File "%s" not found.', $resource));
}
- $messages = parse_ini_file($resource, true);
+ $messages = parse_ini_file($resource, true, INI_SCANNER_RAW);
$catalogue = parent::load($messages, $locale, $domain);
$catalogue->addResource(new FileResource($resource));

0 comments on commit 5ef60f1

Please sign in to comment.