Skip to content
Permalink
Browse files

bug #22768 Use 0.0.0.0 as the server log command host default. (ChadS…

…ikorra)

This PR was merged into the 3.3 branch.

Discussion
----------

Use 0.0.0.0 as the server log command host default.

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | -
| Fixed tickets | -
| License       | MIT

This fixes the `server:log` command on Windows when run with default settings. The current setting `0` has no meaning on Windows, and `0.0.0.0` is the standard "listen on all addresses/interfaces", so should be the most compatible. It works on both Linux and Windows for me this way.

I mentioned this in another PR where the logger config has the same issue on Windows:

symfony/symfony-standard#1077

Commits
-------

3fcc810 Use 0.0.0.0 as the server log host default.
  • Loading branch information...
fabpot committed May 19, 2017
2 parents 7938fde + 3fcc810 commit 649ad8cf5540709dae5616825e3328e1c9cb2b43
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php
@@ -47,7 +47,7 @@ protected function configure()
}
$this
->addOption('host', null, InputOption::VALUE_REQUIRED, 'The server host', '0:9911')
->addOption('host', null, InputOption::VALUE_REQUIRED, 'The server host', '0.0.0.0:9911')
->addOption('format', null, InputOption::VALUE_REQUIRED, 'The line format', ConsoleFormatter::SIMPLE_FORMAT)
->addOption('date-format', null, InputOption::VALUE_REQUIRED, 'The date format', ConsoleFormatter::SIMPLE_DATE)
->addOption('filter', null, InputOption::VALUE_REQUIRED, 'An expression to filter log. Example: "level > 200 or channel in [\'app\', \'doctrine\']"')

0 comments on commit 649ad8c

Please sign in to comment.
You can’t perform that action at this time.