Skip to content
Permalink
Browse files

minor #32399 [Messenger] Don't pass objects as class name to Containe…

…rBuilder::register (derrabus)

This PR was merged into the 4.2 branch.

Discussion
----------

[Messenger] Don't pass objects as class name to ContainerBuilder::register

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Fixed a broken test that was discovered while working on #32390.

Commits
-------

e110603 Don't pass objects as class name to ContainerBuilder::register.
  • Loading branch information...
Tobion committed Jul 5, 2019
2 parents 44e8252 + e110603 commit 8e07e7773f116d5014d5ab1f3cef76b04a345346
@@ -448,10 +448,8 @@ public function testNeedsToHandleAtLeastOneMessage()
public function testRegistersTraceableBusesToCollector()
{
$dataCollector = $this->getMockBuilder(MessengerDataCollector::class)->getMock();
$container = $this->getContainerBuilder($fooBusId = 'messenger.bus.foo');
$container->register('data_collector.messenger', $dataCollector);
$container->register('data_collector.messenger', MessengerDataCollector::class);
$container->setParameter('kernel.debug', true);
(new MessengerPass())->process($container);

0 comments on commit 8e07e77

Please sign in to comment.
You can’t perform that action at this time.