Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
bug #39746 [DependencyInjection] Fix InvalidParameterTypeException fo…
…r function parameters (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Fix InvalidParameterTypeException for function parameters

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39737
| License       | MIT
| Doc PR        | N/A

Commits
-------

1854543 [DependencyInjection] Fix InvalidParameterTypeException for function parameters
  • Loading branch information
nicolas-grekas committed Jan 7, 2021
2 parents 92ccb0a + 1854543 commit a147705
Show file tree
Hide file tree
Showing 2 changed files with 58 additions and 1 deletion.
Expand Up @@ -25,6 +25,11 @@ public function __construct(string $serviceId, string $type, \ReflectionParamete
$acceptedType = $acceptedType instanceof \ReflectionNamedType ? $acceptedType->getName() : (string) $acceptedType;
$this->code = $type;

parent::__construct(sprintf('Invalid definition for service "%s": argument %d of "%s::%s()" accepts "%s", "%s" passed.', $serviceId, 1 + $parameter->getPosition(), $parameter->getDeclaringClass()->getName(), $parameter->getDeclaringFunction()->getName(), $acceptedType, $type));
$function = $parameter->getDeclaringFunction();
$functionName = $function instanceof \ReflectionMethod
? sprintf('%s::%s', $function->getDeclaringClass()->getName(), $function->getName())
: $function->getName();

parent::__construct(sprintf('Invalid definition for service "%s": argument %d of "%s()" accepts "%s", "%s" passed.', $serviceId, 1 + $parameter->getPosition(), $functionName, $acceptedType, $type));
}
}
@@ -0,0 +1,52 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\DependencyInjection\Tests\Exception;

use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\Exception\InvalidParameterTypeException;

final class InvalidParameterTypeExceptionTest extends TestCase
{
/**
* @dataProvider provideReflectionParameters
*/
public function testExceptionMessage(\ReflectionParameter $parameter, string $expectedMessage)
{
$exception = new InvalidParameterTypeException('my_service', 'int', $parameter);

self::assertSame($expectedMessage, $exception->getMessage());
}

public function provideReflectionParameters(): iterable
{
yield 'static method' => [
new \ReflectionParameter([MyClass::class, 'doSomething'], 0),
'Invalid definition for service "my_service": argument 1 of "Symfony\Component\DependencyInjection\Tests\Exception\MyClass::doSomething()" accepts "array", "int" passed.',
];

yield 'function' => [
new \ReflectionParameter(__NAMESPACE__.'\\myFunction', 0),
'Invalid definition for service "my_service": argument 1 of "Symfony\Component\DependencyInjection\Tests\Exception\myFunction()" accepts "array", "int" passed.',
];
}
}

class MyClass
{
public static function doSomething(array $arguments): void
{
}
}

function myFunction(array $arguments): void
{
}

0 comments on commit a147705

Please sign in to comment.