Please sign in to comment.
bug #30084 Fix KernelTestCase compatibility for PhpUnit 8 (alexander-…
…schranz) This PR was merged into the 3.4 branch. Discussion ---------- Fix KernelTestCase compatibility for PhpUnit 8 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? |no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30071 | License | MIT | Doc PR | As the PhpUnit 8 Testcase has different return types as PhpUnit 7 there need to be 2 different classes to support both PhpUnit 8 and PhpUnit 7. With a class alias we can then change which version is used based on the PhpUnit Version constant. The fix is a little bit hacky but to support different major versions I see no other way. Not sure as we can't upgrade symfony/symfony to PhpUnit 8 how we can create a TestCase for this change. Commits ------- 83a56a0 Fix phpunit 8 compatibility
- Loading branch information...
Showing with 2 additions and 8 deletions.