Permalink
Browse files

fixes a bug in the SwitchUserListener

  • Loading branch information...
schmittjoh authored and fabpot committed Apr 19, 2011
1 parent 2014ff6 commit c660fcd2f2310649eabe94a14d28ce14a1a8b760
Showing with 8 additions and 1 deletion.
  1. +4 −0 UPDATE.md
  2. +4 −1 src/Symfony/Component/Security/Http/Firewall/SwitchUserListener.php
@@ -26,6 +26,10 @@ PR11 to PR12
<app:engine>twig</app:engine>
<twig:extension>twig.extension.debug</twig:extension>
* Fixes a critical security issue which allowed all users to switch to
arbitrary accounts when the SwitchUserListener was activated. Configurations
which do not use the SwitchUserListener are not affected.
PR10 to PR11
------------
@@ -11,6 +11,7 @@
namespace Symfony\Component\Security\Http\Firewall;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Symfony\Component\Security\Core\SecurityContextInterface;
use Symfony\Component\Security\Core\User\UserProviderInterface;
use Symfony\Component\Security\Core\User\UserCheckerInterface;
@@ -112,7 +113,9 @@ private function attemptSwitchUser(Request $request)
throw new \LogicException(sprintf('You are already switched to "%s" user.', $token->getUsername()));
}
$this->accessDecisionManager->decide($token, array($this->role));
if (false === $this->accessDecisionManager->decide($token, array($this->role))) {
throw new AccessDeniedException();
}
$username = $request->get($this->usernameParameter);

0 comments on commit c660fcd

Please sign in to comment.