Skip to content
Permalink
Browse files

bug #28664 [Console] Don't return early as this bypasses the auto exi…

…t feature (duncan3dc)

This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Don't return early as this bypasses the auto exit feature

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets |
| License       | MIT

It looks like 8805cfd broke the auto exit feature by returning early.

I couldn't find any tests for this feature (presumably because it uses `exit()`), I was going to write one using uopz but didn't want to do this work if Symfony intentionally doesn't test the call to `exit()`

Commits
-------

b6c17df Don't return early as this bypasses the auto exit feature
  • Loading branch information...
chalasr committed Oct 1, 2018
2 parents 00efcd4 + b6c17df commit caf37ca3753652d2fa2320c9baef1bd0cb60fcb6
Showing with 0 additions and 2 deletions.
  1. +0 −2 src/Symfony/Component/Console/Application.php
@@ -162,8 +162,6 @@ public function run(InputInterface $input = null, OutputInterface $output = null
} else {
$exitCode = 1;
}
return $exitCode;
} finally {
// if the exception handler changed, keep it
// otherwise, unregister $renderException

0 comments on commit caf37ca

Please sign in to comment.
You can’t perform that action at this time.