bug #24105 [Filesystem] check permissions if dump target dir is missi…

…ng (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[Filesystem] check permissions if dump target dir is missing

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24097
| License       | MIT
| Doc PR        |

`is_dir()` returns `false` if the parent directory misses the executable
bit even when the directory itself is present.

Commits
-------

a0f9f2c check permissions if dump target dir is missing

src/Symfony/Component/Filesystem/Filesystem.php

@@ -532,6 +532,16 @@ public function dumpFile($filename, $content, $mode = 0666)
         $dir = dirname($filename);
 
         if (!is_dir($dir)) {
+            $oldCwd = getcwd();
+
+            if (!@chdir(dirname($dir))) {
+                // When the parent directory misses the executable permission bit, we are unable to enter it and thus
+                // cannot check if the target directory exists.
+                throw new IOException(sprintf('Unable to detect if the target directory "%s" exists.', $dir));
+            }
+
+            chdir($oldCwd);
+
             $this->mkdir($dir);
         }
 

src/Symfony/Component/Filesystem/Tests/FilesystemTest.php

@@ -1102,6 +1102,22 @@ public function testDumpKeepsExistingPermissionsWhenOverwritingAnExistingFile()
         $this->assertFilePermissions(745, $filename);
     }
 
+    /**
+     * @expectedException \Symfony\Component\Filesystem\Exception\IOException
+     * @expectedExceptionMessageRegExp /^Unable to detect if the target directory ".*" exists\.$/
+     */
+    public function testDumpFailsWithExceptionIfExecutablePermissionsForTheParentDirectoryAreMissing()
+    {
+        $this->markAsSkippedIfChmodIsMissing();
+
+        $target = $this->workspace.DIRECTORY_SEPARATOR.'foo';
+        $file = $target.DIRECTORY_SEPARATOR.'foobar';
+        mkdir($target);
+        chmod($this->workspace, 0666);
+
+        $this->filesystem->dumpFile($file, 'baz');
+    }
+
     public function testCopyShouldKeepExecutionPermission()
     {
         $this->markAsSkippedIfChmodIsMissing();

src/Symfony/Component/Filesystem/Tests/FilesystemTestCase.php

@@ -61,6 +61,7 @@ protected function tearDown()
             $this->longPathNamesWindows = array();
         }
 
+        chmod($this->workspace, 0777);
         $this->filesystem->remove($this->workspace);
         umask($this->umask);
     }