From 9e849eb78bcc668a2b8aad39cb47e2ad32c73a47 Mon Sep 17 00:00:00 2001 From: Albert Casademont Date: Mon, 15 Apr 2013 20:28:05 +0300 Subject: [PATCH] [Form] Remove "value" attribute on empty_value option Today we faced a very strange issue with the newest Blackberry 10 browser, it was not submitting our forms. Finally we found that in a ```select``` element, if you have a disabled option, it can't have a value or the HTML5 validator will crash and not submit the form. Of course, setting the ```novalidate``` option for the whole form also solved the issue. Although I know this must be an issue with the WebKit version the BB10 has it can easily be solved in symfony with this change. In fact, it does make sense since we already have a disabled option with no value if the ```preferred_choices``` are not empty and a ```separator``` is set --- .../Twig/Resources/views/Form/form_div_layout.html.twig | 2 +- .../Resources/views/Form/choice_widget_collapsed.html.php | 2 +- src/Symfony/Component/Form/Tests/AbstractLayoutTest.php | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig b/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig index 3ab047c494ad..f91ec1423df1 100644 --- a/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig +++ b/src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig @@ -69,7 +69,7 @@ {% spaceless %}