Skip to content

Commit

Permalink
bug #29090 LoggingTranslator should implement Symfony\Contracts\Trans…
Browse files Browse the repository at this point in the history
…lation\TranslatorInterface (desmax)

This PR was merged into the 4.2-dev branch.

Discussion
----------

LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29089
| License       | MIT

While autowiring Translator using `Symfony\Contracts\Translation\TranslatorInterface` symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface.

Commits
-------

65f321f LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface
  • Loading branch information
nicolas-grekas committed Nov 6, 2018
2 parents f9198c2 + 65f321f commit ef3be0b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Symfony/Component/Translation/LoggingTranslator.php
Expand Up @@ -19,7 +19,7 @@
/**
* @author Abdellatif Ait boudad <a.aitboudad@gmail.com>
*/
class LoggingTranslator implements LegacyTranslatorInterface, TranslatorBagInterface
class LoggingTranslator implements TranslatorInterface, LegacyTranslatorInterface, TranslatorBagInterface
{
/**
* @var TranslatorInterface|TranslatorBagInterface
Expand Down

0 comments on commit ef3be0b

Please sign in to comment.