Please sign in to comment.
bug #33444 [HttpClient] improve handling of HTTP/2 PUSH, disable it b…
…y default (nicolas-grekas) This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] improve handling of HTTP/2 PUSH, disable it by default | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This follows discussions with @dunglas For the test cases, https://http2-push.io is down, let's use Akamai instead This PR now considers the proxy settings before accepting a pushed response. It also splits the responsibility of dealing with accepting pushed responses in method `acceptPushForRequest`. The logic in this method could also be delegated to a userland callback passed as an option. Let's wait for someone with an actual use case before adding the option. This PR also disables HTTP/2 PUSH by default because it is not stable: locally, with the latest curl version, enabling this on a server that pushes things fails with `Failure when receiving data from the peer`. This is not ready for prime time in either ext-curl or the underlying libcurl. You can still enable it explicitly by passing some positive number to the constructor. Commits ------- 019bce7 [HttpClient] improve handling of HTTP/2 PUSH
- Loading branch information...
Showing with 55 additions and 50 deletions.