Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
merged branch lsmith77/filesystem_forward_compat (PR #2956)
Commits ------- 6e98730 added forwards compatibility for the Filesystem component Discussion ---------- added forwards compatibility for the Filesystem component see #2949 and #2946 --------------------------------------------------------------------------- by willdurand at 2011/12/25 05:24:01 -0800 :+1: --------------------------------------------------------------------------- by ManuelAC at 2011/12/25 06:38:44 -0800 :+1: --------------------------------------------------------------------------- by NAYZO at 2011/12/25 07:45:55 -0800 :+1: --------------------------------------------------------------------------- by avalanche123 at 2011/12/25 09:52:59 -0800 I think extracting interface and committing it to both branches is preferable. --------------------------------------------------------------------------- by lsmith77 at 2011/12/25 12:17:59 -0800 what interface? --------------------------------------------------------------------------- by avalanche123 at 2011/12/25 12:19:03 -0800 FilesystemInterface --------------------------------------------------------------------------- by lsmith77 at 2011/12/25 12:22:31 -0800 an interface doesn't really relate to this PR .. aka its a separate topic. the purpose of this PR is to make it easier to write code targeting with 2.0 and 2.1 with minimal impact. --------------------------------------------------------------------------- by willdurand at 2011/12/25 12:23:51 -0800 Seems overkill to add an interface here. I dont think there are different implementations. Le 25 déc. 2011 à 21:19, Bulat Shakirzyanov<reply@reply.github.com> a écrit : > FilesystemInterface > > --- > Reply to this email directly or view it on GitHub: > #2956 (comment) --------------------------------------------------------------------------- by avalanche123 at 2011/12/25 12:28:49 -0800 @lsmith77 point taken, makes sense @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.) --------------------------------------------------------------------------- by willdurand at 2011/12/25 12:52:58 -0800 Gaufrette (KnpLabs) is suitable for what you describe. I don't know if this component is designed to handle various adapters. This is just a layer for files manipulations on disk. Le 25 déc. 2011 à 21:28, Bulat Shakirzyanov<reply@reply.github.com> a écrit : > @lsmith77 point taken, makes sense > @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.) > > --- > Reply to this email directly or view it on GitHub: > #2956 (comment)
- Loading branch information