Please sign in to comment.
bug #30058 [Routing] fix perf issue when dumping large number of rout…
…es (nicolas-grekas) This PR was merged into the 4.2 branch. Discussion ---------- [Routing] fix perf issue when dumping large number of routes | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29918 | License | MIT | Doc PR | - In my reproducer, dumping 12k routes goes from 40s to 3s without xdebug, and from 50s to 12s with xdebug. There is a lower level issue which is that `strpos` is called 16M times, but that's still a lot faster than calling `preg_match` 16M times. Reducing the number of checks is certainly possible, but that would be more involving. This could happen on master if someone is up to dig into it. Commits ------- 872efe5 [Routing] fix perf issue when dumping large number of routes
- Loading branch information...
Showing with 5 additions and 4 deletions.