Skip to content
This repository

Apr 19, 2014

  1. Fabien Potencier

    feature #10725 [Debug] Handled errors (nicolas-grekas)

    This PR was squashed before being merged into the 2.5-dev branch (closes #10725).
    
    Discussion
    ----------
    
    [Debug] Handled errors
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | none
    
    Enhance error handling and thus displaying for catchable PHP errors.
    Code is tricky thanks to https://bugs.php.net/54275
    
    Before:
    
    ![capture du 2014-04-17 10 03 40](https://cloud.githubusercontent.com/assets/243674/2729324/4de3eedc-c607-11e3-8b23-c88657bbecd0.png)
    
    After:
    
    ![capture du 2014-04-17 10 03 14](https://cloud.githubusercontent.com/assets/243674/2729326/534ec504-c607-11e3-82dd-49b7770b1e75.png)
    
    Commits
    -------
    
    0279fbf [Debug] Handled errors
    authored April 19, 2014
  2. Nicolas Grekas

    [Debug] Handled errors

    authored April 17, 2014 fabpot committed April 19, 2014

Apr 18, 2014

  1. Fabien Potencier

    Merge branch '2.4'

    * 2.4:
      Little correction for case 'ar'
      No need to use mb functions here
      Fix doc-blocks
      Fix doc blocks
      [HttpFoundation] update phpdoc of SessionHandlerInterface and unify parameters of all handlers according to interface
      [Doctrine Bridge] fix DbalSessionHandler for high concurrency, interface compliance, compatibility with all drivers (oci8, mysqli, pdo with mysql, sqlsrv, sqlite)
      [Finder] Marked test skipped when ftp stream wrapper is not available
    
    Conflicts:
    	src/Symfony/Component/Security/Core/Authorization/Voter/ExpressionVoter.php
    authored April 18, 2014
  2. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      Little correction for case 'ar'
      No need to use mb functions here
      [HttpFoundation] update phpdoc of SessionHandlerInterface and unify parameters of all handlers according to interface
      [Doctrine Bridge] fix DbalSessionHandler for high concurrency, interface compliance, compatibility with all drivers (oci8, mysqli, pdo with mysql, sqlsrv, sqlite)
      [Finder] Marked test skipped when ftp stream wrapper is not available
    authored April 18, 2014
  3. Fabien Potencier

    bug #10735 [Translation] [PluralizationRules] Little correction for c…

    …ase 'ar' (klyk50)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10735).
    
    Discussion
    ----------
    
    [Translation] [PluralizationRules] Little correction for case 'ar'
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    ef85f4c Little correction for case 'ar'
    authored April 18, 2014
  4. klyk50

    Little correction for case 'ar'

    authored April 17, 2014 fabpot committed April 18, 2014
  5. Fabien Potencier

    minor #10740 [2.5] Fix doc blocks (romainneutron)

    This PR was merged into the 2.5-dev branch.
    
    Discussion
    ----------
    
    [2.5] Fix doc blocks
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    
    Last one on this topic, in master branch. This follows #10738 and #10737
    
    Commits
    -------
    
    90294ec Fix doc blocks
    authored April 18, 2014
  6. Fabien Potencier

    minor #10719 [Finder] Marked test skipped when ftp stream wrapper is …

    …not available (deguif)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Finder] Marked test skipped when ftp stream wrapper is not available
    
    | Q               | A
    | ---------------- | ---
    | Bug fix?         | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    This should prevent test from failing on hhvm as ftp stream wrapper is not currently implemented.
    See facebook/hhvm#2108 for more details.
    
    Commits
    -------
    
    f35fc81 [Finder] Marked test skipped when ftp stream wrapper is not available
    authored April 18, 2014
  7. Fabien Potencier

    bug #10720 [HttpFoundation] Fix DbalSessionHandler (Tobion)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Fix DbalSessionHandler
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    
    This is basically the same as #10652 for the DbalSessionHandler.
    
    - First commit fixes fix DbalSessionHandler for high concurrency, interface compliance, compatibility with all drivers (oci8, mysqli, pdo with mysql, sqlsrv, sqlite).
    - Second commit updates phpdoc of SessionHandlerInterface and unifies parameters of all handlers according to interface (so inheritdoc actually makes sense).
    
    Commits
    -------
    
    524bf84 [HttpFoundation] update phpdoc of SessionHandlerInterface and unify parameters of all handlers according to interface
    ccdfbe6 [Doctrine Bridge] fix DbalSessionHandler for high concurrency, interface compliance, compatibility with all drivers (oci8, mysqli, pdo with mysql, sqlsrv, sqlite)
    authored April 18, 2014
  8. Romain Neutron

    Fix doc blocks

    authored April 18, 2014
  9. Fabien Potencier

    minor #10739 [2.4] Fix doc-blocks (romainneutron)

    This PR was merged into the 2.4 branch.
    
    Discussion
    ----------
    
    [2.4] Fix doc-blocks
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    
    last one has been merged too quickly
    
    Commits
    -------
    
    7fab25e Fix doc-blocks
    authored April 18, 2014
  10. Fabien Potencier

    minor #10730 No need to use mb functions here (mvrhov)

    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10730).
    
    Discussion
    ----------
    
    No need to use mb functions here
    
    When mb functions are used and a large response is given the OOM happens as mb functions will use large quantities of memory.
    
    In my example the response is approximately 27M in size and a php has a memory consumption of about 150M... When mb functions are used the memory shoots over 250M
    
    Commits
    -------
    
    4e8ba13 No need to use mb functions here
    authored April 18, 2014
  11. Miha Vrhovnik

    No need to use mb functions here

    When mb functions are used and a large response is given the OOM happens as mb functions will use large quantities of memory.
    authored April 17, 2014 fabpot committed April 18, 2014
  12. Romain Neutron

    Fix doc-blocks

    authored April 18, 2014
  13. Fabien Potencier

    minor #10738 [2.4] Fix doc blocks (romainneutron)

    This PR was merged into the 2.4 branch.
    
    Discussion
    ----------
    
    [2.4] Fix doc blocks
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    
    this follows #10737
    
    Commits
    -------
    
    c01915d Fix doc blocks
    authored April 18, 2014
  14. Fabien Potencier

    unified return null usages

    authored April 18, 2014
  15. Fabien Potencier

    Merge branch '2.4'

    * 2.4:
      unified return null usages
      [Validator] added Japanese translation
      Textarea value should default to empty string instead of null.
      Fix doc blocks
      [Process] Fix #10681, process are failing on Windows Server 2003
      updated doc
      [Security] fix DBAL connection typehint
      [HttpFoundation] status 201 is allowed to have a body
      unified return null usages
    
    Conflicts:
    	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
    	src/Symfony/Component/DomCrawler/Crawler.php
    	src/Symfony/Component/Security/Core/Authentication/Provider/PreAuthenticatedAuthenticationProvider.php
    authored April 18, 2014
  16. Fabien Potencier

    unified return null usages

    authored April 18, 2014
  17. Romain Neutron

    Fix doc blocks

    authored April 18, 2014
  18. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      Textarea value should default to empty string instead of null.
      Fix doc blocks
      [Process] Fix #10681, process are failing on Windows Server 2003
      [Security] fix DBAL connection typehint
      [HttpFoundation] status 201 is allowed to have a body
      unified return null usages
    
    Conflicts:
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
    	src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
    	src/Symfony/Component/HttpKernel/Fragment/InlineFragmentRenderer.php
    authored April 18, 2014
  19. Fabien Potencier

    minor #10717 unified return null usages (fabpot)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    unified return null usages
    
    | Q             | A
    | ------------- | ---
    | License       | MIT
    
    This PR unifies the way we return `null` from a function or method:
    
     * always use `return;` instead of `return null;` (the current code base uses both);
     * never use `return;` at the end of a function/method.
    
    Commits
    -------
    
    d1d569b unified return null usages
    authored April 18, 2014
  20. Fabien Potencier

    minor #10726 [HttpFoundation] factorize out the way output buffers sh…

    …ould be closed (nicolas-grekas)
    
    This PR was merged into the 2.5-dev branch.
    
    Discussion
    ----------
    
    [HttpFoundation] factorize out the way output buffers should be closed
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | none
    
    Closing output buffers was done in three different files, but not exactly the same way, with subtle differences.
    This PR factorizes out the best way to do this in a new public static function of the Response class.
    
    Commits
    -------
    
    469943c [HttpFoundation] factorize out the way output buffers should be closed
    authored April 18, 2014
  21. Fabien Potencier

    bug #10721 [HttpFoundation] status 201 is allowed to have a body (Tob…

    …ion)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] status 201 is allowed to have a body
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | only if someone relied on wrong behavior
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #10673
    | License       | MIT
    
    Status 201 is allowed to have a response body.
    
    Commits
    -------
    
    1761f64 [HttpFoundation] status 201 is allowed to have a body
    authored April 18, 2014
  22. Fabien Potencier

    bug #10728 [2.3][Process] Fix #10681, process are failing on Windows …

    …Server 2003 (romainneutron)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3][Process] Fix #10681, process are failing on Windows Server 2003
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #10681
    | License       | MIT
    
    Commits
    -------
    
    46fdfbb [Process] Fix #10681, process are failing on Windows Server 2003
    authored April 18, 2014
  23. Fabien Potencier

    minor #10732 [Validator] added Japanese translation (issei-m)

    This PR was submitted for the master branch but it was merged into the 2.4 branch instead (closes #10732).
    
    Discussion
    ----------
    
    [Validator] added Japanese translation
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    7b91e03 [Validator] added Japanese translation
    authored April 18, 2014
  24. Issei Murasawa

    [Validator] added Japanese translation

    authored April 17, 2014 fabpot committed April 18, 2014
  25. Fabien Potencier

    minor #10737 [2.3] Fix doc blocks (romainneutron)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3] Fix doc blocks
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    
    Commits
    -------
    
    de5d627 Fix doc blocks
    authored April 18, 2014
  26. Fabien Potencier

    bug #10733 [DomCrawler] Textarea value should default to empty string…

    … instead of null. (Berdir)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10733).
    
    Discussion
    ----------
    
    [DomCrawler] Textarea value should default to empty string instead of null.
    
    Noticed this when working on Updating Behat/Mink/Goutte to Guzzle 4, see fabpot/Goutte#140 and Behat/MinkGoutteDriver#34.
    
    Testing this with Drupal 8, trying to submit a Form which has empty form elements, the $value in a TextArea form elements defaults to null, then we end up with those in getValues() and then http_build_query() creates an empty string for those. That results in array keys like ['' => false]. This is then passed through to Guzzle, which ends up in MessageFactory::addPostData(), goes into the else creates and tries to create file with those values, which will throw an exception in GuzzleHttp\Stream::create(): with "Invalid resource type false".
    
    I think the correct fix is to default to an empty string instead of null.
    
    Will also need tests,
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    f672564 Textarea value should default to empty string instead of null.
    authored April 18, 2014
  27. Sascha Grossenbacher

    Textarea value should default to empty string instead of null.

    authored April 17, 2014 fabpot committed April 18, 2014
  28. Romain Neutron

    Fix doc blocks

    authored April 18, 2014
  29. Fabien Potencier

    fixed typo

    authored April 18, 2014
  30. Fabien Potencier

    minor #10736 Update PackageInterface.php (ibasaw)

    This PR was merged into the 2.5-dev branch.
    
    Discussion
    ----------
    
    Update PackageInterface.php
    
    found a typo
    
    Commits
    -------
    
    e043329 Update PackageInterface.php
    authored April 18, 2014
  31. ibasaw

    Update PackageInterface.php

    authored April 18, 2014

Apr 17, 2014

  1. Nicolas Grekas

    [HttpFoundation] factorize out the way output buffers should be closed

  2. Romain Neutron

    [Process] Fix #10681, process are failing on Windows Server 2003

    authored April 17, 2014
Something went wrong with that request. Please try again.