Skip to content
Commits on May 26, 2016
  1. @nicolas-grekas

    feature #18825 [Cache] Create NullAdapter to disable cache if needed …

    …(tgalopin)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Cache] Create NullAdapter to disable cache if needed
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | WIP
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Tthis PR aims to implement a Symfony Cache Null adapter able to disable cache if needed (very useful in tests or in the case of the fallback of the OpCacheAdapter for instance).
    
    This PR is required by #18823 and #18533
    
    Commits
    -------
    
    0519d22 [Cache] Create NullAdapter to disable cache if needed
    nicolas-grekas committed May 26, 2016
  2. @fabpot

    Merge branch '3.1'

    * 3.1:
      fixed PHP 5.3 compat in tests
    fabpot committed May 26, 2016
  3. @fabpot

    Merge branch '3.0' into 3.1

    * 3.0:
      fixed PHP 5.3 compat in tests
    fabpot committed May 26, 2016
  4. @fabpot

    Merge branch '2.8' into 3.0

    * 2.8:
      fixed PHP 5.3 compat in tests
    fabpot committed May 26, 2016
  5. @fabpot

    Merge branch '2.7' int pusto 2.8

    * 2.7:
      fixed PHP 5.3 compat in tests
    fabpot committed May 26, 2016
  6. @fabpot

    Merge branch '2.3' into 2.7

    * 2.3:
      fixed PHP 5.3 compat in tests
    fabpot committed May 26, 2016
  7. @fabpot

    fixed PHP 5.3 compat in tests

    fabpot committed May 26, 2016
  8. @fabpot

    Merge branch '3.1'

    * 3.1:
      [Console] SymfonyStyle: Align multi-line/very-long-line blocks
      [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
      Fix js comment in profiler
      [Ldap] Fixed issue with Entry password attribute containing array of values and made password attribute configurable
      [Serializer][#18837] adding a test
      [Cache] Drop counting hit/miss in ProxyAdapter
      [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called
      [Serializer] ObjectNormalizer: add missing parameters
    fabpot committed May 26, 2016
  9. @fabpot

    Merge branch '3.0' into 3.1

    * 3.0:
      [Console] SymfonyStyle: Align multi-line/very-long-line blocks
      [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
      Fix js comment in profiler
    fabpot committed May 26, 2016
  10. @fabpot

    Merge branch '2.8' into 3.0

    * 2.8:
      [Console] SymfonyStyle: Align multi-line/very-long-line blocks
      [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
      Fix js comment in profiler
    fabpot committed May 26, 2016
  11. @fabpot

    Merge branch '2.7' into 2.8

    * 2.7:
      [Console] SymfonyStyle: Align multi-line/very-long-line blocks
      [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
      Fix js comment in profiler
    fabpot committed May 26, 2016
  12. @fabpot

    Merge branch '2.3' into 2.7

    * 2.3:
      [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
    fabpot committed May 26, 2016
  13. @fabpot

    minor #18878 [Serializer][#18837] adding a test (xabbuh)

    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Serializer][#18837] adding a test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18837
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    37cacc4 [Serializer][#18837] adding a test
    fabpot committed May 26, 2016
  14. @fabpot

    bug #18879 [Console] SymfonyStyle: Align multi-line/very-long-line bl…

    …ocks (chalasr)
    
    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #18879).
    
    Discussion
    ----------
    
    [Console] SymfonyStyle: Align multi-line/very-long-line blocks
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18564
    | License       | MIT
    | Doc PR        | n/a
    
    This PR makes all lines aligned in multi-line blocks.
    
    Very-long-line block:
    ```php
    SymfonyStyle::warning('Lorem ipsum...');
    ```
    
    Before:
    ![before-1](http://image.prntscr.com/image/d8443d3a85924a0182a62bd6d3dc1086.png)
    After:
    ![after-1](http://image.prntscr.com/image/dbbdd275bff140bdad06de336f032ec1.png)
    
    Multi-line block:
    ```php
    SymfonyStyle::success(['Lorem ipsum...', 'Lorem ipsum...', 'Lorem ipsum...']);
    ```
    
    Before:
    ![before-2](http://image.prntscr.com/image/6d7c05b4ab3a42f0b0be652527aed7c8.png)
    After:
    ![after-2](http://image.prntscr.com/image/bba017309f4a4dd09e0147d5917cb0ae.png)
    
    Also @javiereguiluz pointed the case of `SymfonyStyle::comment()` in #18564, I needed to make it calling `SymfonyStyle::block()` with ` // ` as prefix to fit the first intention of this one.
    So if this one is merged I'll propose the changes for comments in a second PR (out of this scope).
    
    Commits
    -------
    
    963fe1d [Console] SymfonyStyle: Align multi-line/very-long-line blocks
    fabpot committed May 26, 2016
  15. @chalasr @fabpot

    [Console] SymfonyStyle: Align multi-line/very-long-line blocks

    Remove SymfonyStyle::comment() changes (out of scope)
    
    CS Fixes
    
    Add tests
    chalasr committed with fabpot May 22, 2016
  16. @fabpot

    bug #18881 [Security][Ldap] Fixed issue with password attribute conta…

    …ining an array of values. (csarrazi)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Security][Ldap] Fixed issue with password attribute containing an array of values.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18401
    | License       | MIT
    | Doc PR        |
    
    This PR fixes #18401, as well as other possible issues:
    * First, the user provider no longer requires a password attribute by default. While this is not mandatory, it is more explicit to not set a password when using the `form_login_ldap` or `http_basic_ldap`, as these two providers don't use a password comparison mechanism, but `ldap_bind()` instead.
    * Second, the attribute is now configurable. Some implementations actually use different properties to store the user's password attribute. This will enable some users to correctly work with specific configurations.
    * Third, the user provider normalises the attribute array into a single string. Also, if the attribute has more than one value (which should not be possible), or if is not set, an exception will be thrown, with a clear error message.
    
    Commits
    -------
    
    dbf45e4 [Ldap] Fixed issue with Entry password attribute containing array of values and made password attribute configurable
    fabpot committed May 26, 2016
  17. @fabpot

    bug #18864 [Console][DX] Fixed ambiguous error message when using a d…

    …uplicate option shortcut (peterrehm)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18864).
    
    Discussion
    ----------
    
    [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18856
    | License       | MIT
    | Doc PR        | -
    
    I assume this should be merged into 2.3 as per @stof's comment.
    
    There is a race condition when you run a command which has a duplicate option shortcut. Simply changing the order so that Options are merged before the Arguments solves that race condition.
    
    ````php
    $this->setName('my:super:command')
    ->setAliases(['my:super:commandalias'])
    ->setDescription('Performs some irrelevant work.')
    ->addOption('survey', 'e', InputOption::VALUE_REQUIRED, 'My option with a shortcut.')
    ````
    
    Gives the error message:
    
    ```
      [Symfony\Component\Console\Exception\LogicException]
      An argument with name "command" already exists.
    ```
    
    This happens as the first time the definition is merged happens here:
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L820
    
    As this throws an error here:
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L309
    
    The commans are merged but not the options.
    
    Merging it then again when the command is run
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L217
    
    throws an error due to the duplicate argument as the arguments already have been merged. This time the error message is not surpressed and will confuse the user.
    
    Changing the order should fix the issue for duplicate arguments as well as for duplicate options.
    
    Commits
    -------
    
    7cb7655 [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
    fabpot committed May 26, 2016
  18. @peterrehm @fabpot
  19. @fabpot

    bug #18883 Fix js comment in profiler (linnaea)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fix js comment in profiler
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Single line comment introduced in #18413 causes the toolbar to fail to load with a syntax error.
    
    Commits
    -------
    
    91a2f5d Fix js comment in profiler
    fabpot committed May 26, 2016
  20. @linnaea

    Fix js comment in profiler

    linnaea committed May 26, 2016
  21. @csarrazi

    [Ldap] Fixed issue with Entry password attribute containing array of …

    …values and made password attribute configurable
    csarrazi committed May 26, 2016
Commits on May 25, 2016
  1. @xabbuh
  2. @fabpot

    feature #18867 [Cache] Drop counting hit/miss in ProxyAdapter (nicola…

    …s-grekas)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Cache] Drop counting hit/miss in ProxyAdapter
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    We have no use case for these methods yet. Let's drop them and save some BC constraints.
    
    Commits
    -------
    
    9461750 [Cache] Drop counting hit/miss in ProxyAdapter
    fabpot committed May 25, 2016
  3. @stof

    bug #18858 [Yaml] fix falsely triggered deprecation (xabbuh)

    This PR was merged into the 3.1-dev branch.
    
    Discussion
    ----------
    
    [Yaml] fix falsely triggered deprecation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | https://github.com/symfony/symfony/pull/18785/files#r64390640
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    89dd69a [Yaml] fix falsely triggered deprecation
    stof committed May 25, 2016
  4. @tgalopin
  5. @nicolas-grekas

    feature #18675 [VarDumper] Add Redis caster (nicolas-grekas)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [VarDumper] Add Redis caster
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Helps working on Redis connections
    
    Commits
    -------
    
    56ae8c8 [VarDumper] Add Redis caster
    nicolas-grekas committed May 25, 2016
  6. @nicolas-grekas
Commits on May 24, 2016
  1. @xabbuh
  2. @fabpot

    bug #18837 [Serializer] AbstractObjectNormalizer: be sure that isAllo…

    …wedAttribute is called (dunglas)
    
    This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes #18837).
    
    Discussion
    ----------
    
    [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Please merge before the release of 3.1 (potential bug fix)
    
    Commits
    -------
    
    29b4115 [Serializer] AbstractObjectNormalizer: be sure that isAllowedAttribute is called
    fabpot committed May 24, 2016
  3. @dunglas @fabpot
  4. @fabpot

    bug #18838 [Serializer] ObjectNormalizer: add missing parameters (dun…

    …glas)
    
    This PR was submitted for the master branch but it was merged into the 3.1 branch instead (closes #18838).
    
    Discussion
    ----------
    
    [Serializer] ObjectNormalizer: add missing parameters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Please merge before the release of 3.1 (potential bug fix)
    
    Commits
    -------
    
    58ac241 [Serializer] ObjectNormalizer: add missing parameters
    fabpot committed May 24, 2016
  5. @dunglas @fabpot
  6. @fabpot

    minor #18841 [Debug] More compact HTML (c960657)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Debug] More compact HTML
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    This patch makes the HTML output for exception stack traces slightly more compact. This makes the stack trace a bit more readable when inspecting the HTML source, e.g. when using cURL.
    
    1. Vendor-specific prefixes for border-radius are removed. They are not relevant [in any modern browser](http://caniuse.com/border-radius).
    2. The ondblclick is now added only once and relies on event bubbling rather than being added to every `<li>` in the stack trace.
    3. Single quotes are not escaped. Escaping single quotes is only required for values enclosed in single quoted HTML attributes - all our attributes are double-quoted.
    
    Commits
    -------
    
    9613b75 [Debug] More compact HTML
    fabpot committed May 24, 2016
  7. @fabpot

    Merge branch '3.1'

    * 3.1: (24 commits)
      [Yaml] fix exception contexts
      Added people - person inflection
      People - person singularization
      [Yaml] properly handle unindented collections
      [Serializer] Add test for ignored attributes during denormalization
      chomp newlines only at the end of YAML documents
      Fixed server status command when port has been omitted
      Update UPGRADE FROM 2.x to 3.0
      [Config] Allow schemed path in FileResource
      fix removed commands wording in upgrade file
      Catch \Throwable
      Catch \Throwable
      [DependencyInjection] Avoid generating call_user_func in more cases
      [Validator] Support for DateTimeImmutable
      [YAML] fixed "dump" signature in upgrade file
      [Cache] Rename nonce to version
      [FrameworkBundle] update upgrade instructions
      Use levenshtein level for better Bundle matching
      [WebProfilerBundle] Fix CORS ajax security issues
      remove methods that were needed for PHP 5.3
      ...
    fabpot committed May 24, 2016
  8. @fabpot

    Merge branch '3.0' into 3.1

    * 3.0:
      [Yaml] fix exception contexts
      People - person singularization
      [Yaml] properly handle unindented collections
      [Serializer] Add test for ignored attributes during denormalization
      chomp newlines only at the end of YAML documents
      Fixed server status command when port has been omitted
      Update UPGRADE FROM 2.x to 3.0
      fix removed commands wording in upgrade file
      Catch \Throwable
      Catch \Throwable
      [DependencyInjection] Avoid generating call_user_func in more cases
      [Validator] Support for DateTimeImmutable
      [FrameworkBundle] update upgrade instructions
      Use levenshtein level for better Bundle matching
      [WebProfilerBundle] Fix CORS ajax security issues
      remove methods that were needed for PHP 5.3
      [DX][DI] Make Autowiring exceptions more future friendly
    fabpot committed May 24, 2016
Something went wrong with that request. Please try again.