Permalink
Commits on Aug 22, 2017
  1. Merge branch '3.4'

    * 3.4:
      [Webprofiler] Added blocks that allows extension of the profiler page.
      [Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues
      [Dotenv][WebServerBundle] Override previously loaded variables
      Create an interface for TranslationWriter
      [Translation] Adding the ability do dump <notes> in xliff2.0
      [DI] Use GlobResource for non-tracked directories
      [DI] Fix resolving env vars when compiling a ContainerBuilder
      [SecurityBundle] resolve class name parameter inside AddSecurityVotersPass
      [FrameworkBundle] Add soft conflict rule of "cache:clear" + HttpKernel 3.4
      [WebProfilerBundle] Re add missing link to the controller
    nicolas-grekas committed Aug 22, 2017
  2. Merge branch '3.3' into 3.4

    * 3.3:
      [Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues
      [Dotenv][WebServerBundle] Override previously loaded variables
      [DI] Use GlobResource for non-tracked directories
      [WebProfilerBundle] Re add missing link to the controller
    nicolas-grekas committed Aug 22, 2017
  3. bug #23949 [Dotenv] Get env using $_SERVER to work with fastcgi_param…

    … and workaround thread safety issues (nicolas-grekas)
    
    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    [Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #23502
    | License       | MIT
    | Doc PR        | -
    
    `getenv()` is not thread safe, and doesn't work with `fastcgi_param`, see links in linked issue.
    
    Commits
    -------
    
    f76e420 [Dotenv] Get env using $_SERVER to work with fastcgi_param and workaround thread safety issues
    fabpot committed Aug 22, 2017
  4. feature #23680 [Webprofiler] Added blocks that allows extension of th…

    …e profiler page. (Nyholm)
    
    This PR was squashed before being merged into the 3.4 branch (closes #23680).
    
    Discussion
    ----------
    
    [Webprofiler] Added blocks that allows extension of the profiler page.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 (to be retargeted)
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Im not sure if we allow this but I thought I would try to submit this PR.
    The [TranslationBundle](https://github.com/php-translation/symfony-bundle) is extending the Symfony profiler page for translation. It would be great if it didn't have to replace all the contents but just replace some smaller blocks.
    
    Commits
    -------
    
    ffd25fb [Webprofiler] Added blocks that allows extension of the profiler page.
    fabpot committed Aug 22, 2017
  5. [Dotenv] Get env using $_SERVER to work with fastcgi_param and workar…

    …ound thread safety issues
    nicolas-grekas committed Aug 22, 2017
  6. bug #23799 [Dotenv][WebServerBundle] Override previously loaded varia…

    …bles (voronkovich)
    
    This PR was squashed before being merged into the 3.3 branch (closes #23799).
    
    Discussion
    ----------
    
    [Dotenv][WebServerBundle] Override previously loaded variables
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #23723
    | License       | MIT
    
    This PR implements @nicolas-grekas's idea about how we could refresh loaded environment variables. See his comment #23723 (comment)
    
    Commits
    -------
    
    c5a1218 [Dotenv][WebServerBundle] Override previously loaded variables
    fabpot committed Aug 22, 2017
  7. bug #23676 [WebProfilerBundle] Re add missing link to the controller …

    …(lyrixx)
    
    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] Re add missing link to the controller
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes (because it was on 3.2 but not in 3.3)
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    ---
    
    ![screenshot at 2017-07-26 10-54-16](https://user-images.githubusercontent.com/408368/28612883-ea88f398-71f0-11e7-8361-a8e95036cf07.png)
    
    Commits
    -------
    
    1d10857 [WebProfilerBundle] Re add missing link to the controller
    fabpot committed Aug 22, 2017
  8. feature #23665 Create an interface for TranslationWriter (Nyholm)

    This PR was squashed before being merged into the 3.4 branch (closes #23665).
    
    Discussion
    ----------
    
    Create an interface for TranslationWriter
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | ~~~no~~~ yes
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    We should provide an interface for the TranslationWriter. This allows other libraries (php-translation) that depend on the Translation component provide different implementations.
    
    Commits
    -------
    
    c25eafa Create an interface for TranslationWriter
    nicolas-grekas committed Aug 22, 2017
  9. minor #23797 Don't force lowercase for hasher values (javiereguiluz)

    This PR was merged into the 4.0-dev branch.
    
    Discussion
    ----------
    
    Don't force lowercase for hasher values
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    In Symfony 4.x we no longer modify the service ids to lowercase them, so this PR tweaks the hasher introduced in #23766.
    
    Commits
    -------
    
    156cb70 [DI] Don't force lowercase for hasher values
    nicolas-grekas committed Aug 22, 2017
  10. [DI] Don't force lowercase for hasher values

    javiereguiluz committed with nicolas-grekas Aug 5, 2017
  11. bug #23870 [DI] Use GlobResource for non-tracked directories (vudaltsov)

    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    [DI] Use GlobResource for non-tracked directories
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    I noticed that some of my excluded directories are still tracked by the container and changes to files inside them make it recompile. This brought me to the `$trackContents || is_dir($path)` line introduced in #21505.
    
    Commits
    -------
    
    048eb18 [DI] Use GlobResource for non-tracked directories
    nicolas-grekas committed Aug 22, 2017
  12. feature #23890 [Translation] Adding the ability do dump <notes> in xl…

    …iff2.0 (Nyholm)
    
    This PR was squashed before being merged into the 3.4 branch (closes #23890).
    
    Discussion
    ----------
    
    [Translation] Adding the ability do dump <notes> in xliff2.0
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        | n/a
    
    The Xliff2.0 dumper do not dump notes. The note section is the only place (as far as I can see) you can add arbitrary data. See [specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html).
    
    This will be useful when you want to add data like "approved", "status" etc. I can see from the test code that a previous author intends to use attributes to the <target> for such data. That is [not allowed](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#target), not even with a custom namespace.
    
    If you want to validate my test fixture, here is the validator: http://okapi-lynx.appspot.com/validation
    
    Commits
    -------
    
    c4dd11c [Translation] Adding the ability do dump <notes> in xliff2.0
    nicolas-grekas committed Aug 22, 2017
  13. [DI] Use GlobResource for non-tracked directories

    vudaltsov committed with nicolas-grekas Aug 11, 2017
Commits on Aug 21, 2017
  1. Merge branch '3.3' into 3.4

    * 3.3:
      [DI] Fix resolving env vars when compiling a ContainerBuilder
    nicolas-grekas committed Aug 21, 2017
  2. bug #23940 [DI] Fix resolving env vars when compiling a ContainerBuil…

    …der (nicolas-grekas)
    
    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    [DI] Fix resolving env vars when compiling a ContainerBuilder
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    As spotted by @ro0NL, `$container->compile(true)` doesn't resolve direct env var references found in service definitions. Fixed here.
    
    Commits
    -------
    
    9219594 [DI] Fix resolving env vars when compiling a ContainerBuilder
    nicolas-grekas committed Aug 21, 2017
  3. [DI] Fix resolving env vars when compiling a ContainerBuilder

    nicolas-grekas committed Aug 18, 2017
  4. feature #23862 [SecurityBundle] resolve class name parameter inside A…

    …ddSecurityVotersPass (pjarmalavicius)
    
    This PR was squashed before being merged into the 3.4 branch (closes #23862).
    
    Discussion
    ----------
    
    [SecurityBundle] resolve class name parameter inside AddSecurityVotersPass
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #23733
    | License       | MIT
    
    Commits
    -------
    
    a86bf52 [SecurityBundle] resolve class name parameter inside AddSecurityVotersPass
    chalasr committed Aug 21, 2017
  5. Merge branch '3.3' into 3.4

    * 3.3:
      [FrameworkBundle] Add soft conflict rule of "cache:clear" + HttpKernel 3.4
    nicolas-grekas committed Aug 21, 2017
  6. minor #23933 [FrameworkBundle] Add soft conflict rule of "cache:clear…

    …" + HttpKernel 3.4 (nicolas-grekas)
    
    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Add soft conflict rule of "cache:clear" + HttpKernel 3.4
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Current tests on branch 3.3 fail because the "cache:clear" command relies on internal details that did change in HttpKernel 3.4.
    I propose to add this soft conflict logic to warn users about it.
    I prefer doing so than adding a real conflict in composer.json because that would prevent us from testing other features across versions.
    
    Commits
    -------
    
    ec8f56a [FrameworkBundle] Add soft conflict rule of "cache:clear" + HttpKernel 3.4
    nicolas-grekas committed Aug 21, 2017
Commits on Aug 18, 2017
  1. [FrameworkBundle] Add soft conflict rule of "cache:clear" + HttpKerne…

    …l 3.4
    nicolas-grekas committed Aug 18, 2017
  2. Merge branch '3.4'

    * 3.4:
      [HttpKernel][FrameworkBundle] Add RebootableInterface, fix and un-deprecate cache:clear with warmup
      [DI] Fix merging of env vars in configs
      Allow to get alternatives when ServiceNotFoundException occurs.
      [DI] Rererence parameter arrays when possible
      Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"
    nicolas-grekas committed Aug 18, 2017
  3. [WebProfilerBundle] Re add missing link to the controller

    lyrixx committed Jul 26, 2017
  4. Merge branch '3.3' into 3.4

    * 3.3:
      [DI] Fix merging of env vars in configs
    nicolas-grekas committed Aug 18, 2017
  5. bug #23903 [DI] Fix merging of env vars in configs (nicolas-grekas)

    This PR was merged into the 3.3 branch.
    
    Discussion
    ----------
    
    [DI] Fix merging of env vars in configs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #22561, #23520
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    00b9273 [DI] Fix merging of env vars in configs
    nicolas-grekas committed Aug 18, 2017
  6. feature #23915 [DI] Allow get available services from service locator…

    … (Koc)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] Allow get available services from service locator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    <!--
    - Bug fixes must be submitted against the lowest branch where they apply
      (lowest branches are regularly merged to upper ones so they get the fixes too).
    - Features and deprecations must be submitted against the 3.4,
      legacy code removals go to the master branch.
    - Please fill in this template according to the PR you're about to submit.
    - Replace this comment by a description of what your PR is solving.
    -->
    
    Sometimes we are using service locators and throw context specific exceptions if service not found inside it. Would be nice inform user about available services in our custom exception, like:
    
    ```php
    try {
        return $this->transports->get($transport);
    } catch (NotFoundExceptionInterface $e) {
        $availableTransports = method_exists($e, 'getAlternatives') ? $e->getAlternatives() : [];
    
        throw TransportNotFoundException::create($transport, $availableTransports, $e);
    }
    ```
    
    Commits
    -------
    
    4993b1c Allow to get alternatives when ServiceNotFoundException occurs.
    fabpot committed Aug 18, 2017
  7. feature #23792 [HttpKernel][FrameworkBundle] Add RebootableInterface,…

    … fix and un-deprecate cache:clear with warmup (nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [HttpKernel][FrameworkBundle] Add RebootableInterface, fix and un-deprecate cache:clear with warmup
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #23592, #8500
    | License       | MIT
    | Doc PR        | -
    
    This PR fixes the reasons why we deprecated cache:clear without --no-warmup.
    
    Internally, it requires some cooperation from the Kernel, so that a deprecation is needed.
    This allows the same kernel instance to be rebooted under a new cache directory, used during the warmup.
    It leverages the new capability to create two independent non colliding containers.
    
    Commits
    -------
    
    a4fc492 [HttpKernel][FrameworkBundle] Add RebootableInterface, fix and un-deprecate cache:clear with warmup
    fabpot committed Aug 18, 2017
  8. [HttpKernel][FrameworkBundle] Add RebootableInterface, fix and un-dep…

    …recate cache:clear with warmup
    nicolas-grekas committed Aug 4, 2017
  9. [DI] Fix merging of env vars in configs

    nicolas-grekas committed Aug 16, 2017
  10. Merge branch '3.3' into 3.4

    * 3.3:
      Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"
    nicolas-grekas committed Aug 18, 2017
  11. minor #23912 [DI] Rererence parameter arrays when possible (nicolas-g…

    …rekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] Rererence parameter arrays when possible
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no (perf optim)
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This a minor optim that might save memory and CPU for cases where big array parameters are inlined by DI extensions. This re-references them when possible.
    
    Commits
    -------
    
    62c1bb5 [DI] Rererence parameter arrays when possible
    fabpot committed Aug 18, 2017