Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 10, 2013
  1. Fabien Potencier

    updated VERSION for 2.0.25

    fabpot authored
  2. Fabien Potencier

    updated CHANGELOG for 2.0.25

    fabpot authored
  3. Fabien Potencier
Commits on Aug 7, 2013
  1. Fabien Potencier

    updated VERSION for 2.0.24

    fabpot authored
  2. Fabien Potencier

    updated CHANGELOG for 2.0.24

    fabpot authored
Commits on Aug 6, 2013
  1. Jean-François Simon Fabien Potencier

    added trusted hosts check

    jfsimon authored fabpot committed
  2. Bernhard Schussek Fabien Potencier

    Fixed metadata serialization

    webmozart authored fabpot committed
Commits on Mar 20, 2013
  1. Fabien Potencier

    updated VERSION for 2.0.23

    fabpot authored
  2. Fabien Potencier

    update CONTRIBUTORS for 2.0.23

    fabpot authored
  3. Fabien Potencier

    updated CHANGELOG for 2.0.23

    fabpot authored
Commits on Feb 27, 2013
  1. Fabien Potencier

    merged branch DenisGorbachev/2.0 (PR #7198)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    3be3dde [Console] Fixed comment
    
    Discussion
    ----------
    
    [Console] Fixed comment
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
  2. Denis Gorbachev

    [Console] Fixed comment

    DenisGorbachev authored
Commits on Feb 21, 2013
  1. Fabien Potencier

    merged branch bschussek/issue6862 (PR #7150)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    f8812b2 [Form] Fixed "label" option to accept the value "0"
    
    Discussion
    ----------
    
    [Form] Fixed "label" option to accept the value "0"
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6862
    | License       | MIT
    | Doc PR        | -
    
    @fabpot: This commit will cause troubles when merging 2.0 into 2.1 and up. Tell me if you need help upon conflict resolution.
  2. Bernhard Schussek
Commits on Feb 19, 2013
  1. Fabien Potencier

    merged branch cloppy/Dom-Crawler-fix (PR #7127)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    cb03074 [DomCrawler] lowered parsed protocol string (fixes #6986)
    
    Discussion
    ----------
    
    [DomCrawler] lowered parsed protocol string (fixes #6986)
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6986
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#123
    
    Are UTs needed for this?
  2. Johannes Klauss
Commits on Feb 18, 2013
  1. Fabien Potencier

    merged branch Seldaek/regressionfix (PR #7102)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    179cd58 [Process] Fix regression introduced in #6620 / 880da01, fixes #7082
    
    Discussion
    ----------
    
    [Process][2.0] getcwd failure fix
    
    Fix regression introduced in #6620
    Fixes #7082
    
    For reference, here is the current behavior I saw:
    
    PHP 5.4.11, windows:
    
    ```
    5.4.11\php.exe -r "chdir('c:\\'); var_dump(getcwd()); $p = proc_open('pwd', [['pipe', 'r'], ['pipe', 'w'], ['pipe', 'w']], $pipes, null); var_dump(stream_get_contents($pipes[1]));"
    string(3) "C:\\"
    string(14) "/c/Users/seld\n"
    ```
    
    (I use pwd which is a unix util so it dumps a funny path, but don't look at that)
    
    PHP 5.5alpha4, windows (seems fixed):
    
    ```
    5.5.0a4\php.exe  -r "chdir('c:\\'); var_dump(getcwd()); $p = proc_open('pwd', [['pipe', 'r'], ['pipe', 'w'], ['pipe', 'w']], $pipes, null); var_dump(stream_get_contents($pipes[1]));"
    string(3) "C:\"
    string(3) "/c\n"
    ```
    
    PHP 5.3.10, ubuntu:
    
    ```
    php -r "chdir('/'); var_dump(getcwd()); \$p = proc_open('pwd', array(array('pipe', 'r'), array('p
    ipe', 'w'), array('pipe', 'w')), \$pipes, null); var_dump(stream_get_contents(\$pipes[1]));"
    string(1) "/"
    string(2) "/\n"
    ```
    
    Since the permission issue that #6620 originally was fixing is most likely not gonna happen on windows, this seems like a safe enough compromise. Ideally a check for PHP<5.5 should be introduced, but I would like to be sure it's been fixed and is not just a lucky coincidence (/cc @PierreJoye)
    
    I would recommend merging fast and maybe adding the version check later, since it breaks composer create-project on windows. The workaround being: cd in the dir and run `composer install` again to finalize the project setup.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-17T20:12:17Z
    
    Thanks @Seldaek !
    
    Would you mind creating an issue for the version check so that it doesn't get lost ?
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2013-02-18T10:43:56Z
    
    @vicb done.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-18T11:45:16Z
    
    thanks !
Commits on Feb 17, 2013
  1. Jordi Boggiano
Commits on Feb 11, 2013
  1. Fabien Potencier
  2. Fabien Potencier

    merged branch jakzal/2.0-event (PR #7038)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    4ce9ac3 [EventDispatcher] Added assertion.
    
    Discussion
    ----------
    
    [EventDispatcher] Added assertion
    
    re #7023, I think it actually makes sense to add an assertion here. It reveals the intent of the test (listener is not removed).
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T11:32:06Z
    
    I don't think the assertion would fail with the former code, would it ?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T11:34:30Z
    
    I mean an error would be generated even before the assertion.
    
    ---------------------------------------------------------------------------
    
    by jakzal at 2013-02-10T11:37:05Z
    
    Yes, it would fail before getting to the assertion with: *Object of class Closure could not be converted to int*.
    
    However, this is something good to test for (and document - test is a documentation). We're not checking if type is taken into account in other tests. This test might still fail if code inside removeListener() changed.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T11:42:29Z
    
    I don't really understand your point and think it is a bit useless here but I am not against your change - I don't argue that test is doc though.
    
    ---------------------------------------------------------------------------
    
    by jakzal at 2013-02-10T15:38:09Z
    
    Assertion is indeed useless for the bug you discovered and fixed. I think it's still worth to have it there for  other reason:
    * test readability and completeness - with an assertion it's more clear that we don't expect the listener to be removed with the `removeListener()` call if passed argument doesn't match the one added before
    
    If you still don't see my point just close this PR :)
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T17:34:35Z
    
    What I mean is that you are unit testing php and it is not a job for sf. So it is not strictly required but as it doesn't hurt, let's merge your change.
    
    Jakub Zalas <notifications@github.com> wrote:
    
    >Assertion is indeed useless for the bug you discovered and fixed. I
    >think it's still worth to have it there for  other reason:
    >* test readability and completeness - with an assertion it's more clear
    >that we don't expect the listener to be removed with the
    >`removeListener()` call if passed argument doesn't match the one added
    >before
    >
    >If you still don't see my point just close this PR :)
    >
    >
    >---
    >Reply to this email directly or view it on GitHub:
    >#7038 (comment)
Commits on Feb 10, 2013
  1. Jakub Zalas
  2. Fabien Potencier

    merged branch vicb/event (PR #7023)

    fabpot authored
    This PR was squashed before being merged into the 2.0 branch (closes #7023).
    
    Commits
    -------
    
    87f3db7 [EventDispathcer] Fix removeListener
    
    Discussion
    ----------
    
    [EventDispathcer] Fix removeListener
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Todo
    
    - [x] Add a UT
    
    I won't have time to add a test before next Friday but this PR could save some debugging (especially with Silex & Closures)
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-09T23:32:51Z
    
    Probably related to https://bugs.php.net/bug.php?id=62976, I need to do some more investigation - I use 546. anyway the fix is valid for whatever php version.
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T10:24:46Z
    
    This **is** related to the PHP bug mentioned above, see http://3v4l.org/Q6WKj:
    
    ```
    Output for 5.3.18 - 5.3.21, 5.4.8 - 5.5.0alpha4
    bool(false)
    
    Output for 5.3.0 - 5.3.17, 5.4.0 - 5.4.7
    Notice: Object of class Klass could not be converted to int in /in/Q6WKj on line 9
    Notice: Object of class Closure could not be converted to int in /in/Q6WKj on line 9
    int(0)
    ```
    
    @fabpot anything more needed to merge this ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-02-10T10:26:52Z
    
    Is it possible to add a test?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T10:29:34Z
    
    It is, for php versions < fixed version, I'll do that
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T10:42:01Z
    
    @fabpot ready Sir !
    
    ---------------------------------------------------------------------------
    
    by vicb at 2013-02-10T10:44:35Z
    
    well I can probably add an assert, please wait !
  3. Victor Berchet Fabien Potencier

    [EventDispathcer] Fix removeListener

    vicb authored fabpot committed
Commits on Feb 7, 2013
  1. Fabien Potencier

    merged branch igorw/graphviz-frozen-container-2.0 (PR #7017)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    bd0ad92 [DependencyInjection] Allow frozen containers to be dumped to graphviz
    
    Discussion
    ----------
    
    [DependencyInjection] Allow frozen containers to be dumped to graphviz
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    This PR replaces #7010.
  2. Igor
  3. Fabien Potencier

    merged branch romainneutron/file-binary-guesser (PR #7006)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    a12744e Add dot character `.` to legal mime subtype regular expression
    
    Discussion
    ----------
    
    [HttpFoundation][2.0] Add dot character `.` to legal mime subtype regular expression
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    For example, the following mimetype (used for Microsoft powerpoints) is not recognized given the current regexp : `application/vnd.ms-powerpoint; charset=binary`
  4. Romain Neutron
  5. Fabien Potencier

    merged branch fabpot/request-uti-fix (PR #6966)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    ddf4678 [HttpFoundation] fixed the creation of sub-requests under some circumstancies (closes #6923, closes #6936)
    
    Discussion
    ----------
    
    [HttpFoundation] fixed the creation of sub-requests under some circumstancies (closes #6923, closes #6936)
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6923, #6936
    | License       | MIT
    | Doc PR        | n/a
    
    This fixes the creation of a sub-request when the master request Request URI
    is determined with specific server information.
Commits on Feb 4, 2013
  1. Fabien Potencier

    [HttpFoundation] fixed the creation of sub-requests under some circum…

    fabpot authored
    …stancies (closes #6923, closes #6936)
    
    This fixes the creation of a sub-request when the master request Request URI
    is determined with specific server information.
  2. Fabien Potencier

    merged branch fabpot/container-dumper-fix (PR #6959)

    fabpot authored
    This PR was submitted for the 2.2 branch but it was merged into the 2.0 branch instead (closes #6959).
    
    Commits
    -------
    
    ad889c9 [DependencyInjection] fixed a circular call (closes #6864)
    
    Discussion
    ----------
    
    [DependencyInjection] fixed a circular call (closes #6864)
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6864
    | License       | MIT
    | Doc PR        | n/a
  3. Fabien Potencier
Commits on Jan 22, 2013
  1. Fabien Potencier

    merged branch fabpot/synthetic-service-fix (PR #6827)

    fabpot authored
    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    4119caf [DependencyInjection] fixed the creation of synthetic services in ContainerBuilder
    
    Discussion
    ----------
    
    [DependencyInjection] fixed the creation of synthetic services in ContainerBuilder
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    ---------------------------------------------------------------------------
    
    by stof at 2013-01-22T00:14:29Z
    
    :+1:
Commits on Jan 21, 2013
  1. Fabien Potencier
  2. Fabien Potencier

    merged branch franmomu/added_phpdoc_security_events (PR #6818)

    fabpot authored
    This PR was squashed before being merged into the 2.0 branch (closes #6818).
    
    Commits
    -------
    
    598ae9d [Security] PHPDoc in SecurityEvents
    
    Discussion
    ----------
    
    [Security] PHPDoc in SecurityEvents
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    I'm not sure about the description given.
  3. Fran Moreno Fabien Potencier

    [Security] PHPDoc in SecurityEvents

    franmomu authored fabpot committed
Something went wrong with that request. Please try again.