Skip to content
Commits on Oct 10, 2013
  1. @fabpot

    updated VERSION for 2.1.13

    fabpot committed
  2. @fabpot

    updated CHANGELOG for 2.1.13

    fabpot committed
  3. @fabpot
Commits on Aug 7, 2013
  1. @fabpot

    updated VERSION for 2.1.12

    fabpot committed
  2. @fabpot

    updated CHANGELOG for 2.1.12

    fabpot committed
  3. @fabpot

    Merge branch '2.0' into 2.1

    fabpot committed
    * 2.0:
      added trusted hosts check
    
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
    	src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
    	src/Symfony/Component/HttpFoundation/Tests/RequestTest.php
Commits on Aug 6, 2013
  1. @jfsimon @fabpot

    added trusted hosts check

    jfsimon committed with fabpot
  2. @fabpot
  3. @fabpot

    Merge branch '2.0' into 2.1

    fabpot committed
    * 2.0:
      Fixed metadata serialization
  4. @webmozart @fabpot

    Fixed metadata serialization

    webmozart committed with fabpot
Commits on Jun 11, 2013
  1. @fabpot

    [Console] fixed regression when calling a command foo:bar if there is…

    fabpot committed
    … another one like foo:bar:baz (closes #8245)
  2. @fabpot

    Revert "[Console] ensure exit code between 0-254"

    fabpot committed
    This reverts commit 6b9180a.
  3. @fabpot

    merged branch Tobion/console-status-code (PR #8202)

    fabpot committed
    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [Console] fix status and exit code
    
    Fix #8183 (comment)
    and
    http://www.php.net/manual/en/function.exit.php
    > Exit statuses should be in the range 0 to 254, the exit status 255 is reserved by PHP and shall not be used. The status 0 is used to terminate the program successfully.
    
    Commits
    -------
    
    6b9180a [Console] ensure exit code between 0-254
    445b2e3 [Console] fix status code when Exception::getCode returns something like 0.1
Commits on Jun 9, 2013
  1. @Tobion

    [Console] ensure exit code between 0-254

    Tobion committed
    255 is reserved by PHP and should not be used
    
    also put this code inside the codeCoverageIgnore block because it cannot be tested with phpunit
Commits on Jun 5, 2013
  1. @Tobion
Commits on Jun 4, 2013
  1. @fabpot

    merged branch Stelian/2.2 (PR #8183)

    fabpot committed
    This PR was submitted for the 2.2 branch but it was merged into the 2.1 branch instead (closes #8183).
    
    Discussion
    ----------
    
    Fixed exit code for exceptions with error code 0
    
    Covers #8180
    
    Commits
    -------
    
    48e77f8 Fixed exit code for exceptions with error code 0
  2. @Stelian @fabpot
Commits on Jun 2, 2013
  1. @fabpot

    updated VERSION for 2.1.11

    fabpot committed
  2. @fabpot

    update CONTRIBUTORS for 2.1.11

    fabpot committed
  3. @fabpot

    updated CHANGELOG for 2.1.11

    fabpot committed
  4. @fabpot

    merged branch odi86/check-post-max-size-zero (PR #8149)

    fabpot committed
    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [Form] [Validator] Fixed post_max_size = 0 bug (issue #8065)
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #8065
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    2038329 [Form] [Validator] Fixed post_max_size = 0 bug (Issue #8065)
  5. @fabpot
Commits on May 27, 2013
  1. @metaodi
  2. @fabpot

    merged branch jbafford/doubled-word-fixes (PR #8144)

    fabpot committed
    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    Fix several instances of doubled words
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    One correction to an exception; the rest in docblocks.
    
    Commits
    -------
    
    52fed7b Fix several instances of doubled words
Commits on May 26, 2013
  1. @jbafford

    Fix several instances of doubled words

    jbafford committed
    One in an exception; the rest in docblocks.
Commits on May 25, 2013
  1. @fabpot

    merged branch alquerci/ticket-3585-7834 (PR #8120)

    fabpot committed
    This PR was squashed before being merged into the 2.1 branch (closes
    
    Discussion
    ----------
    
    [Finder] Fix iteration fails with non-rewindable streams
    
    <table>
      <tr>
        <th>Q</th><th>A</th>
      </tr>
      <tr>
        <td>Bug fix?</td><td>yes</td>
      </tr>
      <tr>
        <td>New feature?</td><td>no</td>
      </tr>
      <tr>
        <td>BC breaks?</td><td>no</td>
      </tr>
      <tr>
        <td>Deprecations?</td><td>no</td>
      </tr>
      <tr>
        <td>Tests pass?</td><td>yes</td>
      </tr>
      <tr>
        <td>Fixed tickets</td><td>#3585, #7834</td>
      </tr>
      <tr>
        <td>License?</td><td>MIT</td>
      </tr>
    </table>
    
    - [x] Add a good detection of non seekable stream
    - [x] Add some unit tests
    
    But the iteration under ftp stream still not work properly. Edit: need
    tests for that.
    
    Commits
    -------
    
    169c0b9 [Finder] Fix iteration fails with non-rewindable streams
  2. @alquerci @fabpot
  3. @fabpot

    merged branch alquerci/issue-4922 (PR #8127)

    fabpot committed
    This PR was squashed before being merged into the 2.1 branch (closes #8127).
    
    Discussion
    ----------
    
     [Finder] Fix unexpected duplicate sub path related AppendIterator issue
    
    Bug fix: yes
    New feature: no
    BC breaks: no
    Deprecations: no
    Tests pass: yes
    Fixes: #4993 (comment)
    Todo: -
    License of the code: MIT
    
    > @dg:  I am afraid it is not working, see this example http://davidgrudl.com/tmp/appenditerator-finder.zip.
    
    Commits
    -------
    
    45b68e0  [Finder] Fix unexpected duplicate sub path related AppendIterator issue
  4. @alquerci @fabpot
Commits on May 23, 2013
  1. @fabpot

    merged branch richsage/voterinterface-docblock-type (PR #8117)

    fabpot committed
    This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #8117).
    
    Discussion
    ----------
    
    [Security] Added type of return value in VoterInterface.
    
    | Q             | A
    | ------------- | ---
    | Fixed tickets | none
    | License       | MIT
    
    Simple addition of the return type for the `supportsClass` method, as per the `supportsAttribute` method doc in the interface.
    
    Commits
    -------
    
    c176d1e [Security] Added type of return value in VoterInterface.
  2. @richsage @fabpot
Commits on May 20, 2013
  1. @fabpot

    merged branch jdesrosiers/ticket_8097 (PR #8098)

    fabpot committed
    This PR was submitted for the 2.0 branch but it was merged into the 2.1 branch instead (closes #8098).
    
    Discussion
    ----------
    
    [HttpKernel] Fixed two bugs in HttpCache
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #8097
    | License       | MIT
    | Doc PR        |
    
    1. 304 responses always send "Content-Type: text/html; charset=UTF-8"
    header
    I discovered that the HttpCache::handle method calls Response::prepare
    after calling Response::isModified.  Response::isModified removes the
    Content-Type header as it should, but Response::handle adds in the
    default Content-Type header when none is set.  If the default
    Content-Type is not the correct Content-Type, then the Content-Type in
    the cache gets clobered.  I solved this problem by moving the
    Response::isModified call after the Response::prepare call.  I updated
    the testRespondsWith304WhenIfModifiedSinceMatchesLastModified and
    testRespondsWith304WhenIfNoneMatchMatchesETag tests to verify that the
    Content-Type header was not being sent for 304 responses.
    
    2. Failure to invalidate cached entities referred to by the Location
    header
    I discovered that the Store::invalidate method was looking for Location
    and Content-Location headers to invalidate, but it was looking in the
    request headers instead of the response headers.  Because the
    Store::invalidate method doesn't take a response, I decided it was
    better to move this logic to the HttpCache::invalidate method instead.
    I updated the testInvalidatesCachedResponsesOnPost test to verify that
    Location headers are getting invalidated correctly.
    
    Commits
    -------
    
    a4251bd [HttpKernel] Fixed two bugs in HttpCache
  2. @jdesrosiers @fabpot

    Fixed two bugs in HttpCache

    jdesrosiers committed with fabpot
    1. 304 responses always send "Content-Type: text/html; charset=UTF-8"
    header
    I discovered that the HttpCache::handle method calls Response::prepare
    after calling Response::isModified.  Response::isModified removes the
    Content-Type header as it should, but Response::handle adds in the
    default Content-Type header when none is set.  If the default
    Content-Type is not the correct Content-Type, then the Content-Type in
    the cache gets clobered.  I solved this problem by moving the
    Response::isModified call after the Response::prepare call.  I updated
    the testRespondsWith304WhenIfModifiedSinceMatchesLastModified and
    testRespondsWith304WhenIfNoneMatchMatchesETag tests to verify that the
    Content-Type header was not being sent for 304 responses.
    
    2. Failure to invalidate cached entities referred to by the Location
    header
    I discovered that the Store::invalidate method was looking for Location
    and Content-Location headers to invalidate, but it was looking in the
    request headers instead of the response headers.  Because the
    Store::invalidate method doesn't take a response, I decided it was
    better to move this logic to the HttpCache::invalidate method instead.
    I updated the testInvalidatesCachedResponsesOnPost test to verify that
    Location headers are getting invalidated correctly.
Commits on May 19, 2013
  1. @fabpot

    merged branch Tobion/console-exit-code (PR #8080)

    fabpot committed
    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [Console] fix and refactor exit code handling
    
    Split of #8038
    
    Commits
    -------
    
    5c317b7 [Console] fix and refactor exit code handling
  2. @fabpot

    merged branch lazyhammer/issue-8068-2.1 (PR #8073)

    fabpot committed
    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [CssSelector] Fix :nth-last-child() translation
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #8068
    | License       | MIT
    | Doc PR        | n/a
    
    Same as #8072, but for < 2.3
    
    Commits
    -------
    
    1469953 [CssSelector] Fix :nth-last-child() translation
Something went wrong with that request. Please try again.