Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Dec 23, 2013
  1. @fabpot

    bug #9806 [Security] Fix parent serialization of user object (ddeboer)

    fabpot authored
    This PR was squashed before being merged into the 2.2 branch (closes #9806).
    
    Discussion
    ----------
    
    [Security] Fix parent serialization of user object
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    `parent::serialize()` and `parent::unserialize()`, which are used in the `AbstractToken` are [problematic](https://bugs.php.net/bug.php?id=62836) in PHP >= 5.4. [Cloning the object](https://gist.github.com/aurelijus/4713758) before serialization seems to fix this.
    
    Commits
    -------
    
    2e4670d [Security] Fix parent serialization of user object
  2. @ddeboer @fabpot

    [Security] Fix parent serialization of user object

    ddeboer authored fabpot committed
Commits on Dec 2, 2013
  1. @fabpot

    updated VERSION for 2.2.11

    fabpot authored
  2. @fabpot

    update CONTRIBUTORS for 2.2.11

    fabpot authored
  3. @fabpot

    updated CHANGELOG for 2.2.11

    fabpot authored
Commits on Nov 30, 2013
  1. @fabpot

    minor #9664 [HttpKernel] minor optimalization at bundle initializatio…

    fabpot authored
    …n (fabpot)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [HttpKernel] minor optimalization at bundle initialization
    
    fast check to avoid six array method calls
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [no]
    | New feature?  | [no]
    | BC breaks?    | [no]
    | Deprecations? | [|no]
    | Tests pass?   | [yes]
    | Fixed tickets | #9657
    | License       | MIT
    | Doc PR        |
    
    That's a rebased version of #9657 on 2.2 + another optimization suggested by @GromNaN
    
    Commits
    -------
    
    3330c40 [HttpKernel] made a small optimization to Bundle initialization
    4ba6c0b minor optimalization at bundle initialization
  2. @fabpot
  3. @tgabi333 @fabpot

    minor optimalization at bundle initialization

    tgabi333 authored fabpot committed
    fast check to avoid six array method calls
  4. @fabpot

    minor #9661 Removed observer pattern, in favour of mediator (fabpot)

    fabpot authored
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    Removed observer pattern, in favour of mediator
    
    | Q             | A
    | ------------- | ---
    | Doc fix?      | yes
    | New docs?     | no
    | Applies to    | *
    | Fixed tickets | #9344
    
    I don't think this is the best tool to implement the observer pattern.
    
    I just have copied the sentence from:
    https://github.com/symfony/symfony-docs/edit/2.3/components/event_dispatcher/introduction.rst
    
    but maybe could be improved with something like:
    
    "Symfony Event Dispatcher is a tool that allows to make your projects truly extensible, facilitating the implementation of Mediator pattern and Publish subscribe pattern"
    
    [edit-1]
    I think this could be modified also here:
    https://github.com/symfony/symfony-marketing/edit/master/views/en/get_started/components.html.twig
    
    Commits
    -------
    
    ab3e231 [EventDispatcher] tweaked README
    b9ad62e removed observer pattern, in favour of mediator
  5. @fabpot
  6. @liuggio @fabpot

    removed observer pattern, in favour of mediator

    liuggio authored fabpot committed
Commits on Nov 29, 2013
  1. @fabpot

    bug #9656 [DoctrineBridge] normalized class names in the ORM type gue…

    fabpot authored
    …sser (fabpot)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [DoctrineBridge] normalized class names in the ORM type guesser
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #5837
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    a1b9c2e [DoctrineBridge] normalized class names in the ORM type guesser
  2. @fabpot
  3. @fabpot

    bug #9647 use the correct class name to retrieve mapped class' metada…

    fabpot authored
    …ta and reposi... (xabbuh)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    use the correct class name to retrieve mapped class' metadata and reposi...
    
    ...tory
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #9646
    | License       | MIT
    | Doc PR        |
    
    The validation context isn't necessarily the entity being validated. In case that you added the Unique Entity constraint inside your custom type via the ``constraints`` option the validation context will be the ``Form`` class itself. Thus, not the validation context should be used to get the class metadata and the repository of the validated entity, but the entity itself should be used.
    
    Commits
    -------
    
    cd4df11 use the correct class name to retrieve mapped class' metadata and repository
  4. @fabpot

    minor #9651 Fix `extract` method to avoid recalculating count() for e…

    fabpot authored
    …ach iteration. (fabpot)
    
    This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9651).
    
    Discussion
    ----------
    
    Fix `extract` method to avoid recalculating count() for each iteration.
    
    This PR was submitted on the symfony/DomCrawler read-only repository and moved automatically to the main Symfony repository (closes symfony/DomCrawler#16).
    
    Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop.
    
    Since this count will never change during the method execution, this change make the code a bit more efficient.
    
    Commits
    -------
    
    9ababf4 Fix `extract` method to avoid recalculating count() for each iteration.
  5. @miclf @fabpot

    Fix `extract` method to avoid recalculating count() for each iteration.

    miclf authored fabpot committed
    Cache the value of `count($attributes)` to avoid recalculating it for each iteration of the loop.
    
    Since this count will never change during the method execution, this change make the code a bit more efficient.
Commits on Nov 28, 2013
  1. @xabbuh
  2. @fabpot

    bug #9643 [WebProfilerBundle] Fixed js escaping in time.html.twig (ha…

    fabpot authored
    …son)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] Fixed js escaping in time.html.twig
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    For some event names I received the JavaScript error: ```Uncaught SyntaxError: Unexpected token ILLEGAL```
    
    Commits
    -------
    
    4828350 [WebProfilerBundle] Fixed js escaping in time.html.twig
  3. @hason
  4. @fabpot

    minor #9640 Fixed wrong property in test teardown (fabpot)

    fabpot authored
    This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9640).
    
    Discussion
    ----------
    
    Fixed wrong property in test teardown
    
    This PR was submitted on the symfony/EventDispatcher read-only repository and moved automatically to the main Symfony repository (closes symfony/EventDispatcher#2).
    
    Commits
    -------
    
    5330603 Teardown used wrong property
  5. @deegital @fabpot

    Teardown used wrong property

    deegital authored fabpot committed
  6. @fabpot

    bug #9639 Modified guessDefaultEscapingStrategy to not escape txt tem…

    fabpot authored
    …plates (fabpot)
    
    This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9639).
    
    Discussion
    ----------
    
    Modified guessDefaultEscapingStrategy to not escape txt templates
    
    This PR was submitted on the symfony/TwigBundle read-only repository and moved automatically to the main Symfony repository (closes symfony/TwigBundle#2).
    
    Useful for plaintext emails.
    
    Commits
    -------
    
    6affe94 Modified guessDefaultEscapingStrategy to not escape txt templates
  7. @maryo @fabpot

    Modified guessDefaultEscapingStrategy to not escape txt templates

    maryo authored fabpot committed
    Useful for plaintext emails.
  8. @fabpot

    bug #9314 [Form] Fix DateType for 32bits computers. (WedgeSama)

    fabpot authored
    This PR was squashed before being merged into the 2.2 branch (closes #9314).
    
    Discussion
    ----------
    
    [Form] Fix DateType for 32bits computers.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #5227,#5554
    | License       | MIT
    | Doc PR        | -
    
    Fix an issue due to 32bits machines, date can be only between 1902-2037.
    Simply not add date if false. Can be good to add this to 2.3 and master too.
    
    Commits
    -------
    
    b80fb43 [Form] Fix DateType for 32bits computers.
  9. @WedgeSama @fabpot

    Fix DateType for 32bits computers.

    WedgeSama authored fabpot committed
  10. @fabpot

    bug #9443 [FrameworkBundle] Fixed the registration of validation.xml …

    fabpot authored
    …file when the form is disabled (hason)
    
    This PR was submitted for the 2.1 branch but it was merged into the 2.2 branch instead (closes #9443).
    
    Discussion
    ----------
    
    [FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    cfa5aa5 [FrameworkBundle] Fixed the registration of validation.xml file when the form is disabled
  11. @hason @fabpot
  12. @fabpot

    bug #9625 [HttpFoundation] Do not return an empty session id if the s…

    fabpot authored
    …ession was closed (Taluu)
    
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Do not return an empty session id if the session was closed
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #7936
    | License       | MIT
    | Doc PR        | ~
    
    A regression from the bug fix #9246 was introduced due to an incomplete fix ;
    
    As the `started` flag on the NativeSessionStorage was not `true` anymore when saving the session, the session id was always empty when saving it, and thus when sending the `PHPSESSID` cookie.
    
    The previous PR I made (#9530) was another approach to solve this regression, but this one should keep the fix made by @tecbot on #9246, and finish it with another verification. I may miss another place where `started` is used, but I don't really see which other conditions depending on this property should be altered...
    
    **Note : this is #9611 rebased on 2.2**
    
    This should be mergeable.
    
    Commits
    -------
    
    5b9a727 When getting the session's id, check if the session is not closed
Commits on Nov 27, 2013
  1. @Taluu

    When getting the session's id, check if the session is not closed

    Taluu authored
    This introduced a regression from #9246, with an incomplete fix ;
    As the `started` flag on the NativeSessionStorage was not `true`
    anymore when saving the session, the session id was always empty
    when saving it, and thus when sending the `PHPSESSID` cookie
Commits on Nov 25, 2013
  1. @fabpot

    minor #9603 Fixed some typos (fabpot)

    fabpot authored
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    Fixed some typos
    
    Commits
    -------
    
    5c6edb3 fixed some typos
    8d69bb5 fixed @expectedException class names
  2. @fabpot

    fixed some typos

    fabpot authored
  3. @fabpot
Commits on Nov 22, 2013
  1. @fabpot

    bug #9447 [BrowserKit] fixed protocol-relative url redirection (jong99)

    fabpot authored
    This PR was merged into the 2.2 branch.
    
    Discussion
    ----------
    
    [BrowserKit] fixed protocol-relative url redirection
    
    Fixed redirects to protocol relative URLs, e.g. //www.example.org.  Previously the code would treat this as a relative URL.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #9445
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    e8b5c84 bug #9445 [BrowserKit] fixed protocol-relative url redirection
  2. @fabpot

    bug #9535 No Entity Manager defined exception (armetiz)

    fabpot authored
    This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9535).
    
    Discussion
    ----------
    
    No Entity Manager defined exception
    
    This PR is linked to this issue : #9534
    
    Commits
    -------
    
    719ccb7 No Entity Manager defined exception
  3. @armetiz @fabpot

    No Entity Manager defined exception

    armetiz authored fabpot committed
Something went wrong with that request. Please try again.