Permalink
Commits on May 30, 2016
  1. Merge pull request #18916 from fabpot/release-2.3.42

    fabpot committed May 30, 2016
    released v2.3.42
  2. updated VERSION for 2.3.42

    fabpot committed May 30, 2016
  3. update CONTRIBUTORS for 2.3.42

    fabpot committed May 30, 2016
  4. updated CHANGELOG for 2.3.42

    fabpot committed May 30, 2016
  5. Revert "bug #18908 [DependencyInjection] force enabling the external …

    nicolas-grekas committed May 30, 2016
    …XML entity loaders (xabbuh)"
    
    This reverts commit 44f6f89, reversing
    changes made to 57d6053.
  6. bug #18908 [DependencyInjection] force enabling the external XML enti…

    nicolas-grekas committed May 30, 2016
    …ty loaders (xabbuh)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] force enabling the external XML entity loaders
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18876
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    142b1a4 force enabling the external XML entity loaders
  7. bug #18893 [DependencyInjection] Skip deep reference check for 'servi…

    nicolas-grekas committed May 30, 2016
    …ce_container' (RobertMe)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Skip deep reference check for 'service_container'
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    The "hasReference" check when dumping the container fails in the case where a service has a method call which includes a reference to a private/inlined service when either that service, or a dependency of it, references the service_container. This because service_container isn't defined while it still tries to check the references of it. So the service_container must be skipped in this case, this shouldn't break anything as the service_container doesn't reference any services, and thus can't reference the service which it is checking for.
    
    Commits
    -------
    
    6f36733 [DependencyInjection] Skip deep reference check for 'service_container'
  8. Partial revert of previous PR

    nicolas-grekas committed May 30, 2016
  9. [DependencyInjection] Skip deep reference check for 'service_container'

    Robert-TelePsy authored and RobertMe committed May 26, 2016
    Deep checks on whether a service references another service need to
    exclude the 'service_container' service as it doesn't exist. Without this
    dumping the container will fail if a service definition references an
    inlined service which has a direct or indirect dependency to the
    service_container.
  10. bug #18812 Catch \Throwable (fprochazka)

    nicolas-grekas committed May 30, 2016
    This PR was squashed before being merged into the 2.3 branch (closes #18812).
    
    Discussion
    ----------
    
    Catch \Throwable
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3, 2.7, 2.8, 3.0
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | Yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Related symfony/symfony#18765, symfony/symfony#15949
    
    Commits
    -------
    
    893cf00 Catch \Throwable
  11. Catch \Throwable

    fprochazka authored and nicolas-grekas committed May 12, 2016
  12. bug #18821 [2.3][Form] Removed UTC specification with timestamp (fran…

    nicolas-grekas committed May 30, 2016
    …cisbesset)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3][Form] Removed UTC specification with timestamp
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    The function `date_parse()` indicates a warning if a timezone is used with the timestamp: `Double timezone specification`. I removed the UTC specification and this time it's more faster!
    
    Commits
    -------
    
    0d14aac Removed UTC specification with timestamp
  13. minor #18854 [Serializer] Add missing @throws annotations (theofidry)

    nicolas-grekas committed May 30, 2016
    This PR was squashed before being merged into the 2.3 branch (closes #18854).
    
    Discussion
    ----------
    
    [Serializer] Add missing @throws annotations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18798
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    b73400d [Serializer] Add missing @throws annotations
  14. bug #18861 Fix for #18843 (inso)

    nicolas-grekas committed May 30, 2016
    This PR was squashed before being merged into the 2.3 branch (closes #18861).
    
    Discussion
    ----------
    
    Fix for #18843
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18843
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    7d78196 Fix for #18843
  15. Fix for #18843

    inso authored and nicolas-grekas committed May 24, 2016
Commits on May 29, 2016
  1. bug #18907 [Routing] Fix the annotation loader taking a class constan…

    fabpot committed May 29, 2016
    …t as a beginning of a class name (jakzal, nicolas-grekas)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Routing] Fix the annotation loader taking a class constant as a beginning of a class name
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18633
    | License       | MIT
    | Doc PR        | -
    
    Code copy/pasted from ClassMapGenerator.php
    
    Commits
    -------
    
    8d4f35d [Routing] Finish annotation loader taking a class constant as a beginning of a class name
    43c7f9b [Routing] Fix the annotation loader taking a class constant as a beginning of a class name
  2. force enabling the external XML entity loaders

    xabbuh committed May 29, 2016
  3. [Routing] Finish annotation loader taking a class constant as a begin…

    nicolas-grekas committed May 29, 2016
    …ning of a class name
  4. minor #18906 [PropertyAccess] Fix for PHP 7.0.7 (nicolas-grekas)

    nicolas-grekas committed May 29, 2016
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [PropertyAccess] Fix for PHP 7.0.7
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This is what break travis currently.
    See https://3v4l.org/r37rY
    
    Commits
    -------
    
    a125af7 [PropertyAccess] Fix for PHP 7.0.7
  5. [PropertyAccess] Fix for PHP 7.0.7

    nicolas-grekas committed May 29, 2016
Commits on May 26, 2016
  1. fixed PHP 5.3 compat in tests

    fabpot committed May 26, 2016
  2. bug #18864 [Console][DX] Fixed ambiguous error message when using a d…

    fabpot committed May 26, 2016
    …uplicate option shortcut (peterrehm)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #18864).
    
    Discussion
    ----------
    
    [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18856
    | License       | MIT
    | Doc PR        | -
    
    I assume this should be merged into 2.3 as per @stof's comment.
    
    There is a race condition when you run a command which has a duplicate option shortcut. Simply changing the order so that Options are merged before the Arguments solves that race condition.
    
    ````php
    $this->setName('my:super:command')
    ->setAliases(['my:super:commandalias'])
    ->setDescription('Performs some irrelevant work.')
    ->addOption('survey', 'e', InputOption::VALUE_REQUIRED, 'My option with a shortcut.')
    ````
    
    Gives the error message:
    
    ```
      [Symfony\Component\Console\Exception\LogicException]
      An argument with name "command" already exists.
    ```
    
    This happens as the first time the definition is merged happens here:
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Application.php#L820
    
    As this throws an error here:
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L309
    
    The commans are merged but not the options.
    
    Merging it then again when the command is run
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Command/Command.php#L217
    
    throws an error due to the duplicate argument as the arguments already have been merged. This time the error message is not surpressed and will confuse the user.
    
    Changing the order should fix the issue for duplicate arguments as well as for duplicate options.
    
    Commits
    -------
    
    7cb7655 [Console][DX] Fixed ambiguous error message when using a duplicate option shortcut
Commits on May 24, 2016
  1. Removed UTC specification with timestamp

    francisbesset committed May 20, 2016
Commits on May 23, 2016
  1. bug #18844 [Yaml] fix exception contexts (xabbuh)

    fabpot committed May 23, 2016
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Yaml] fix exception contexts
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    9bdaba4 [Yaml] fix exception contexts
  2. [Yaml] fix exception contexts

    xabbuh committed May 23, 2016
  3. bug #18840 [Yaml] properly handle unindented collections (xabbuh)

    fabpot committed May 23, 2016
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Yaml] properly handle unindented collections
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #8077
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    717e1a9 [Yaml] properly handle unindented collections
  4. bug #18839 People - person singularization (Keeo)

    fabpot committed May 23, 2016
    This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #18839).
    
    Discussion
    ----------
    
    People - person singularization
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Bugfix for version 2.8 - more information [#18824]
    
    Commits
    -------
    
    02070f9 People - person singularization
  5. People - person singularization

    Keeo authored and fabpot committed May 22, 2016
  6. bug #18828 [Yaml] chomp newlines only at the end of YAML documents (x…

    fabpot committed May 23, 2016
    …abbuh)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Yaml] chomp newlines only at the end of YAML documents
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18784
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    a4b1fa6 chomp newlines only at the end of YAML documents
Commits on May 22, 2016
  1. [Yaml] properly handle unindented collections

    xabbuh committed May 22, 2016
Commits on May 21, 2016
  1. chomp newlines only at the end of YAML documents

    xabbuh committed May 14, 2016
Commits on May 13, 2016
  1. minor #18775 Fix computation of PR diffs for component matrix lines (…

    fabpot committed May 13, 2016
    …nicolas-grekas)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    Fix computation of PR diffs for component matrix lines
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Validated on https://travis-ci.org/symfony/symfony/jobs/130061271 who fails otherwise.
    
    Commits
    -------
    
    e7a3ae7 Fix computation of PR diffs for component matrix lines
  2. Fix computation of PR diffs for component matrix lines

    nicolas-grekas committed May 13, 2016