Permalink
Commits on Sep 28, 2014
  1. updated VERSION for 2.4.10

    fabpot committed Sep 28, 2014
  2. updated CHANGELOG for 2.4.10

    fabpot committed Sep 28, 2014
  3. minor #12071 [Debug] fixed class lookup when using PSR-0 with a targe…

    …t dir (fabpot)
    
    This PR was merged into the 2.4 branch.
    
    Discussion
    ----------
    
    [Debug] fixed class lookup when using PSR-0 with a target dir
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    f5b38ec [Debug] fixed class lookup when using PSR-0 with a target dir
    fabpot committed Sep 28, 2014
  4. [Debug] fixed class lookup when using PSR-0 with a target dir

    fabpot committed Sep 28, 2014
  5. fixed standalone tests

    fabpot committed Sep 28, 2014
  6. fixed standalone tests

    fabpot committed Sep 28, 2014
Commits on Sep 27, 2014
  1. Merge branch '2.3' into 2.4

    * 2.3:
      [SecurityBundle] fixed tests when used in standalone
    fabpot committed Sep 27, 2014
  2. Merge branch '2.3' into 2.4

    * 2.3:
      Make Doctrine's dependency injection test less fragile.
      [Finder] [Iterator] Make the tests less fragile
      [Form][DateTime] Propagate invalid_message & invalid_message parameters to date & time sub widgets
    fabpot committed Sep 27, 2014
  3. minor #12058 [Doctrine][DependencyInjection] Make a test less fragile…

    …. (AlphaStream)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12058).
    
    Discussion
    ----------
    
    [Doctrine][DependencyInjection] Make a test less fragile.
    
    The test checks that a few items are ordered according to the value of their 'priority' attribute. However, a few of the items have the same value of this attribute. RegisterEventListenersAndSubscribersPass doesn't use a stable sorting, yet the test asserts that items that are 'equal' shall go in the original order. Modified so that the order of the original items is not checked.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [no]
    | New feature?  | [no]
    | BC breaks?    | [no]
    | Deprecations? | [no]
    | Tests pass?   | [yes]
    | Fixed tickets | [none]
    | License       | MIT
    | Doc PR        | [none]
    
    Commits
    -------
    
    f1ae970 Make Doctrine's dependency injection test less fragile.
    fabpot committed Sep 27, 2014
  4. Make Doctrine's dependency injection test less fragile.

    [Doctrine][DependencyInjection] The test checks that a few items are ordered according to the value of their 'priority' attribute. However, a few of the items have the same value of this attribute. RegisterEventListenersAndSubscribersPass doesn't use a stable sorting, yet the test asserts that items that are 'equal' shall go in the original order. Modified so that the order of the original items is not checked.
    AlphaStream committed with fabpot Sep 26, 2014
Commits on Sep 26, 2014
  1. minor #12028 [Finder] [Iterator] Make the tests less fragile (AlphaSt…

    …ream)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12028).
    
    Discussion
    ----------
    
    [Finder] [Iterator] Make the tests less fragile
    
    Modified the Iterator tests so that they assert only on what's actually being tested. In particular, the tests were checking the order of the files [that were created virtually simultaneously] after sorting them by date. This change is a part of the effort to make Symfony successfully pass tests on HHVM
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [no]
    | New feature?  | [no]
    | BC breaks?    | [no]
    | Deprecations? | [no]
    | Tests pass?   | [yes]
    | Fixed tickets | [none]
    | License       | MIT
    | Doc PR        | [none]
    
    Commits
    -------
    
    10f9135 [Finder] [Iterator] Make the tests less fragile
    fabpot committed Sep 26, 2014
Commits on Sep 25, 2014
  1. bug #9453 [Form][DateTime] Propagate invalid_message & invalid_messag…

    …e_parameters to date & time (egeloen)
    
    This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #9453).
    
    Discussion
    ----------
    
    [Form][DateTime] Propagate invalid_message & invalid_message_parameters to date & time
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This PR propagates the `invalid_message` & `invalid_message_parameters` in the datetime form type to the date & time sub form types. It allows to have the good error message if you use something else than the `single_widget` widget.
    
    I have looked the `DateTimeTypeTest` but I have not found tests related to this kind of propagation, so for now I have not added tests yet.
    
    Commits
    -------
    
    ea4ae74 [Form][DateTime] Propagate invalid_message & invalid_message parameters to date & time sub widgets
    webmozart committed Sep 25, 2014
  2. [Form][DateTime] Propagate invalid_message & invalid_message paramete…

    …rs to date & time sub widgets
    egeloen committed with webmozart Nov 6, 2013
  3. bug #12030 Fix expression language in the container when using the "c…

    …ontainer" variable (fabpot)
    
    This PR was squashed before being merged into the 2.4 branch (closes #12030).
    
    Discussion
    ----------
    
    Fix expression language in the container when using the "container" variable
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #11995
    | License       | MIT
    | Doc PR        | n/a
    
    See #11995 for the description of the problem.
    
    Commits
    -------
    
    2b2f0df Fix expression language in the container when using the "container" variable
    fabpot committed Sep 25, 2014
  4. Merge branch '2.3' into 2.4

    * 2.3:
      [Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5
      [Validator] Simplified testing of violations
    fabpot committed Sep 25, 2014
  5. minor #12015 [Validator] Simplified testing of violations (webmozart)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Validator] Simplified testing of violations
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I simplified the assertion of violations in preparation of a replacement PR for #7276.
    
    Commits
    -------
    
    8e5537b [Validator] Simplified testing of violations
    fabpot committed Sep 25, 2014
  6. minor #12033 [Form] Removed constructor argument from FormTypeHttpFou…

    …ndationExtension for forward compatibility with 2.5 (webmozart)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This argument was introduced in #11924. No release was made of the 2.3 branch after merging that PR.
    
    Since a different constructor argument (`$requestHandler`) was added to FormTypeHttpFoundationExtension in the 2.5 branch, we cannot merge this forward in a BC fashion. For this reason, I removed the argument again.
    
    Commits
    -------
    
    6cbc862 [Form] Removed constructor argument from FormTypeHttpFoundationExtension for forward compatibility with 2.5
    fabpot committed Sep 25, 2014
  7. [Form] Removed constructor argument from FormTypeHttpFoundationExtens…

    …ion for forward compatibility with 2.5
    webmozart committed Sep 25, 2014
  8. [Validator] Simplified testing of violations

    webmozart committed Sep 24, 2014
  9. Merge branch '2.3' into 2.4

    * 2.3:
      remove obsolete test file
      [FrameworkBundle] output failed matched path for clarification
      bug #10242 Missing checkPreAuth from RememberMeAuthenticationProvider
      [Validator] Fixed StaticMethodLoaderTest to actually test something
      [Form] Fixed ValidatorTypeGuesser to guess properties without constraints not to be required
      Use request format from request in twig ExceptionController
      [Form] Moved POST_MAX_SIZE validation from FormValidator to request handler
      [Form] Add a form error if post_max_size has been reached.
      Response::isNotModified returns true when If-Modified-Since is later than Last-Modified
      [WebProfilerBundle] turbolinks compatibility
    
    Conflicts:
    	src/Symfony/Component/Form/CHANGELOG.md
    	src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php
    	src/Symfony/Component/Security/Core/Tests/Authentication/Provider/RememberMeAuthenticationProviderTest.php
    fabpot committed Sep 25, 2014
  10. minor #12017 [Validator] Fixed StaticMethodLoaderTest to actually tes…

    …t something (webmozart)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Validator] Fixed StaticMethodLoaderTest to actually test something
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This test is not testing anything, except for whether PHP throws a strict standards error when invalid code is loaded.
    
    I disabled error reporting for this test, so that the actual functionality (ignoring static+abstract functions) is tested.
    
    Commits
    -------
    
    1b1303a [Validator] Fixed StaticMethodLoaderTest to actually test something
    fabpot committed Sep 25, 2014
  11. minor #12026 [FrameworkBundle] output failed matched path for clarifi…

    …cation (Tobion)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] output failed matched path for clarification
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #11780
    | License       | MIT
    | Doc PR        | -
    
    Because cygwin resolves the path behind the scenes, it is otherwise very unclear what path is actually used for matching.
    
    Commits
    -------
    
    8d13af7 [FrameworkBundle] output failed matched path for clarification
    fabpot committed Sep 25, 2014
  12. minor #12027 remove obsolete test file (Tobion)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    remove obsolete test file
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I don't think this file is used anymore.
    
    Commits
    -------
    
    83f556f remove obsolete test file
    fabpot committed Sep 25, 2014
Commits on Sep 24, 2014
  1. remove obsolete test file

    Tobion committed Sep 24, 2014
  2. [FrameworkBundle] output failed matched path for clarification

    Tobion committed Sep 24, 2014
  3. bug #11058 [Security] bug #10242 Missing checkPreAuth from RememberMe…

    …AuthenticationProvider (glutamatt)
    
    This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #11058).
    
    Discussion
    ----------
    
    [Security] bug #10242 Missing checkPreAuth from RememberMeAuthenticationProvider
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #10242
    | License       | MIT
    
    [Security] fixed missing call to UserChecker::checkPreAuth
    
    edit : after the discution with @hellomedia , i replaced postcheck with precheck
    glutamatt@e0730e0#commitcomment-6580764
    
    Commits
    -------
    
    a38d1cd bug #10242 Missing checkPreAuth from RememberMeAuthenticationProvider
    fabpot committed Sep 24, 2014
  4. [Validator] Fixed StaticMethodLoaderTest to actually test something

    webmozart committed Sep 24, 2014
  5. bug #12004 [Form] Fixed ValidatorTypeGuesser to guess properties with…

    …out constraints not to be required (webmozart)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Form] Fixed ValidatorTypeGuesser to guess properties without constraints not to be required
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6645
    | License       | MIT
    | Doc PR        | -
    
    Consider the following entity:
    
    ```php
    class Author
    {
        /**
         * @Assert\NotBlank
         */
        private $name;
    
        private $age;
    }
    ```
    
    Right now, the "required" HTML attribute is set for both fields (since the default value of the "required" option is true). IMO this is wrong.
    
    With this fix, the ValidatorTypeGuesser guesses `false` for the "required" option unless a NotNull/NotBlank constraint is present.
    
    Commits
    -------
    
    fd77b09 [Form] Fixed ValidatorTypeGuesser to guess properties without constraints not to be required
    fabpot committed Sep 24, 2014