Permalink
Commits on Feb 26, 2017
  1. bug #21756 [Yaml] Stop replacing NULLs when merging (gadelat)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Yaml] Stop replacing NULLs when merging
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This introduces slight change of behaviour. Whereas previous code is overwriting already processed NULL values, this code is not. I think this is more expected behaviour, though?
    
    Commits
    -------
    
    d967440 [Yaml] Stop replacing NULLs when merging
    xabbuh committed Feb 26, 2017
Commits on Feb 25, 2017
  1. [Yaml] Stop replacing NULLs when merging

    gadelat committed with gadelat Feb 25, 2017
Commits on Feb 24, 2017
  1. minor #21744 Revamped the README file (javiereguiluz)

    This PR was squashed before being merged into the 2.7 branch (closes #21744).
    
    Discussion
    ----------
    
    Revamped the README file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21235
    | License       | MIT
    | Doc PR        |
    
    Here is a before/after comparison image:
    
    ![before-after-readme](https://cloud.githubusercontent.com/assets/73419/23294444/cb001e9a-fa6b-11e6-88f2-a8449470fb4e.png)
    
    Commits
    -------
    
    c7d30ca Revamped the README file
    fabpot committed Feb 24, 2017
  2. Revamped the README file

    javiereguiluz committed with fabpot Feb 23, 2017
Commits on Feb 23, 2017
  1. minor #21740 Fix missing namespace in test (chalasr)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fix missing namespace in test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Tests pass?   | yes
    
    Commits
    -------
    
    1e9ca7b Fix missing namespace in AddConstraintValidatorPassTest
    nicolas-grekas committed Feb 23, 2017
  2. Fix missing namespace in AddConstraintValidatorPassTest

    chalasr committed Feb 23, 2017
Commits on Feb 22, 2017
  1. bug #21722 [ExpressionLanguage] Registering functions after calling e…

    …valuate(), compile() or parse() is not supported (maidmaid)
    
    This PR was squashed before being merged into the 2.7 branch (closes #21722).
    
    Discussion
    ----------
    
    [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    If we add expr. function after first eval/compile like this:
    
    ```php
    $el = new ExpressionLanguage();
    $el->evaluate('1 + 1');
    $el->addFunction(new ExpressionFunction('fn', function () {}, function () {}));
    $el->evaluate('fn()');
    ```
    A ``SyntaxError`` is thrown that says ``The function "fn" does not exist around position 1.``. It's the same bug with ``$el->compile('fn()')``.
    
    This PR fixes this (duplicate of #21098 that was closed).
    
    Commits
    -------
    
    e305369 [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 22, 2017
  2. [ExpressionLanguage] Registering functions after calling evaluate(), …

    …compile() or parse() is not supported
    maidmaid committed with fabpot Dec 29, 2016
  3. bug #21679 [SecurityBundle] fix priority ordering of security voters …

    …(xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] fix priority ordering of security voters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21660
    | License       | MIT
    | Doc PR        |
    
    Could be updated in the `3.2` branch to make use of the `PriorityTaggedServiceTrait `.
    
    Commits
    -------
    
    dcd19f3 fix priority ordering of security voters
    fabpot committed Feb 22, 2017
Commits on Feb 21, 2017
  1. minor #21698 Use PHPUnit 6.0 on PHP 7.* test lines (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Use PHPUnit 6.0 on PHP 7.* test lines
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | need #21694 first
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    96ecd3c Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  2. Use PHPUnit 6.0 on PHP 7.* test lines

    nicolas-grekas committed Feb 21, 2017
  3. minor #21688 Further refactorings to PHPUnit namespaces (peterrehm)

    This PR was squashed before being merged into the 2.7 branch (closes #21688).
    
    Discussion
    ----------
    
    Further refactorings to PHPUnit namespaces
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Continued work to make Symfony PHPUnit 6 compatible
    
    Commits
    -------
    
    de8106f Further refactorings to PHPUnit namespaces
    nicolas-grekas committed Feb 21, 2017
Commits on Feb 20, 2017
  1. minor #21680 [FrameworkBundle] resolve parameters in definition class…

    …es (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] resolve parameters in definition classes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21637 (comment)
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    37ce682 resolve parameters in definition classes
    fabpot committed Feb 20, 2017
  2. minor #21684 Add missing conflict rules for phpunit (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Add missing conflict rules for phpunit
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    We forgot them in #21564
    
    Commits
    -------
    
    3e83e02 Add missing conflict rules for phpunit
    nicolas-grekas committed Feb 20, 2017
  3. Add missing conflict rules for phpunit

    nicolas-grekas committed Feb 20, 2017
  4. resolve parameters in definition classes

    xabbuh committed Feb 20, 2017
  5. fix priority ordering of security voters

    xabbuh committed Feb 20, 2017
Commits on Feb 19, 2017
  1. minor #21677 [Serializer] Removed duplicate operation in camelcase de…

    …normalization (gadelat)
    
    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21677).
    
    Discussion
    ----------
    
    [Serializer] Removed duplicate operation in camelcase denormalization
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    32fcd91 [Serializer] Removed duplicate operation in camelcase denormalization
    fabpot committed Feb 19, 2017
  2. bug #21115 [Validator] do not guess getter method names (xabbuh)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Validator] do not guess getter method names
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #5219, #18700
    | License       | MIT
    | Doc PR        | TODO
    
    Commits
    -------
    
    bd3a90a [Validator] do not guess getter method names
    fabpot committed Feb 19, 2017
Commits on Feb 18, 2017
  1. bug #21661 Fix Composer constraints (fabpot)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fix Composer constraints
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    245eaa8 fixed Composer constraints
    fabpot committed Feb 18, 2017
  2. fixed Composer constraints

    fabpot committed Feb 18, 2017
  3. minor fix

    nicolas-grekas committed Feb 18, 2017
  4. bug #21582 [HttpCache] purge both http and https from http cache (dbu)

    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21582).
    
    Discussion
    ----------
    
    [HttpCache] purge both http and https from http cache
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | => travis
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    The HTTP cache store of HttpCache respects the scheme for cache entries, which is the expected behaviour. however, Store::purge($url) also respects the scheme when invalidating the cache. This seems wrong to me.
    
    This PR is rather rough for now, and i did not even look at the tests. Do the maintainers agree with my assumption? Should it be a bugfix against 2.8? Any input on the code?
    
    Commits
    -------
    
    15da53c purge both http and https from http cache store
    fabpot committed Feb 18, 2017
  5. move conflict section of composer.json

    nicolas-grekas committed Feb 18, 2017
  6. minor #21564 Update to PHPUnit namespaces (peterrehm)

    This PR was squashed before being merged into the 2.7 branch (closes #21564).
    
    Discussion
    ----------
    
    Update to PHPUnit namespaces
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7+
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21534
    | License       | MIT
    | Doc PR        | -
    
    Replaces #21540
    
    @nicolas-grekas Is the update of the cache-id like this sufficient? Do we maybe have to specifiy 4.8.35 in simple-phpunit?
    
    Commits
    -------
    
    ddd2dff Update to PHPUnit namespaces
    fabpot committed Feb 18, 2017
  7. Update to PHPUnit namespaces

    peterrehm committed with fabpot Feb 8, 2017
Commits on Feb 17, 2017
  1. bug #21637 [FrameworkBundle] remove translation data collector when n…

    …ot usable (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] remove translation data collector when not usable
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #17957
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    303bb73 remove translation data collector when not usable
    fabpot committed Feb 17, 2017
Commits on Feb 16, 2017
  1. Revert "bug #21436 [DependencyInjection] check for circular refs caus…

    …ed by method calls (xabbuh)"
    
    This reverts commit 3441b15, reversing
    changes made to d1f4cb2.
    fabpot committed Feb 16, 2017
  2. minor #21537 Static code analysis with Php Inspections (EA Extended) …

    …(kalessil)
    
    This PR was squashed before being merged into the 2.7 branch (closes #21537).
    
    Discussion
    ----------
    
    Static code analysis with Php Inspections (EA Extended)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | --
    | License       | MIT
    | Doc PR        | --
    
    - Unnecessary proxy methods and methods duplicating  parents ones removed;
    - Type casings instead of PHP4 functions;
    - Usage of copy instead of file combining file get/put contents;
    - One time use variables cleaned up;
    - Superfluous functions calls in loop termination conditions fixed;
    
    Commits
    -------
    
    3feeca7 Static code analysis with Php Inspections (EA Extended)
    fabpot committed Feb 16, 2017
  3. remove translation data collector when not usable

    xabbuh committed Feb 16, 2017
  4. bug #21634 [VarDumper] Added missing persistent stream cast (lyrixx)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [VarDumper] Added missing persistent stream cast
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    cab9f7e [VarDumper] Added missing persistent stream cast
    fabpot committed Feb 16, 2017