Permalink
Commits on Sep 23, 2018
  1. bug #28545 [Console] Send the right exit code to console.terminate li…

    chalasr committed Sep 23, 2018
    …steners (mpdude)
    
    This PR was squashed before being merged into the 2.8 branch (closes #28545).
    
    Discussion
    ----------
    
    [Console] Send the right exit code to console.terminate listeners
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    When a Console command throws an exception without a status code, `Application::run()` takes care of setting the exit code to `1` when the exception does not provide a code itself.
    
    This happens slightly too late, as `console.terminate` event listeners that are called from within `Application::doRunCommand()` are given the plain exeception code, before this conversion.
    
    The result is that `console.*` event listeners that you might be using to log exit code e. g. for cron jobs will see a `0` code instead of the real value used to terminate the script.
    
    ***Todo:***
    
    - [x] Make sure we've got tests covering this, i. e. do not mock out `doRunCommand()`.
    
    Commits
    -------
    
    b90a3f1 [Console] Send the right exit code to console.terminate listeners
  2. [Console] Send the right exit code to console.terminate listeners

    mpdude authored and chalasr committed Sep 21, 2018
Commits on Sep 22, 2018
  1. bug #28466 [Form] fail reverse transforming invalid RFC 3339 dates (x…

    nicolas-grekas committed Sep 22, 2018
    …abbuh)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] fail reverse transforming invalid RFC 3339 dates
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28455
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    ee4ce43 fail reverse transforming invalid RFC 3339 dates
  2. bug #28540 [Intl] parse numbers terminated with decimal separator (xa…

    nicolas-grekas committed Sep 22, 2018
    …bbuh)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Intl] parse numbers terminated with decimal separator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28500
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    4225f36 parse numbers terminated with decimal separator
  3. bug #28548 [Console] Fixed boxed table style with colspan (ro0NL)

    nicolas-grekas committed Sep 22, 2018
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Console] Fixed boxed table style with colspan
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #28532
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Commits
    -------
    
    a67ff2a [Console] Fixed boxed table style with colspan
Commits on Sep 21, 2018
  1. [Console] Fixed boxed table style with colspan

    ro0NL committed Sep 21, 2018
  2. parse numbers terminated with decimal separator

    xabbuh committed Sep 21, 2018
  3. Fix CS

    nicolas-grekas committed Sep 21, 2018
  4. bug #28433 [HttpFoundation] Allow reuse of Session between requests i…

    nicolas-grekas committed Sep 21, 2018
    …f ID did not change (tgalopin)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Allow reuse of Session between requests if ID did not change
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13450
    | License       | MIT
    | Doc PR        | -
    
    I stumbled upon the issue from #13450 in a more simple case than what was exposed in the issue. From my understanding, the problem arises when the session is used between an access to the session and a functional test request: because the session was accessed (usually using the container directly), the session has started and the following request fails.
    
    This PR checks whether the ID was actually regenerated before throwing (if a setId is called with the same ID, it is the same request context, it shouldn't throw IMO).
    
    Not sure I understood everything correctly though, feel free to fix it for me if needed.
    
    Commits
    -------
    
    fd30f4a Allow reuse of Session between requests
  5. Allow reuse of Session between requests

    tgalopin committed Sep 10, 2018
Commits on Sep 20, 2018
  1. bug #28508 [Form] forward false label option to nested types (xabbuh)

    nicolas-grekas committed Sep 20, 2018
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] forward false label option to nested types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28469 (comment)
    | License       | MIT
    | Doc PR        |
    
    This change does not fix any built-in Symfony form themes, but takes
    into account the changes made in #28469 to allow third-party form themes
    work properly.
    
    Commits
    -------
    
    3247cde forward false label option to nested types
  2. bug #28464 [Form] forward the invalid_message option in date types (x…

    nicolas-grekas committed Sep 20, 2018
    …abbuh)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] forward the invalid_message option in date types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #5880
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    5318e2e forward the invalid_message option in date types
  3. minor #28506 [PhpUnitBridge] Provide debug_backtrace with proper args…

    nicolas-grekas committed Sep 20, 2018
    … (greg0ire)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] Provide debug_backtrace with proper args
    
    This would fail if we were using strict mode with php 7, because true is
    only a valid argument for php < 5.3.6.
    This was changed from PHP_VERSION_ID >= 50400 ?
    DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
     #18272, but I do not understand why it was simlified, nor why
    DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Not sure if this qualifies as a bugfix. If not, should I simplify the ternary and target master? My fear is that having the code diverge too much will make it harder to merge subsequent PRs. I know this looks small, but I'm kind of preparing a big PR on the bridge and I'd rather have it smaller and easier to understand by moving everything I can with small patches like this one.
    
    Commits
    -------
    
    0d826ae Provide debug_backtrace with proper args
Commits on Sep 19, 2018
  1. Provide debug_backtrace with proper args

    greg0ire committed Sep 18, 2018
    This would fail if we were using strict mode with php 7, because true is
    only a valid argument for php < 5.3.6.
    This was changed from PHP_VERSION_ID >= 50400 ?
    DEBUG_BACKTRACE_IGNORE_ARGS | DEBUG_BACKTRACE_PROVIDE_OBJECT : true in
     #18272, but I do not understand why it was simplified, nor why
    DEBUG_BACKTRACE_IGNORE_ARGS was there at that time.
  2. forward false label option to nested types

    xabbuh committed Sep 14, 2018
    This change does not fix any built-in Symfony form themes, but takes
    into account the changes made in #28469 to allow third-party form themes
    work properly.
Commits on Sep 18, 2018
  1. minor #28463 KernelInterface can return null for getContainer method …

    nicolas-grekas committed Sep 18, 2018
    …(gmponos)
    
    This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #28463).
    
    Discussion
    ----------
    
    KernelInterface can return null for getContainer method
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    According to [this](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Client.php#L45) a KernelInterface can return null if it is shutdown.
    
    Commits
    -------
    
    7cb340a KernelInterface can return null container
  2. KernelInterface can return null container

    gmponos authored and nicolas-grekas committed Sep 13, 2018
  3. bug #28499 [Ldap] Use shut up operator on connection errors at ldap_s…

    nicolas-grekas committed Sep 18, 2018
    …tart_tls (Andras Debreczeni)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Ldap] Use shut up operator on connection errors at ldap_start_tls
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28426
    | License       | MIT
    | Doc PR        | n/a
    
    Added shut-up operator to php function `ldap_start_tls()` so connection errors are ignored.
    
    Commits
    -------
    
    af54189 [Ldap] Use shut up operator on connection errors at ldap_start_tls
  4. [Ldap] Use shut up operator on connection errors at ldap_start_tls

    Andras Debreczeni
    Andras Debreczeni committed Sep 18, 2018
  5. minor #28483 [HttpFoundation] don't override StreamedResponse::setNot…

    fabpot committed Sep 18, 2018
    …Modified() (nicolas-grekas)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] don't override StreamedResponse::setNotModified()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Alternative implementation to #27937, because `Response::setNotModified()` has been made final in 4.0 so we shouldn't override it.
    
    Commits
    -------
    
    9ef7f70 [HttpFoundation] don't override StreamedResponse::setNotModified()
Commits on Sep 17, 2018
  1. bug #28372 [Form] Fix DateTimeType html5 input format (franzwilding, …

    nicolas-grekas committed Sep 17, 2018
    …mcfedr)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] Fix DateTimeType html5 input format
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #27233, #27254
    | License       | MIT
    | Doc PR        | N/A
    
    Fix DateTimeType' HTML input format according to HTML specs. Currently `DateTimeType` produces html with format `yyyy-MM-dd'T'HH:mm:ssZ` but the HTML5 spec expects `yyyy-MM-dd'T'HH:mm:ss` (i.e. no `Z`). Chrome presents an empty date picker meaning edits or having a default date are broken.
    
    Also the reverseTransform was expect to have a timezone attached, which it does not - and incorrectly marks it as being a UTC time in this case, instead of using the Transformers output TZ.
    
    This is same as @franzwilding #27254 but with change to just straight use of `DateTime::format` and handling TZ in reverseTransform
    
    Commits
    -------
    
    e21a1a4 Added relevent links for parsing to the phpdoc
    4f06f15 Add stricter checking for valid date time string
    253d0a6 [Form] Fix DateTimeType html5 input format
Commits on Sep 16, 2018
Commits on Sep 15, 2018
  1. Added relevent links for parsing to the phpdoc

    mcfedr committed Sep 15, 2018
  2. Add stricter checking for valid date time string

    mcfedr committed Sep 15, 2018
  3. minor #28472 [Validator] Add Japanese translations (issei-m)

    fabpot committed Sep 15, 2018
    This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #28472).
    
    Discussion
    ----------
    
    [Validator] Add Japanese translations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    7d78e36 [Validator] Add Japanese translations
  4. [Validator] Add Japanese translations

    issei-m authored and fabpot committed Sep 15, 2018
Commits on Sep 14, 2018
  1. fail reverse transforming invalid RFC 3339 dates

    xabbuh committed Sep 14, 2018
  2. forward the invalid_message option in date types

    xabbuh committed Sep 14, 2018
Commits on Sep 12, 2018
  1. minor #28448 [Console] Fix input values allowed types (chalasr)

    fabpot committed Sep 12, 2018
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Console] Fix input values allowed types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Continuation of #28374
    
    Commits
    -------
    
    0c16cd9 [Console] Fix input values allowed types
Commits on Sep 11, 2018
  1. [Console] Fix input values allowed types

    chalasr committed Sep 11, 2018
Commits on Sep 10, 2018
  1. minor #28409 [Console] Document what is validated before and after Co…

    chalasr committed Sep 10, 2018
    …mmand::initialize() (chalasr)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Console] Document what is validated before and after Command::initialize()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #26611
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    b1aff99 [Console] Correct Command::initialize() and InputInterface::bind() phpdoc regarding thrown exceptions
  2. bug #28396 [Intl] Blacklist Eurozone and United Nations in Region Dat…

    nicolas-grekas committed Sep 10, 2018
    …a Generator (gregurco)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Intl] Blacklist Eurozone and United Nations in Region Data Generator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28260
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    e2e4049 [Intl] Blacklist Eurozone and United Nations in Region Data Generator
  3. [Console] Correct Command::initialize() and InputInterface::bind() ph…

    chalasr committed Sep 8, 2018
    …pdoc regarding thrown exceptions
  4. bug #28393 [Console] fixed corrupt error output for unknown multibyte…

    chalasr committed Sep 10, 2018
    … short option (downace)
    
    This PR was squashed before being merged into the 2.8 branch (closes #28393).
    
    Discussion
    ----------
    
    [Console] fixed corrupt error output for unknown multibyte short option
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #28320   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    [Console] Fixed #28320 by using mb_substr instead of index access
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    0f86156 [Console] fixed corrupt error output for unknown multibyte short option
  5. [Console] fixed corrupt error output for unknown multibyte short option

    downace authored and chalasr committed Sep 7, 2018