Permalink
Commits on Feb 25, 2017
  1. bug #21689 [WebServerBundle] fixed html attribute escape (Seb33300)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [WebServerBundle] fixed html attribute escape
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    In the Web Debug Toolbar, when a toolbar item has extra attributes, they are not properly escaped.
    (If you put your mouse over the right toolbar item with sf version, you will see a tooltip with `""`)
    
    Currently:
    ```html
    title=""
    ```
    
    After:
    ```html
    title=""
    ```
    
    Commits
    -------
    
    1337cdb [WebServerBundle] fixed html attribute escape
    javiereguiluz committed Feb 25, 2017
Commits on Feb 24, 2017
  1. Merge branch '2.7' into 2.8

    * 2.7:
      Revamped the README file
      Fix missing namespace in AddConstraintValidatorPassTest
      [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 24, 2017
  2. minor #21744 Revamped the README file (javiereguiluz)

    This PR was squashed before being merged into the 2.7 branch (closes #21744).
    
    Discussion
    ----------
    
    Revamped the README file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21235
    | License       | MIT
    | Doc PR        |
    
    Here is a before/after comparison image:
    
    ![before-after-readme](https://cloud.githubusercontent.com/assets/73419/23294444/cb001e9a-fa6b-11e6-88f2-a8449470fb4e.png)
    
    Commits
    -------
    
    c7d30ca Revamped the README file
    fabpot committed Feb 24, 2017
  3. Revamped the README file

    javiereguiluz committed with fabpot Feb 23, 2017
Commits on Feb 23, 2017
  1. minor #21740 Fix missing namespace in test (chalasr)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fix missing namespace in test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Tests pass?   | yes
    
    Commits
    -------
    
    1e9ca7b Fix missing namespace in AddConstraintValidatorPassTest
    nicolas-grekas committed Feb 23, 2017
  2. Fix missing namespace in AddConstraintValidatorPassTest

    chalasr committed Feb 23, 2017
Commits on Feb 22, 2017
  1. bug #21722 [ExpressionLanguage] Registering functions after calling e…

    …valuate(), compile() or parse() is not supported (maidmaid)
    
    This PR was squashed before being merged into the 2.7 branch (closes #21722).
    
    Discussion
    ----------
    
    [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    If we add expr. function after first eval/compile like this:
    
    ```php
    $el = new ExpressionLanguage();
    $el->evaluate('1 + 1');
    $el->addFunction(new ExpressionFunction('fn', function () {}, function () {}));
    $el->evaluate('fn()');
    ```
    A ``SyntaxError`` is thrown that says ``The function "fn" does not exist around position 1.``. It's the same bug with ``$el->compile('fn()')``.
    
    This PR fixes this (duplicate of #21098 that was closed).
    
    Commits
    -------
    
    e305369 [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 22, 2017
  2. [ExpressionLanguage] Registering functions after calling evaluate(), …

    …compile() or parse() is not supported
    maidmaid committed with fabpot Dec 29, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  4. bug #21679 [SecurityBundle] fix priority ordering of security voters …

    …(xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] fix priority ordering of security voters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21660
    | License       | MIT
    | Doc PR        |
    
    Could be updated in the `3.2` branch to make use of the `PriorityTaggedServiceTrait `.
    
    Commits
    -------
    
    dcd19f3 fix priority ordering of security voters
    fabpot committed Feb 22, 2017
Commits on Feb 21, 2017
  1. fix deps

    nicolas-grekas committed Feb 21, 2017
  2. Merge branch '2.7' into 2.8

    * 2.7:
      Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  3. minor #21698 Use PHPUnit 6.0 on PHP 7.* test lines (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Use PHPUnit 6.0 on PHP 7.* test lines
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | need #21694 first
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    96ecd3c Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  4. Use PHPUnit 6.0 on PHP 7.* test lines

    nicolas-grekas committed Feb 21, 2017
  5. minor #21695 Refactored other PHPUnit method calls to work with names…

    …paced PHPUnit 6 (peterrehm)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Continued work to make Symfony PHPUnit 6 compatible.
    
    Commits
    -------
    
    dbe8898 Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    nicolas-grekas committed Feb 21, 2017
  6. Refactored other PHPUnit method calls to work with namespaced PHPUnit 6

    peterrehm committed Feb 21, 2017
  7. Merge branch '2.7' into 2.8

    * 2.7:
      Further refactorings to PHPUnit namespaces
      resolve parameters in definition classes
    nicolas-grekas committed Feb 21, 2017
  8. minor #21688 Further refactorings to PHPUnit namespaces (peterrehm)

    This PR was squashed before being merged into the 2.7 branch (closes #21688).
    
    Discussion
    ----------
    
    Further refactorings to PHPUnit namespaces
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Continued work to make Symfony PHPUnit 6 compatible
    
    Commits
    -------
    
    de8106f Further refactorings to PHPUnit namespaces
    nicolas-grekas committed Feb 21, 2017
Commits on Feb 20, 2017
  1. minor #21680 [FrameworkBundle] resolve parameters in definition class…

    …es (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] resolve parameters in definition classes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21637 (comment)
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    37ce682 resolve parameters in definition classes
    fabpot committed Feb 20, 2017
  2. [WebServerBundle] fixed html attribute escape

    Seb33300 committed on GitHub Feb 20, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Add missing conflict rules for phpunit
    nicolas-grekas committed Feb 20, 2017
  4. minor #21684 Add missing conflict rules for phpunit (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Add missing conflict rules for phpunit
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    We forgot them in #21564
    
    Commits
    -------
    
    3e83e02 Add missing conflict rules for phpunit
    nicolas-grekas committed Feb 20, 2017
  5. Add missing conflict rules for phpunit

    nicolas-grekas committed Feb 20, 2017
  6. minor #21663 Updated PHPUnit namespaces (peterrehm)

    This PR was squashed before being merged into the 2.8 branch (closes #21663).
    
    Discussion
    ----------
    
    Updated PHPUnit namespaces
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Follow Up of #21564
    
    Commits
    -------
    
    205ced4 Updated PHPUnit namespaces
    nicolas-grekas committed Feb 20, 2017
  7. resolve parameters in definition classes

    xabbuh committed Feb 20, 2017
  8. fix priority ordering of security voters

    xabbuh committed Feb 20, 2017
  9. Merge branch '2.7' into 2.8

    * 2.7:
      [Serializer] Removed duplicate operation in camelcase denormalization
      [Validator] do not guess getter method names
    fabpot committed Feb 20, 2017
Commits on Feb 19, 2017
  1. minor #21677 [Serializer] Removed duplicate operation in camelcase de…

    …normalization (gadelat)
    
    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21677).
    
    Discussion
    ----------
    
    [Serializer] Removed duplicate operation in camelcase denormalization
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    32fcd91 [Serializer] Removed duplicate operation in camelcase denormalization
    fabpot committed Feb 19, 2017
  2. bug #21115 [Validator] do not guess getter method names (xabbuh)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Validator] do not guess getter method names
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #5219, #18700
    | License       | MIT
    | Doc PR        | TODO
    
    Commits
    -------
    
    bd3a90a [Validator] do not guess getter method names
    fabpot committed Feb 19, 2017
  3. bug #21670 [DependencyInjection] Fix autowiring types when there are …

    …more than 2 services colliding (GuilhemN)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Fix autowiring types when there are more than 2 services colliding
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    There is a bug in the `AutowirePass`, when using more than 2 services colliding and you want to use the autowiring types: it may not work depending on their order because `notGuessableTypes` is not reset.
    
    Commits
    -------
    
    5981278 [DependencyInjection] Fix using autowiring types when there are more than 2 services
    fabpot committed Feb 19, 2017
  4. bug #21665 [DependencyInjection] Fix autowiring collisions detection …

    …(nicolas-grekas, GuilhemN)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Fix autowiring collisions detection
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        |
    
    Fixes #21658 by implementing the second proposal of #21658 (comment):
    > Another idea: store the types used previously and check that new services registered don't implement them.
    
    Commits
    -------
    
    bb70472 [DependencyInjection] Fix autowiring collisions detection
    6f578ee [DI] Bug in autowiring collisions detection
    fabpot committed Feb 19, 2017
  5. [DependencyInjection] Fix using autowiring types when there are more …

    …than 2 services
    GuilhemN committed Feb 19, 2017