Skip to content
Permalink
Branch: 3.1
Commits on Jan 28, 2017
  1. Merge pull request #21441 from fabpot/release-3.1.10

    fabpot committed Jan 28, 2017
    released v3.1.10
  2. updated VERSION for 3.1.10

    fabpot committed Jan 28, 2017
  3. update CONTRIBUTORS for 3.1.10

    fabpot committed Jan 28, 2017
  4. updated CHANGELOG for 3.1.10

    fabpot committed Jan 28, 2017
  5. fixed composer dep

    fabpot committed Jan 28, 2017
  6. fixed typo

    fabpot committed Jan 28, 2017
  7. Merge branch '2.8' into 3.1

    fabpot committed Jan 28, 2017
    * 2.8:
      fixed composer.json
  8. fixed composer.json

    fabpot committed Jan 28, 2017
  9. Merge branch '2.8' into 3.1

    fabpot committed Jan 28, 2017
    * 2.8:
      always check for all fields to be mapped
      clarify exception when no args are configured
      [PropertyAccess] Handle interfaces in the invalid argument exception
      [DI] Fix defaults overriding empty strings in AutowirePass
      [Debug] Workaround "null" $context
      [Debug] Remove $context arg from handleError(), preparing for PHP 7.2
      [Routing] Fix BC break in AnnotationClassLoader defaults attributes handling
      Fix tests with ICU 57.1
      Fix the condition checking the minimum ICU version
Commits on Jan 27, 2017
  1. Merge branch '2.7' into 2.8

    fabpot committed Jan 27, 2017
    * 2.7:
      always check for all fields to be mapped
      clarify exception when no args are configured
      [PropertyAccess] Handle interfaces in the invalid argument exception
      [Debug] Workaround "null" $context
      [Debug] Remove $context arg from handleError(), preparing for PHP 7.2
      [Routing] Fix BC break in AnnotationClassLoader defaults attributes handling
      Fix tests with ICU 57.1
      Fix the condition checking the minimum ICU version
  2. bug #21431 [DoctrineBridge] always check for all fields to be mapped …

    fabpot committed Jan 27, 2017
    …(xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DoctrineBridge] always check for all fields to be mapped
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #16791
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    1e3421d always check for all fields to be mapped
  3. always check for all fields to be mapped

    xabbuh committed Jan 27, 2017
Commits on Jan 26, 2017
  1. minor #21416 [DependencyInjection] clarify exception when no args are…

    fabpot committed Jan 26, 2017
    … configured (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] clarify exception when no args are configured
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21412
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    428814b clarify exception when no args are configured
  2. clarify exception when no args are configured

    xabbuh committed Jan 26, 2017
Commits on Jan 25, 2017
  1. bug #21360 [PropertyAccess] Handle interfaces in the invalid argument…

    fabpot committed Jan 25, 2017
    … exception (fancyweb)
    
    This PR was squashed before being merged into the 2.7 branch (closes #21360).
    
    Discussion
    ----------
    
    [PropertyAccess] Handle interfaces in the invalid argument exception
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Before :
    `Expected argument of type "dule\MenuBundle\Entity\AbstractMenu::setMenuElements() must implement interface Doctrine\Common\Collections\Collection", "array" given`
    
    After :
    `Expected argument of type "Doctrine\Common\Collections\Collection", "array" given`
    
    Commits
    -------
    
    be52b39 [PropertyAccess] Handle interfaces in the invalid argument exception
  2. bug #21403 [DI] Fix defaults overriding empty strings in AutowirePass…

    fabpot committed Jan 25, 2017
    … (nicolas-grekas)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [DI] Fix defaults overriding empty strings in AutowirePass
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    89e2724 [DI] Fix defaults overriding empty strings in AutowirePass
  3. bug #21401 [Debug] Workaround "null" $context (nicolas-grekas)

    fabpot committed Jan 25, 2017
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Debug] Workaround "null" $context
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    As reported in #20068, the imap extension can call error handlers with $context = null.
    
    Commits
    -------
    
    2555f31 [Debug] Workaround "null" $context
  4. [DI] Fix defaults overriding empty strings in AutowirePass

    nicolas-grekas committed Jan 25, 2017
  5. [Debug] Workaround "null" $context

    nicolas-grekas committed Jan 25, 2017
Commits on Jan 24, 2017
  1. minor #21379 [Routing] Fix BC break in AnnotationClassLoader defaults…

    fabpot committed Jan 24, 2017
    … attributes handling (chalasr)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Routing] Fix BC break in AnnotationClassLoader defaults attributes handling
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | 77289b9#commitcomment-20572462
    | License       | MIT
    | Doc PR        | n/a
    
    This fixes a BC break introduced in #21333. Instead of removing the automatic request attributes creation, we keep it but only for attributes that are mandatory (i.e. present in the route path).
    
    Thanks to @iltar for the idea.
    
    Commits
    -------
    
    1d298f0 [Routing] Fix BC break in AnnotationClassLoader defaults attributes handling
  2. minor #21320 Fix ICU dependant tests (jakzal)

    fabpot committed Jan 24, 2017
    This PR was squashed before being merged into the 2.7 branch (closes #21320).
    
    Discussion
    ----------
    
    Fix ICU dependant tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    #20551 changed the condition checking if the ICU version matches the stubbed data. The change intended to enable tests on more ICU versions, but it actually has limited them. I'm still not convinced it should've been done but let's at least fix the condition. Ideal solution would be to have the latest ICU data available on travis (still not there travis-ci/travis-ci#3616).
    
    I also needed to fix several tests.
    
    Currently skipped tests in components depending on ICU data:
    
    |            | 4.8.1.1 | 54.1 | 55.1 | 57.1 |
    |---|---|--|--|--|
    | Intl       | 488     | 488  | 7    | 6    |
    | Locale     | 0       | 0    | 0    | 0    |
    | Translation| 0       | 0    | 0    | 0    |
    | Validator  | 69      | 69   | 69   | 0    |
    | Form       | 75      | 75   | 75   | 1    |
    
    Commits
    -------
    
    d3b5d8e Fix tests with ICU 57.1
    677d820 Fix the condition checking the minimum ICU version
  3. minor #21389 [Debug] Remove $context arg from handleError(), preparin…

    fabpot committed Jan 24, 2017
    …g for PHP 7.2 (nicolas-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Debug] Remove $context arg from handleError(), preparing for PHP 7.2
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    PHP 7.2 will trigger deprecation notices.
    See https://wiki.php.net/rfc/deprecations_php_7_2#errcontext_argument_of_error_handler
    
    Commits
    -------
    
    83cad14 [Debug] Remove $context arg from handleError(), preparing for PHP 7.2
  4. Merge branch '2.8' into 3.1

    nicolas-grekas committed Jan 24, 2017
    * 2.8:
      fix test
  5. fix test

    nicolas-grekas committed Jan 24, 2017
  6. minor #21309 [Serializer] Add missing conflict for property-info<3.1 …

    nicolas-grekas committed Jan 24, 2017
    …(chalasr)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Serializer] Add missing conflict for property-info<3.1
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21293 (comment)
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    60a0c4b [Serializer] Add missing conflict for property-info<3.1
Commits on Jan 23, 2017
  1. [Routing] Fix BC break in AnnotationClassLoader defaults attributes h…

    chalasr committed Jan 23, 2017
    …andling
  2. Merge branch '2.8' into 3.1

    nicolas-grekas committed Jan 23, 2017
    * 2.8:
      update German translation
      [Validator] Improved error message for missing upload_tmp_dir
  3. Merge branch '2.7' into 2.8

    nicolas-grekas committed Jan 23, 2017
    * 2.7:
      update German translation
      [Validator] Improved error message for missing upload_tmp_dir
  4. fix getMock usage

    nicolas-grekas committed Jan 23, 2017
Commits on Jan 22, 2017
  1. bug #21372 [DependencyInjection] Fixed variadic method parameter in a…

    fabpot committed Jan 22, 2017
    …utowired classes (brainexe)
    
    This PR was squashed before being merged into the 3.1 branch (closes #21372).
    
    Discussion
    ----------
    
    [DependencyInjection] Fixed variadic method parameter in autowired classes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | --
    | License       | MIT
    
    Autowiring classes containing methods with variadic method parameter throws a ReflectionException in compile process:
    
    ```
    PHP Fatal error:  Uncaught ReflectionException: Internal error: Failed to retrieve the default value in /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php:437
    Stack trace:
    #0 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(437): ReflectionParameter->getDefaultValue()
    #1 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(80): Symfony\Component\DependencyInjection\Compiler\AutowirePass::getResourceMetadataForMethod(Object(ReflectionMethod))
    #2 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(105): Symfony\Component\DependencyInjection\Compiler\AutowirePass::createResourceForClass(Object(ReflectionClass))
    #3 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(48): Symfony\Component\DependencyInjection\Compiler\AutowirePass->completeDefinition('__controller.Sw...', Object(Symfony\Component\DependencyInjection\Definition), Array)
    #4 /.../vendor/symfony/dependency-injection/Compiler/Compiler in /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php on line 437
    ```
    
    **Example:**
    ```
    <?php
    class FooVariadic
    {
        public function bar(...$arguments)
        {
        }
    }
    
    $method = new ReflectionMethod(FooVariadic::class, 'bar');
    $parameter = $method->getParameters()[0];
    $parameter->getDefaultValue(); // -> ReflectionException: Internal error: Failed to retrieve the default value in ...
    ```
    
    Commits
    -------
    
    a7f63de [DependencyInjection] Fixed variadic method parameter in autowired classes
  2. minor #21371 [Validator] update German translation (xabbuh)

    fabpot committed Jan 22, 2017
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Validator] update German translation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    f920e61 update German translation
  3. update German translation

    xabbuh committed Jan 22, 2017
Older
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.