Skip to content
Permalink
Branch: 3.2
Commits on Nov 16, 2017
  1. Merge pull request #25001 from fabpot/release-3.2.14

    fabpot committed Nov 16, 2017
    released v3.2.14
  2. updated CHANGELOG for 3.2.14

    fabpot committed Nov 16, 2017
  3. fix deps=low

    nicolas-grekas committed Nov 16, 2017
  4. fixed CS

    fabpot authored and nicolas-grekas committed Nov 16, 2017
  5. fixed CS

    fabpot authored and nicolas-grekas committed Nov 16, 2017
Commits on Aug 1, 2017
  1. Merge pull request #23736 from fabpot/release-3.2.13

    fabpot committed Aug 1, 2017
    released v3.2.13
  2. updated VERSION for 3.2.13

    fabpot committed Aug 1, 2017
  3. updated CHANGELOG for 3.2.13

    fabpot committed Aug 1, 2017
Commits on Jul 29, 2017
  1. Merge branch '2.8' into 3.2

    nicolas-grekas committed Jul 29, 2017
    * 2.8:
      Remove unused constant
      Fix passing options with defaultCommand
  2. Merge branch '2.7' into 2.8

    nicolas-grekas committed Jul 29, 2017
    * 2.7:
      Remove unused constant
      Fix passing options with defaultCommand
  3. bug #22244 [Console] Fix passing options with defaultCommand (Jakub S…

    fabpot committed Jul 29, 2017
    …acha)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Console] Fix passing options with defaultCommand
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Seems like overwriting input for the default command is not needed (anymore?). I don't know where the removed comment comes from originally.
    
    Use case: i want to call default command and use options at the same time:
    app/console --abc=true
    
    Commits
    -------
    
    761de99 Fix passing options with defaultCommand
Commits on Jul 28, 2017
  1. minor #23704 Remove unused constant (AbdElKader Bouadjadja)

    chalasr committed Jul 28, 2017
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Remove unused constant
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    Just a micro clean-up PR, to assimilate the Symfony PR process.
    Hope the next one will be more useful 🤔
    
    Commits
    -------
    
    7168d89 Remove unused constant
  2. Remove unused constant

    AbdElKader Bouadjadja
    AbdElKader Bouadjadja committed Jul 28, 2017
  3. fix merge

    nicolas-grekas committed Jul 28, 2017
  4. Merge branch '2.8' into 3.2

    nicolas-grekas committed Jul 28, 2017
    * 2.8:
      [DI] Remove unused props from the PhpDumper
      [ProxyManager] Cleanup fixtures
      [Debug] HTML-escape array key
      Add some phpdocs for IDE autocompletion and better SCA
      Fixed typo in docblock
  5. Merge branch '2.7' into 2.8

    nicolas-grekas committed Jul 28, 2017
    * 2.7:
      [DI] Remove unused props from the PhpDumper
      [ProxyManager] Cleanup fixtures
      [Debug] HTML-escape array key
      Add some phpdocs for IDE autocompletion and better SCA
  6. minor #23590 Fixed typo in docblock in AuthenticationExpiredException…

    nicolas-grekas committed Jul 28, 2017
    … (iltar)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Fixed typo in docblock in AuthenticationExpiredException
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Found a small typo, applied it in the lowest branch possible.
    
    Commits
    -------
    
    432d2de Fixed typo in docblock
  7. minor #23613 [DI] Remove unused props from the PhpDumper (dunglas)

    nicolas-grekas committed Jul 28, 2017
    This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #23613).
    
    Discussion
    ----------
    
    [DI] Remove unused props from the PhpDumper
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
    | BC breaks?    | no
    | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    f1aa45c [DI] Remove unused props from the PhpDumper
  8. minor #23689 [ProxyManager] Cleanup fixtures (nicolas-grekas)

    fabpot committed Jul 28, 2017
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [ProxyManager] Cleanup fixtures
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Just noticed that these fixture files are not maintainable. And we don't need them at all in fact, let's drop them.
    
    Commits
    -------
    
    31843d6 [ProxyManager] Cleanup fixtures
Commits on Jul 27, 2017
  1. [ProxyManager] Cleanup fixtures

    nicolas-grekas committed Jul 27, 2017
  2. minor #23633 [Form] Add some phpdocs for IDE autocompletion and bette…

    fabpot committed Jul 27, 2017
    …r SCA (Koc)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Form] Add some phpdocs for IDE autocompletion and better SCA
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    @ogizanagi I've tryed add single phpdoc `@method FormInterface[] getIterator()` to `FormInterface` but it not works correctly in PHPStorm. Have you any ideas?
    
    <!--
    - Bug fixes must be submitted against the lowest branch where they apply
      (lowest branches are regularly merged to upper ones so they get the fixes too).
    - Features and deprecations must be submitted against the 3.4,
      legacy code removals go to the master branch.
    - Please fill in this template according to the PR you're about to submit.
    - Replace this comment by a description of what your PR is solving.
    -->
    
    Commits
    -------
    
    d30c751 Add some phpdocs for IDE autocompletion and better SCA
Commits on Jul 26, 2017
  1. bug #23684 [Debug] Missing escape in debug output (c960657)

    nicolas-grekas committed Jul 26, 2017
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Debug] Missing escape in debug output
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    When pretty-printing an exception, the debug handler does not properly escape array keys.
    
    The problem only occurs when debug output is enabled, so this is not considered a [security issue](http://symfony.com/doc/current/contributing/code/security.html) (according to @fabpot), because the debug tools [should not be used in production](https://symfony.com/doc/current/components/debug.html#usage).
    
    A test for this is included in my patch for #18722.
    
    Commits
    -------
    
    636777d [Debug] HTML-escape array key
  2. [Debug] HTML-escape array key

    c960657 committed Jul 26, 2017
  3. Merge branch '2.8' into 3.2

    nicolas-grekas committed Jul 26, 2017
    * 2.8:
      [DI] Make dumped docblocks less verbose
  4. Merge branch '2.7' into 2.8

    nicolas-grekas committed Jul 26, 2017
    * 2.7:
      [DI] Make dumped docblocks less verbose
  5. minor #23673 [DI] Make dumped docblocks less verbose (nicolas-grekas)

    fabpot committed Jul 26, 2017
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DI] Make dumped docblocks less verbose
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    When I open a dumped container, I always find there are too much noise in docblocs.
    As a bonus side effect, this will reduce the memory requirement in dev :)
    
    Commits
    -------
    
    1ade5d8 [DI] Make dumped docblocks less verbose
  6. [DI] Make dumped docblocks less verbose

    nicolas-grekas committed Jul 26, 2017
  7. Merge branch '2.8' into 3.2

    nicolas-grekas committed Jul 26, 2017
    * 2.8:
      [DI] use assertStringEqualsFile when possible
      [VarDumper] Adapt to php 7.2 changes
      [Form][TwigBridge] Don't render _method in form_rest() for a child form
      [DoctrineBridge][PropertyInfo] Added support for Doctrine Embeddables
      [Validator] Fix IbanValidator for ukrainian IBANs
  8. Merge branch '2.7' into 2.8

    nicolas-grekas committed Jul 26, 2017
    * 2.7:
      [DI] use assertStringEqualsFile when possible
      [VarDumper] Adapt to php 7.2 changes
      [Form][TwigBridge] Don't render _method in form_rest() for a child form
      [Validator] Fix IbanValidator for ukrainian IBANs
  9. minor #23670 [DI] use assertStringEqualsFile when possible (nicolas-g…

    nicolas-grekas committed Jul 26, 2017
    …rekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [DI] use assertStringEqualsFile when possible
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    To make failure reporting more accurate, and maintaining tests easier (assertStringEqualsFile is already heavily used in the same file.)
    
    Commits
    -------
    
    eebae7e [DI] use assertStringEqualsFile when possible
Older
You can’t perform that action at this time.