Skip to content
Permalink
Branch: 3.4
Commits on Mar 22, 2019
  1. bug #30640 [Phpunit] fixed support for PHP 5.3 (fabpot)

    fabpot committed Mar 22, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Phpunit] fixed support for PHP 5.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Compat with PHP 5.3 was broken by #30496
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    606b8af [Phpunit] fixed support for PHP 5.3
  2. [Phpunit] fixed support for PHP 5.3

    fabpot committed Mar 22, 2019
  3. minor #30633 Response prepare method update for more coherence (Damie…

    fabpot committed Mar 22, 2019
    …nVauchel)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Response prepare method update for more coherence
    
    $headers has been defined to avoid using $this->headers and is used everywhere but not in these lines.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    Commits
    -------
    
    e89c921 Response prepare method update
Commits on Mar 21, 2019
  1. Response prepare method update

    DamienVauchel committed Mar 21, 2019
    Response prepare updated for more coherence.
Commits on Mar 20, 2019
  1. minor #30618 [Workflow] Added missing license header (lyrixx)

    fabpot committed Mar 20, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Workflow] Added missing license header
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    e78a13f [Workflow] Added missing license header
  2. [Workflow] Added missing license header

    lyrixx committed Mar 20, 2019
  3. bug #30595 Do not validate child constraints if form has no validatio…

    fabpot committed Mar 20, 2019
    …n groups (maryo)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Do not validate child constraints if form has no validation groups
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    If a form has `Valid` constraint and `validation_groups` set to an empty array (to disable validation) then its children were still validated using default validation group because `FormValidator` validated the form data using the empty array validation group here
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php#L76
    
    and then `RecursiveContextualValidator` treats the empty array as default validation group here.
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php#L86
    
    Commits
    -------
    
    f45f0d0 [Form] Preventing validation of children if parent with Valid constraint has no validation groups
  4. bug #30479 Check if Client exists when test.client does not exist, to…

    fabpot committed Mar 20, 2019
    … provide clearer exception message (SerkanYildiz)
    
    This PR was squashed before being merged into the 3.4 branch (closes #30479).
    
    Discussion
    ----------
    
    Check if Client exists when test.client does not exist, to provide clearer exception message
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30420
    | License       | MIT
    
    The `DotEnv` component does not overwrite by using environment variables declared in `.env` files.
    
    In the `FrameworkExtension` will be checked if the framework.test config is set to a non-false value, if so it will load the `test.xml` file which contains the definition for the `test.client` service.
    
    When running `php bin/phpunit` it will use `phpunit.xml.dist` but because we defined `APP_ENV` in our system it will not load `test.xml` so when creating a client to do functional tests, we'll get an exception which isn't correct: `You cannot create the client used in functional tests if the BrowserKit component is not available. Try running "composer require symfony/browser-kit"`
    
    This PR aims to add a clearer exception message which indicates what really should be done to fix the error message.
    
    Commits
    -------
    
    b429950 Check if Client exists when test.client does not exist, to provide clearer exception message
  5. Check if Client exists when test.client does not exist, to provide cl…

    SerkanYildiz authored and fabpot committed Mar 7, 2019
    …earer exception message
Commits on Mar 19, 2019
  1. [Form] Preventing validation of children if parent with Valid constra…

    maryo committed Mar 18, 2019
    …int has no validation groups
  2. minor #30596 [Tests] fixed compatbility of assertEquals(): void (Heah…

    fabpot committed Mar 19, 2019
    …Dude)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Tests] fixed compatbility of assertEquals(): void
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Same as #30474.
    
    Commits
    -------
    
    3f7bedc [Tests] fixed compatbility of assertEquals(): void
  3. [Tests] fixed compatbility of assertEquals(): void

    HeahDude committed Mar 18, 2019
Commits on Mar 17, 2019
  1. minor #30587 [Intl] Fix test (ro0NL)

    fabpot committed Mar 17, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Fix test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Creates some weird path, that breaks the next tests.
    
    Commits
    -------
    
    226f522 [Intl] Fix test
  2. [Intl] Fix test

    ro0NL committed Mar 17, 2019
  3. minor #30534 [Form] Fixed some phpdocs (Jules Pietri)

    fabpot committed Mar 17, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] Fixed some phpdocs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#6393
    
    ref symfony/symfony-docs#6144, symfony/symfony-docs#6297, #14050
    
    Commits
    -------
    
    b9162e8 [Form] Fixed some phpdocs
  4. feature #30584 [Intl] Add compile binary (ro0NL)

    fabpot committed Mar 17, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Add compile binary
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no-ish
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from #28831)
    
    ```bash
    $ src/Symfony/Component/Intl/Resources/bin/compile
    ```
    
    run in repository root because of
    
    https://github.com/symfony/symfony/blob/b7e798ef745a09ca2e76fba4afad0a04fcbd9195/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php#L141
    
    3.4 is ok, 4.2 is not because of #28833 but new locales are introduced in https://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1
    
    So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run `compile` (potential for automating, but run if needed :))
    
    Commits
    -------
    
    426b92f [Intl] Add compile binary
  5. minor #30585 [Validator] Add the missing translations for the Arabic …

    fabpot committed Mar 17, 2019
    …(ar) locale (mehdimabrouk)
    
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #30585).
    
    Discussion
    ----------
    
    [Validator] Add the missing translations for the Arabic (ar) locale
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | ?    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | none <!-- required for new features -->
    
    This pull request is for adding missing translations in validators.ar.xlf.
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    5df08d6 [Validator] Add the missing translations for the Arabic (ar) locale
  6. [Validator] Add the missing translations for the Arabic (ar) locale

    mehdimabrouk authored and fabpot committed Mar 17, 2019
Commits on Mar 16, 2019
  1. [Intl] Add compile binary

    ro0NL committed Mar 16, 2019
Commits on Mar 15, 2019
  1. bug #30487 Fix Cache error while using anonymous class (Emmanuel BORGES)

    nicolas-grekas committed Mar 15, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix Cache error while using anonymous class
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30395
    | License       | MIT
    
    Fix Cache error while using anonymous class
    
    Commits
    -------
    
    036e722 Fix Cache error while using anonymous class
  2. Fix Cache error while using anonymous class

    Emmanuel BORGES authored and nicolas-grekas committed Mar 8, 2019
Commits on Mar 14, 2019
  1. minor #30566 [Validator] Add the missing translations for the Czech (…

    fabpot committed Mar 14, 2019
    …"cs") locale (dfridrich)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Validator] Add the missing translations for the Czech ("cs") locale
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30153
    | License       | MIT
    | Doc PR        |
    
    Add the missing translations for the Czech ("cs") locale to Validator.
    
    Commits
    -------
    
    5f49e6c Update validators.cs.xlf
  2. Update validators.cs.xlf

    dfridrich committed Mar 14, 2019
Commits on Mar 13, 2019
  1. bug #30548 Correct language code for ukrainian language (stanleyk)

    nicolas-grekas committed Mar 13, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Correct language code for ukrainian language
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Correct language code for [ukrainian language](https://en.wikipedia.org/wiki/Ukrainian_language) is **uk**, not **ua**. Similar bug was earlier addressed in #5972, but somehow it appeared here again. Possible BC break in case someone relies on "ua" version being present, but I think that is a minor problem.
    
    Commits
    -------
    
    b86fa93 Correct language code for ukrainian language in security translations.
  2. minor #30550 [Validator] Improve Bulgarian translations. (moynzzz)

    nicolas-grekas committed Mar 13, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Validator] Improve Bulgarian translations.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | none <!-- required for new features -->
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    This pull request is an improvement on top of #30227 and improves translations in the following ways:
    
    - Make consistent how `This` word is translated.
    - Make consistent how `This value` is translated.
    - Fix capitalization rules for abbreviations.
    - Change `email` to `имейл` (this is a word in the official Bulgarian dictionary).
    - Removes unnecessary words in brackets.
    
    Feel free to comment and criticize I'm not a professional translator.
    
    Commits
    -------
    
    d15c76c Make translations consistent with other translations.
  3. bug #30518 [Cache] Fix perf when using RedisCluster by reducing round…

    nicolas-grekas committed Mar 13, 2019
    …trips to the servers (nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    This is slimmed down version of: #28269 _(many of the fixes there are already part of 3.4)_
    
    Does:
    - Adds test coverage for Predis with RedisCluster
    - Removes usage of key versioning when on RedisCluster, besides performance aspect of that it simplifies / aligning clear() handling across all clients
    - reuse doDelete() from clear to make sure we call singular del calls when in predis cluster
    
    Commits
    -------
    
    dacf179 [Cache] Fix perf when using RedisCluster by reducing roundtrips to the servers
  4. minor #30535 Fix return type of Request::getRequestFormat (teohhanhui)

    nicolas-grekas committed Mar 13, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix return type of Request::getRequestFormat
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    Helps static analysis tools get the correct type.
    
    Commits
    -------
    
    bd92349 Fix return type of Request::getRequestFormat
  5. Make translations consistent with other translations.

    moynzzz committed Mar 13, 2019
  6. Correct language code for ukrainian language

    stanleyk committed Mar 13, 2019
    in security translations.
Commits on Mar 12, 2019
  1. Fix return type of Request::getRequestFormat

    teohhanhui committed Mar 12, 2019
  2. [Form] Fixed some phpdocs

    Jules Pietri
    Jules Pietri committed Mar 12, 2019
Commits on Mar 11, 2019
  1. [Cache] Fix perf when using RedisCluster by reducing roundtrips to th…

    nicolas-grekas authored and andrerom committed Aug 26, 2018
    …e servers
    
    This is slimmed down version of: #28269 _(many of the fixes here are already part of 3.4)_
    
    Adds:
    - Test coverage for Predis with RedisCluster
    - Removes usage of key versioning when on RedisCluster, besides performance aspect of that simplify / aligning clear() handling across cases
  2. bug #30515 [Cache] Only delete one key at a time when on Predis + Clu…

    nicolas-grekas committed Mar 11, 2019
    …ster (andrerom)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Cache] Only delete one key at a time when on Predis + Cluster
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    Makes sure deletes when on Predis  Cluster is only done one by one as it's not able to send the keys to right cluster node like RedisCluster can.
    
    _This is backport of logic from 4.x to fix this. With one tweak; make sure to only do this when on cluster so not all Predis users pay the penalty for it._
    
    Commits
    -------
    
    f5ece20 [Cache] Only delete one key at a time when on Predis + Cluster
  3. [Cache] Only delete one key at a time when on Predis + Cluster

    andrerom committed Mar 11, 2019
  4. bug #30507 [Routing] Fixed XML options resolution (Jules Pietri)

    fabpot committed Mar 11, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Routing] Fixed XML options resolution
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Found this bug while adding tests in #30501. I need it to be merged upward so it can get green there.
    Thanks!
    
    Commits
    -------
    
    53a6ff8 [Routing] Fixed XML options resolution
Older
You can’t perform that action at this time.