Skip to content
Permalink
Branch: 4.2
Commits on Mar 22, 2019
  1. Merge branch '3.4' into 4.2

    fabpot committed Mar 22, 2019
    * 3.4:
      [Phpunit] fixed support for PHP 5.3
      Response prepare method update
      [Workflow] Added missing license header
      Check if Client exists when test.client does not exist, to provide clearer exception message
      [Form] Preventing validation of children if parent with Valid constraint has no validation groups
      [Tests] fixed compatbility of assertEquals(): void
      [Intl] Fix test
      [Validator] Add the missing translations for the Arabic (ar) locale
      [Intl] Add compile binary
      [Form] Fixed some phpdocs
  2. bug #30640 [Phpunit] fixed support for PHP 5.3 (fabpot)

    fabpot committed Mar 22, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Phpunit] fixed support for PHP 5.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Compat with PHP 5.3 was broken by #30496
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    606b8af [Phpunit] fixed support for PHP 5.3
  3. [Phpunit] fixed support for PHP 5.3

    fabpot committed Mar 22, 2019
  4. minor #30633 Response prepare method update for more coherence (Damie…

    fabpot committed Mar 22, 2019
    …nVauchel)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Response prepare method update for more coherence
    
    $headers has been defined to avoid using $this->headers and is used everywhere but not in these lines.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    Commits
    -------
    
    e89c921 Response prepare method update
Commits on Mar 21, 2019
  1. Response prepare method update

    DamienVauchel committed Mar 21, 2019
    Response prepare updated for more coherence.
Commits on Mar 20, 2019
  1. minor #30618 [Workflow] Added missing license header (lyrixx)

    fabpot committed Mar 20, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Workflow] Added missing license header
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    e78a13f [Workflow] Added missing license header
  2. bug #30616 Fix case when multiple loaders are providing paths for the…

    fabpot committed Mar 20, 2019
    … same namespace (yceruto)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    Fix case when multiple loaders are providing paths for the same namespace
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    
    Fixes @stof #30440 (comment)
    
    Let me know if a test case is necessary for this.
    
    Cheers!
    
    Commits
    -------
    
    393d728 Fix case when multiple loaders are providing paths for the same namespace
  3. [Workflow] Added missing license header

    lyrixx committed Mar 20, 2019
  4. Fix case when multiple loaders are providing paths for the same names…

    yceruto committed Mar 20, 2019
    …pace
  5. bug #30595 Do not validate child constraints if form has no validatio…

    fabpot committed Mar 20, 2019
    …n groups (maryo)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Do not validate child constraints if form has no validation groups
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    If a form has `Valid` constraint and `validation_groups` set to an empty array (to disable validation) then its children were still validated using default validation group because `FormValidator` validated the form data using the empty array validation group here
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php#L76
    
    and then `RecursiveContextualValidator` treats the empty array as default validation group here.
    
    https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Validator/Validator/RecursiveContextualValidator.php#L86
    
    Commits
    -------
    
    f45f0d0 [Form] Preventing validation of children if parent with Valid constraint has no validation groups
  6. bug #30440 [TwigBridge] Fix DebugCommand when chain loader is involve…

    fabpot committed Mar 20, 2019
    …d (yceruto)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [TwigBridge] Fix DebugCommand when chain loader is involved
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30426
    | License       | MIT
    
    Better diff: https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1
    
    Commits
    -------
    
    f647b4a Fix DebugCommand when chain loader is involved
  7. bug #30479 Check if Client exists when test.client does not exist, to…

    fabpot committed Mar 20, 2019
    … provide clearer exception message (SerkanYildiz)
    
    This PR was squashed before being merged into the 3.4 branch (closes #30479).
    
    Discussion
    ----------
    
    Check if Client exists when test.client does not exist, to provide clearer exception message
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30420
    | License       | MIT
    
    The `DotEnv` component does not overwrite by using environment variables declared in `.env` files.
    
    In the `FrameworkExtension` will be checked if the framework.test config is set to a non-false value, if so it will load the `test.xml` file which contains the definition for the `test.client` service.
    
    When running `php bin/phpunit` it will use `phpunit.xml.dist` but because we defined `APP_ENV` in our system it will not load `test.xml` so when creating a client to do functional tests, we'll get an exception which isn't correct: `You cannot create the client used in functional tests if the BrowserKit component is not available. Try running "composer require symfony/browser-kit"`
    
    This PR aims to add a clearer exception message which indicates what really should be done to fix the error message.
    
    Commits
    -------
    
    b429950 Check if Client exists when test.client does not exist, to provide clearer exception message
  8. Check if Client exists when test.client does not exist, to provide cl…

    SerkanYildiz authored and fabpot committed Mar 7, 2019
    …earer exception message
  9. bug #30597 [Form] Added ResetInterface to CachingFactoryDecorator (He…

    fabpot committed Mar 20, 2019
    …ahDude)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Form] Added ResetInterface to CachingFactoryDecorator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29259
    | License       | MIT
    | Doc PR        | ~
    
    I don't know if this should be considered a feature and target master, but I tend to see it as a bug fix.
    
    Commits
    -------
    
    4ddf5a1 [Form] Added ResetInterface to CachingFactoryDecorator
  10. minor #30600 [Workflow] Remove deprecated usage (Nek-)

    fabpot committed Mar 20, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Workflow] Remove deprecated usage
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
    | Bug fix?      | no
    | New feature?  |no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | License       | MIT
    
    This is a little improvement suggestion because string usage is deprecated while it's still the default value. `null` is also deprecated but is required for BC.
    
    Commits
    -------
    
    eeb3c29 Remove deprecated usage
  11. minor #30610 throw TypeErrors to prepare for type hints in 5.0 (xabbuh)

    fabpot committed Mar 20, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    throw TypeErrors to prepare for type hints in 5.0
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    f18751b throw TypeErrors to prepare for type hints in 5.0
Commits on Mar 19, 2019
  1. throw TypeErrors to prepare for type hints in 5.0

    xabbuh committed Mar 19, 2019
  2. [Form] Preventing validation of children if parent with Valid constra…

    maryo committed Mar 18, 2019
    …int has no validation groups
  3. [Form] Added ResetInterface to CachingFactoryDecorator

    HeahDude committed Mar 18, 2019
  4. Remove deprecated usage

    Nek- committed Mar 19, 2019
    null is also deprecated but must be conserved for BC purpose. Also it will
    will not let the develop think string is ok.
  5. minor #30596 [Tests] fixed compatbility of assertEquals(): void (Heah…

    fabpot committed Mar 19, 2019
    …Dude)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Tests] fixed compatbility of assertEquals(): void
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Same as #30474.
    
    Commits
    -------
    
    3f7bedc [Tests] fixed compatbility of assertEquals(): void
  6. bug #30593 Fixed usage of TranslatorInterface in form extension (fixes

    fabpot committed Mar 19, 2019
    …#30591) (althaus)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    Fixed usage of TranslatorInterface in form extension (fixes #30591)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30591
    | License       | MIT
    
    This PR replaces the fixed usage of the deprecated TranslatorInterface in the form extension with a soft one accepting either the old or the new interface.
    
    Commits
    -------
    
    d8092c7 Fixed usage of TranslatorInterface in form extension (fixes #30591)
  7. [Tests] fixed compatbility of assertEquals(): void

    HeahDude committed Mar 18, 2019
Commits on Mar 18, 2019
  1. Fixed usage of TranslatorInterface in form extension (fixes #30591)

    althaus committed Mar 18, 2019
Commits on Mar 17, 2019
  1. minor #30588 [Intl][4.2] Fix test (ro0NL)

    fabpot committed Mar 17, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Intl][4.2] Fix test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Related to #30584 , the tests we're missing updated fixtures. My bad also 😅
    
    Now fixed, while at it recompiled intl for 4.2 ✌️
    
    Commits
    -------
    
    50b52cf [Intl][4.2] Fix test
  2. minor #30587 [Intl] Fix test (ro0NL)

    fabpot committed Mar 17, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Fix test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Creates some weird path, that breaks the next tests.
    
    Commits
    -------
    
    226f522 [Intl] Fix test
  3. [Intl][4.2] Fix test

    ro0NL committed Mar 17, 2019
  4. [Intl] Fix test

    ro0NL committed Mar 17, 2019
  5. minor #30534 [Form] Fixed some phpdocs (Jules Pietri)

    fabpot committed Mar 17, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] Fixed some phpdocs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#6393
    
    ref symfony/symfony-docs#6144, symfony/symfony-docs#6297, #14050
    
    Commits
    -------
    
    b9162e8 [Form] Fixed some phpdocs
  6. feature #30584 [Intl] Add compile binary (ro0NL)

    fabpot committed Mar 17, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Add compile binary
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no-ish
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Compile the Intl data by invoking a single command, and make it work out-of-the-box. (Split from #28831)
    
    ```bash
    $ src/Symfony/Component/Intl/Resources/bin/compile
    ```
    
    run in repository root because of
    
    https://github.com/symfony/symfony/blob/b7e798ef745a09ca2e76fba4afad0a04fcbd9195/src/Symfony/Component/Intl/Data/Generator/LocaleDataGenerator.php#L141
    
    3.4 is ok, 4.2 is not because of #28833 but new locales are introduced in https://github.com/symfony/symfony/pull/28977/files#diff-f52da32e1ee6b93598814090d0749aa6R1
    
    So as long as 3.4 is supported, but branches above add filters etc. during generation we're risking this discrepancy. I suggest after merge in upper branches to re-run `compile` (potential for automating, but run if needed :))
    
    Commits
    -------
    
    426b92f [Intl] Add compile binary
  7. minor #30585 [Validator] Add the missing translations for the Arabic …

    fabpot committed Mar 17, 2019
    …(ar) locale (mehdimabrouk)
    
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #30585).
    
    Discussion
    ----------
    
    [Validator] Add the missing translations for the Arabic (ar) locale
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | ?    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | none <!-- required for new features -->
    
    This pull request is for adding missing translations in validators.ar.xlf.
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    5df08d6 [Validator] Add the missing translations for the Arabic (ar) locale
  8. [Validator] Add the missing translations for the Arabic (ar) locale

    mehdimabrouk authored and fabpot committed Mar 17, 2019
Commits on Mar 16, 2019
  1. [Intl] Add compile binary

    ro0NL committed Mar 16, 2019
Commits on Mar 15, 2019
  1. Merge branch '3.4' into 4.2

    nicolas-grekas committed Mar 15, 2019
    * 3.4:
      Fix Cache error while using anonymous class
      Update validators.cs.xlf
  2. bug #30487 Fix Cache error while using anonymous class (Emmanuel BORGES)

    nicolas-grekas committed Mar 15, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix Cache error while using anonymous class
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30395
    | License       | MIT
    
    Fix Cache error while using anonymous class
    
    Commits
    -------
    
    036e722 Fix Cache error while using anonymous class
Older
You can’t perform that action at this time.