Skip to content
Permalink
Branch: 4.3
Commits on May 20, 2019
  1. Merge branch '4.2' into 4.3

    nicolas-grekas committed May 20, 2019
    * 4.2:
      minor: add some test in the ldap component
      [Bridge\ProxyManager] isProxyCandidate() does not take into account interfaces
      [Routing][AnnotationClassLoader] fix utf-8 encoding in default route name
      fixed a phpdoc
      [Debug] Wrap call to require_once in a try/catch
      prevent deprecation when filesize matches error code
      [PropertyInfo] Add missing documentation link in Readme
      Use the current working dir as default first arg in 'link' binary
      Respect parent class contract in ContainerAwareDoctrineEventManager
      [Validator] Add the missing translations for the Danish ("da") locale
      [PropertyAccess] Add missing property to PropertyAccessor
      [Cache] fix saving unrelated keys in recursive callback calls
      [Serializer] Fix denormalization of object with variadic constructor typed argument
      Allow set 'None' on samesite cookie flag
      Making cache rebuild correctly with MessageSubscriberInterface return values
      Fix finding parent definition
  2. Merge branch '3.4' into 4.2

    nicolas-grekas committed May 20, 2019
    * 3.4:
      minor: add some test in the ldap component
      [Bridge\ProxyManager] isProxyCandidate() does not take into account interfaces
      [Routing][AnnotationClassLoader] fix utf-8 encoding in default route name
      fixed a phpdoc
      [Debug] Wrap call to require_once in a try/catch
      [PropertyInfo] Add missing documentation link in Readme
      Use the current working dir as default first arg in 'link' binary
      Respect parent class contract in ContainerAwareDoctrineEventManager
      [Validator] Add the missing translations for the Danish ("da") locale
      [Serializer] Fix denormalization of object with variadic constructor typed argument
      Allow set 'None' on samesite cookie flag
  3. minor #31552 [Ldap] add a test to getResources and binding (Simperfit)

    nicolas-grekas committed May 20, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Ldap] add a test to getResources and binding
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |  <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    We could add more unit tests, but this is a beginning.
    
    Commits
    -------
    
    d08f195 minor: add some test in the ldap component
  4. minor: add some test in the ldap component

    Simperfit committed May 18, 2019
  5. minor #31536 [Workflow] Update MethodMarkingStore (noniagriconomie)

    nicolas-grekas committed May 20, 2019
    This PR was squashed before being merged into the 4.3 branch (closes #31536).
    
    Discussion
    ----------
    
    [Workflow] Update MethodMarkingStore
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 (related to deprecation of single/multiple marking store)
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | .
    | License       | MIT
    | Doc PR        | already documented
    
    Minor fix
    
    Commits
    -------
    
    c863652 [Workflow] Update MethodMarkingStore
  6. [Workflow] Update MethodMarkingStore

    noniagriconomie authored and nicolas-grekas committed May 18, 2019
  7. bug #31537 [Workflow] use method marking store (noniagriconomie)

    nicolas-grekas committed May 20, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Workflow] use method marking store
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 (related to deprecation of single/multiple marking store)
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | .
    | License       | MIT
    | Doc PR        | already documented
    
    I think the deprecation of old marking store, the single one in the statemachine, was not patched here
    Or did i miss something?
    
    Thank you
    
    Cc @lyrixx
    
    Commits
    -------
    
    a219167 [Workflow] use method marking store
  8. minor #31550 [Mailer] adding experimental disclaimer in readme (chr-h…

    nicolas-grekas committed May 20, 2019
    …ertel)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Mailer] adding experimental disclaimer in readme
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    Mailer Component is marked as experimental in code, but not in readme.
    got confused while checking the readme files of the new components
    
    Commits
    -------
    
    5175f6f adding experimental note
  9. bug #31551 [ProxyManager] isProxyCandidate() does not take into accou…

    nicolas-grekas committed May 20, 2019
    …nt interfaces (andrerom)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [ProxyManager] isProxyCandidate() does not take into account interfaces
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        | N/A
    
    When using factories it's common best practice to use interface as class name, especially in cases
    where you know implementation can differ. Before this fix ProxyManager did not allow these to be lazy.
    
    As we have have this issue on 2.8 and 3.4. it's very hard to debug, and goes against best practice for factories to not fix it, this is suggested for 2.8.
    
    Commits
    -------
    
    e3739b1 [Bridge\ProxyManager] isProxyCandidate() does not take into account interfaces
  10. bug #31542 [HttpClient] add missing argument check (nicolas-grekas)

    nicolas-grekas committed May 20, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [HttpClient] add missing argument check
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Should save some time, sometimes.
    
    Commits
    -------
    
    964acd9 [HttpClient] add missing argument check
  11. [Bridge\ProxyManager] isProxyCandidate() does not take into account i…

    andrerom committed May 20, 2019
    …nterfaces
    
    When using factories it's common best practice to use interface as class name, especially in cases
    where you know impl can differ. Before this fix ProxyManager did not allow these to be lazy.
    
    In our case this has lead several to hard to debug issues on classes we need to mark as lazyi
    and often a need to add lazy on decorators if there are any or other workarounds.
    As we have had this issue, and still have on both 2.8 and 3.4 this is opened against 2.8.
  12. adding experimental note

    chr-hertel committed May 20, 2019
Commits on May 19, 2019
  1. bug #31544 [Messenger] Fix undefined index on read timeout (chalasr)

    fabpot committed May 19, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Messenger] Fix undefined index on read timeout
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    fd8d6b8 [Messenger] Fix undefined index on read timeout
  2. [HttpClient] add missing argument check

    nicolas-grekas committed May 19, 2019
  3. [Messenger] Fix undefined index on read timeout

    chalasr committed May 19, 2019
Commits on May 18, 2019
  1. [Workflow] use method marking store

    noniagriconomie committed May 18, 2019
  2. bug #31335 [Doctrine] Respect parent class contract in ContainerAware…

    fabpot committed May 18, 2019
    …EventManager (Koc)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Doctrine] Respect parent class contract in ContainerAwareEventManager
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes, failures looks unrelated
    | Fixed tickets | #31051
    | License       | MIT
    | Doc PR        | -
    
    According to method signature of [original EventManager](https://github.com/doctrine/event-manager/blob/master/lib/Doctrine/Common/EventManager.php#L50) `getListeners` method should return array of initialized objects but now it returns array of strings of listener service names.
    
    Commits
    -------
    
    42d6272 Respect parent class contract in ContainerAwareDoctrineEventManager
  3. bug #31421 [Routing][AnnotationClassLoader] fix utf-8 encoding in def…

    fabpot committed May 18, 2019
    …ault route name (przemyslaw-bogusz)
    
    This PR was squashed before being merged into the 3.4 branch (closes #31421).
    
    Discussion
    ----------
    
    [Routing][AnnotationClassLoader] fix utf-8 encoding in default route name
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    If controller, or one of its methods, contain a unicode character and you run:
    ```
    ./bin/console debug:router
    ```
    you get this:
    ![Zrzut ekranu 2019-05-8 o 14 00 48](https://user-images.githubusercontent.com/35422131/57374545-71863080-719b-11e9-999e-fe0a5051c089.png)
    
    This PR fixes it into this:
    ![Zrzut ekranu 2019-05-8 o 14 00 59](https://user-images.githubusercontent.com/35422131/57374616-92e71c80-719b-11e9-9d13-5370213c22f7.png)
    
    Commits
    -------
    
    7ab52d3 [Routing][AnnotationClassLoader] fix utf-8 encoding in default route name
  4. [Routing][AnnotationClassLoader] fix utf-8 encoding in default route …

    przemyslaw-bogusz authored and fabpot committed May 8, 2019
    …name
  5. fixed a phpdoc

    fabpot committed May 18, 2019
  6. bug #31493 [EventDispatcher] Removed "callable" type hint from Wrappe…

    fabpot committed May 18, 2019
    …dListener constructor (wskorodecki)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [EventDispatcher] Removed "callable" type hint from WrappedListener constructor
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    
    ### The problem
    
    ```php
    public function __construct(callable $listener, ?string $name, Stopwatch $stopwatch, EventDispatcherInterface $dispatcher = null)
    ```
    
    The *callable* type hint will cause the following exception if you register a listener class with a method, which could not be auto-guessed by the Symfony:
    
    `Argument 1 passed to Symfony\Component\EventDispatcher\Debug\WrappedListener::__construct() must be callable, array given`
    
    The debug toolbar will not be displayed in this case.
    
    This is because PHP is checking the array first before making a decision if this is a valid callable or not. So if the second array element does not represent an existing method in object from the first element - PHP will treat this as a common array, not callable. Use `is_callable` method if you need a proof.
    
    ### How to reproduce
    
    1. Register some listener with a method, which could not be auto-guessed by Symfony
    2. Do not create the `__invoke` method in the listener
    3. Skip the `method` attribute in the listener configuration
    
    Example:
    
    ```php
    class SomeListener
    {
        public function myListenerMethod(SomeEvent $event)
        {
            // ...
        }
    }
    ```
    
    ```yaml
    App\EventListener\SomeListener:
        tags:
          -
            name: kernel.event_listener
    
            # Symfony will look for "onSomeEvent" method which does not exists.
            event: 'some.event'
            #method: 'myListenerMethod' # Skip this.
    ```
    
    ### Solution:
    
    Removing the type hint will cause the \Closure::fromCallable() method to throw a proper exception, for example:
    
    `Symfony\Component\Debug\Exception\FatalThrowableError(code: 0): Failed to create closure from callable: class 'App\EventListener\SomeListener' does not have a method 'onSomeEvent'`
    
    Commits
    -------
    
    20c587f [EventDispatcher] Removed "callable" type hint from WrappedListener constructor
  7. bug #31502 [WebProfilerBundle][Form] The form data collector return s…

    fabpot committed May 18, 2019
    …erialized data (Simperfit)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle][Form] The form data collector return serialized data
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #31476 <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | not needed <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    This bug occurs because at some point the FormDataCollector was returning serialized data, this has been changed in the upcoming branches but it seems that the bug occurs when using different version of the form component and the WebProfilerBundle.
    
    This bugfix add a conflict param on the WebProfilerBundle to avoid using version of the form component who still serialize the data.
    
    Commits
    -------
    
    70fdafd [WebProfilerBundle][Form] The form data collector return serialized object when profiler bundle attends object
  8. bug #31510 Use the current working dir as default first arg in 'link'…

    fabpot committed May 18, 2019
    … binary (lyrixx)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Use the current working dir as default first arg in 'link' binary
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    I don't know how you work on symfony, but each time I face the same issue
    
    1. I go on lyrixx/symfony (my fork)
    1. I execute `pwd` and copy it
    1. I go to an application
    1. I paste the cwd + add `/link` and hit enter
    1. I got an error because I missed the "target"
    1. I replay the last command and add ` .`
    
    With this PR, I will save the last 2 items...
    
    Event if it's a "new feature", I targeted 3.4.
    
    Commits
    -------
    
    6b76c36 Use the current working dir as default first arg in 'link' binary
  9. bug #31524 [HttpFoundation] prevent deprecation when filesize matches…

    fabpot committed May 18, 2019
    … error code (xabbuh)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] prevent deprecation when filesize matches error code
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31515
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    d836c63 prevent deprecation when filesize matches error code
  10. bug #31535 [Debug] Wrap call to require_once in a try/catch (lyrixx)

    fabpot committed May 18, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Debug] Wrap call to require_once in a try/catch
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony/monolog-bundle#236
    | License       | MIT
    | Doc PR        |
    
    If the included file contains an error, it hides the real error. This
    makes debugging harder.
    
    How to reproduce:
    
    ```
    composer create-project symfony/skeleton symfony-3.4 3.4
    cd symfony-3.4
    composer req monolog
    ```
    
    Add to `monolog.yaml`:
    ```yaml
            elasticsearch:
                type: "elasticsearch"
                elasticsearch:
                    host: 'elasticsearch'
                    port: '9200'
                index: 'ep_php_logs_dev'
                level: 'debug'
                tags: 'monolog.logger'
                channels: ['!event']
    ```
    
    This will fail because the the `\Elastica\Client` class does not exist.
    But this error will be hidden by the `ClassNotFoundFatalErrorHandler`
    because it will try to load the `Symfony\Component\Kernel\Client` and
    this class extends `Symfony\Component\BrowserKit\Client`. The last one
    is a soft dependency...
    
    ---
    
    Before
    ```
    Fatal error: Uncaught Error: Class 'Symfony\Component\BrowserKit\Client' not found in /tmp/symfony-3.4/vendor/symfony/http-kernel/Client.php:31
    ```
    
    After:
    ```
    Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "Client" from namespace "Elastica".
    Did you forget a "use" statement for another namespace? in /tmp/symfony-es/var/cache/dev/ContainerWXN4mS9/srcApp_KernelDevDebugContainer.php:303
    ```
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    afb6e1e [Debug] Wrap call to require_once in a try/catch
  11. [Debug] Wrap call to require_once in a try/catch

    lyrixx committed May 18, 2019
    If the included file contains an error, it hides the real error. This
    makes debugging harder.
    
    How to reproduce:
    
    ```
    composer create-project symfony/skeleton symfony-3.4 3.4
    cd symfony-3.4
    composer req monolog
    ```
    
    Add to `monolog.yaml`:
    ```yaml
            elasticsearch:
                type: "elasticsearch"
                elasticsearch:
                    host: 'elasticsearch'
                    port: '9200'
                index: 'ep_php_logs_dev'
                level: 'debug'
                tags: 'monolog.logger'
                channels: ['!event']
    ```
    
    This will fail because the the \Elastica\Client class does not exist.
    But this error will be hidden by the `ClassNotFoundFatalErrorHandler`
    because it will try to load the `Symfony\Component\Kernel\Client` and
    this class extends `Symfony\Component\BrowserKit\Client`. The last one
    is a soft dependency...
    
    ---
    
    Before
    ```
    Fatal error: Uncaught Error: Class 'Symfony\Component\BrowserKit\Client' not found in /tmp/symfony-3.4/vendor/symfony/http-kernel/Client.php:31
    ```
    
    After:
    ```
    Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "Client" from namespace "Elastica".
    Did you forget a "use" statement for another namespace? in /tmp/symfony-es/var/cache/dev/ContainerWXN4mS9/srcApp_KernelDevDebugContainer.php:303
    ```
Commits on May 17, 2019
  1. [EventDispatcher] Removed "callable" type hint from WrappedListener c…

    wskorodecki committed May 17, 2019
    …onstructor
  2. prevent deprecation when filesize matches error code

    xabbuh committed May 17, 2019
Commits on May 16, 2019
  1. minor #31513 [PropertyInfo] Add missing documentation link in Readme …

    fabpot committed May 16, 2019
    …(plozmun)
    
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #31513).
    
    Discussion
    ----------
    
    [PropertyInfo] Add missing documentation link in Readme
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        |
    
    Missing link to Property Info documentation
    
    Commits
    -------
    
    62894ed [PropertyInfo] Add missing documentation link in Readme
  2. [PropertyInfo] Add missing documentation link in Readme

    plozmun authored and fabpot committed May 16, 2019
  3. Use the current working dir as default first arg in 'link' binary

    lyrixx committed May 16, 2019
Commits on May 15, 2019
  1. Respect parent class contract in ContainerAwareDoctrineEventManager

    Koc committed Apr 30, 2019
  2. [WebProfilerBundle][Form] The form data collector return serialized o…

    Simperfit committed May 15, 2019
    …bject when profiler bundle attends object
  3. feature #31030 [Serializer] Deprecate calling createChildContext with…

    fabpot committed May 15, 2019
    …out the format parameter (dbu)
    
    This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #31030).
    
    Discussion
    ----------
    
    [Serializer] Deprecate calling createChildContext without the format parameter
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    as discussed in #30907 deprecate omitting the format parameter when extending the AbstractNormalizer.
    
    Commits
    -------
    
    cb77902 deprecate calling createChildContext without the format parameter
  4. deprecate calling createChildContext without the format parameter

    dbu authored and fabpot committed Apr 9, 2019
Older
You can’t perform that action at this time.