Skip to content
Permalink
Branch: 4.3
Commits on May 24, 2019
  1. [HttpClient] fix test

    nicolas-grekas committed May 24, 2019
Commits on May 23, 2019
  1. minor #31598 Don't reference symfony/security (nicolas-grekas)

    fabpot committed May 23, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Don't reference symfony/security
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    c67632c Don't reference symfony/security
  2. Don't reference symfony/security

    nicolas-grekas committed May 23, 2019
  3. bug #31565 [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts…

    nicolas-grekas committed May 23, 2019
    … (ifaridjalilov)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Replaces #31464
    
    Commits
    -------
    
    67fbae1 [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts
  4. bug #31591 [FrameworkBundle] fix named autowiring aliases for TagAwar…

    nicolas-grekas committed May 23, 2019
    …eCacheInterface (nicolas-grekas)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] fix named autowiring aliases for TagAwareCacheInterface
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Doing a demo today, I realized that named autowiring aliases are missing for `TagAwareCacheInterface`, and that existing ones point to the wrong service. Here is the fix.
    
    Commits
    -------
    
    d9082c2 [FrameworkBundle] fix named autowiring aliases for TagAwareCacheInterface
  5. bug #31590 [Cache] improve logged messages (nicolas-grekas)

    nicolas-grekas committed May 23, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Cache] improve logged messages
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This was improved already in #31395, but the patch was incomplete.
    This PR fixes this.
    
    Commits
    -------
    
    257f3f1 [Cache] improve logged messages
  6. bug #31586 [HttpClient] display proper error message on TransportExce…

    nicolas-grekas committed May 23, 2019
    …ption when curl is used (nicolas-grekas)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [HttpClient] display proper error message on TransportException when curl is used
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Reported independently by @GawainLynch and @tgalopin:
    the message of TransportException is currently empty when using CurlHttpClient.
    
    This now displays e.g.
    ```
      [Symfony\Component\HttpClient\Exception\TransportException]
      Couldn't connect to server for http://localhost:8000/index.html
    ```
    
    Commits
    -------
    
    3273109 [HttpClient] display proper error message on TransportException when curl is used
  7. [HttpClient] display proper error message on TransportException when …

    nicolas-grekas committed May 22, 2019
    …curl is used
Commits on May 22, 2019
  1. [FrameworkBundle] fix named autowiring aliases for TagAwareCacheInter…

    nicolas-grekas committed May 22, 2019
    …face
  2. [Cache] improve logged messages

    nicolas-grekas committed May 22, 2019
  3. [Mime][HttpFoundation] Added mime type audio/x-hx-aac-adts

    ifaridjalilov authored and nicolas-grekas committed May 10, 2019
  4. bumped Symfony version to 4.3.0

    fabpot committed May 22, 2019
  5. Merge pull request #31577 from fabpot/release-4.3.0-BETA2

    fabpot committed May 22, 2019
    released v4.3.0-BETA2
  6. updated VERSION for 4.3.0-BETA2

    fabpot committed May 22, 2019
  7. bug #31569 [HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL…

    fabpot committed May 22, 2019
    …_VERSION_HTTP2 if defined (GawainLynch)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HTTP2 if defined
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Regards the constants:
    
     - CURLMOPT_MAX_HOST_CONNECTIONS is available since PHP 7.0.7 and cURL 7.30.0
     - CURL_VERSION_HTTP2 is available since PHP 5.5.24 and 5.6.8 and cURL 7.33.0
    
    Errors triggered:
    
    > Use of undefined constant CURLMOPT_MAX_HOST_CONNECTIONS - assumed 'CURLMOPT_MAX_HOST_CONNECTIONS'
    > in vendor/symfony/http-client/CurlHttpClient.php (line 73)
    
    > Use of undefined constant CURL_VERSION_HTTP2 - assumed 'CURL_VERSION_HTTP2'
    > in vendor/symfony/http-client/CurlHttpClient.php (line 191)
    
    Commits
    -------
    
    4ea7283 [HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HTTP2 if defined
  8. [HttpClient] Only use CURLMOPT_MAX_HOST_CONNECTIONS & CURL_VERSION_HT…

    GawainLynch committed May 22, 2019
    …TP2 if defined
    
     - CURLMOPT_MAX_HOST_CONNECTIONS is available since PHP 7.0.7 and cURL 7.30.0
     - CURL_VERSION_HTTP2 is available since PHP 5.5.24 and 5.6.8 and cURL 7.33.0
Commits on May 21, 2019
  1. bug #31566 [Security] fixed a fatal error when upgrading from 4.2 (fa…

    nicolas-grekas committed May 21, 2019
    …bpot)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Security] fixed a fatal error when upgrading from 4.2
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    This is needed when upgrading a project from 4.2 to 4.3 to avoid a fatal PHP error when unserializing a token serialized on 4.2.
    
    Commits
    -------
    
    cd63446 [Security] fixed a fatal error when upgrading from 4.2
  2. [Security] fixed a fatal error when upgrading from 4.2

    fabpot authored and nicolas-grekas committed May 21, 2019
  3. bug #31219 [HttpClient] Allow arrays as query parameters (sleepyboy)

    nicolas-grekas committed May 21, 2019
    This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #31219).
    
    Discussion
    ----------
    
    [HttpClient] Allow arrays as query parameters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    This PR allows passing arrays as query parameters.
    
    For instance, if I pass $options['query']['category'] = ['news', 'sport', 'culture'] to my GET request, I expect this to be transformed to URL?category[]=news&category[]=sport&category[]=culture.
    
    I added two tests to cover this functionality. I also fixed one of the tests where "+" wasn't encoded as %20 in the final URL.
    
    Commits
    -------
    
    1cbefd7 [HttpClient] Allow arrays as query parameters
  4. [HttpClient] Allow arrays as query parameters

    sleepyboy authored and nicolas-grekas committed Apr 24, 2019
  5. minor #31553 [Ldap] add a test on parsing the rdn (Simperfit)

    nicolas-grekas committed May 21, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Ldap] add a test on parsing the rdn
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |  <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    One more test on the rdn directly.
    
    - [x] When #31552 has been merged this one needs to be rebased.
    
    Commits
    -------
    
    0abe32b [Ldap] add a test on parsing the rdn
  6. bug #31482 [Messenger][DoctrineBridge] Throws UnrecoverableMessageHan…

    fabpot committed May 21, 2019
    …dlingException when passed invalid entity manager name (Koc)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Messenger][DoctrineBridge] Throws UnrecoverableMessageHandlingException when passed invalid entity manager name
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | not sure
    | Deprecations? | no
    | Tests pass?   | Waiting for Travis
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    1. Throws `UnrecoverableMessageHandlingException` and do not retry messages if middlewares missconfigured
    2.  `getManager()` doesn't return null. Actually [it throws](https://github.com/doctrine/persistence/blob/master/lib/Doctrine/Persistence/AbstractManagerRegistry.php#L144-L160) `\InvalidArgumentException` in requested entity manager not exists.
    
    Not sure, should this changes considered as BC-break.
    
    Also I can extract abstract Doctrine middleware but not sure what branch should I use for it? Master or 4.3?
    
    Commits
    -------
    
    c4eca27 Throws UnrecoverableMessageHandlingException when passed invalid entity manager name for Doctrine middlewares
  7. Throws UnrecoverableMessageHandlingException when passed invalid enti…

    Koc committed May 10, 2019
    …ty manager name for Doctrine middlewares
  8. feature #31471 [Messenger] Add "non sendable" stamps (weaverryan)

    fabpot committed May 21, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Messenger] Add "non sendable" stamps
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31460
    | License       | MIT
    | Doc PR        | not needed
    
    Fixes a bug where Symfony serialization of the AmqpReceivedStamp sometimes caused problems.
    
    It's still a mystery why the `AmqpReceivedStamp` caused a segfault *sometimes* when going through the Symfony serializer or the `VarDumper`. But, that stamp really didn't need to be sent on redelivery anyways.
    
    I don't love making the removal the responsibility of the serializers, but it didn't work well anywhere else.
    
    Cheers!
    
    Commits
    -------
    
    34e7781 Adding a new NonSendableStampInterface to avoid sending certain stamps
  9. bug #31545 [Messenger] Fix redis Connection::get() should be non bloc…

    fabpot committed May 21, 2019
    …king by default (chalasr)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Messenger] Fix redis Connection::get() should be non blocking by default
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | todo
    
    The `\Redis::xreadgroup()` method waits until a message arrives or the specified timeout is reached before returning, which means that `RedisExt\Connection::get()` is blocking.
    That's inconsistent with other transports which all returns immediately in case there is no message, for instance the AMQP transport uses `\Amqp::get()` instead of `\Amqp::consume()` for this reason.
    It also short-circuits the worker's stop logic: both the `--time-limit` option of the `messenger:consume` command and the `messenger:stop-workers` don't work with the redis transport.
    This returns early in case the message count is 0 and no blocking timeout has been configured.
    
    Commits
    -------
    
    229502a [Messenger] Make redis Connection::get() non blocking by default
  10. [Messenger] Make redis Connection::get() non blocking by default

    chalasr committed May 19, 2019
Commits on May 20, 2019
  1. [Ldap] add a test on parsing the rdn

    Simperfit committed May 20, 2019
  2. Merge branch '4.2' into 4.3

    nicolas-grekas committed May 20, 2019
    * 4.2:
      minor: add some test in the ldap component
      [Bridge\ProxyManager] isProxyCandidate() does not take into account interfaces
      [Routing][AnnotationClassLoader] fix utf-8 encoding in default route name
      fixed a phpdoc
      [Debug] Wrap call to require_once in a try/catch
      prevent deprecation when filesize matches error code
      [PropertyInfo] Add missing documentation link in Readme
      Use the current working dir as default first arg in 'link' binary
      Respect parent class contract in ContainerAwareDoctrineEventManager
      [Validator] Add the missing translations for the Danish ("da") locale
      [PropertyAccess] Add missing property to PropertyAccessor
      [Cache] fix saving unrelated keys in recursive callback calls
      [Serializer] Fix denormalization of object with variadic constructor typed argument
      Allow set 'None' on samesite cookie flag
      Making cache rebuild correctly with MessageSubscriberInterface return values
      Fix finding parent definition
  3. Merge branch '3.4' into 4.2

    nicolas-grekas committed May 20, 2019
    * 3.4:
      minor: add some test in the ldap component
      [Bridge\ProxyManager] isProxyCandidate() does not take into account interfaces
      [Routing][AnnotationClassLoader] fix utf-8 encoding in default route name
      fixed a phpdoc
      [Debug] Wrap call to require_once in a try/catch
      [PropertyInfo] Add missing documentation link in Readme
      Use the current working dir as default first arg in 'link' binary
      Respect parent class contract in ContainerAwareDoctrineEventManager
      [Validator] Add the missing translations for the Danish ("da") locale
      [Serializer] Fix denormalization of object with variadic constructor typed argument
      Allow set 'None' on samesite cookie flag
  4. minor #31552 [Ldap] add a test to getResources and binding (Simperfit)

    nicolas-grekas committed May 20, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Ldap] add a test to getResources and binding
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |  <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    We could add more unit tests, but this is a beginning.
    
    Commits
    -------
    
    d08f195 minor: add some test in the ldap component
  5. minor: add some test in the ldap component

    Simperfit committed May 18, 2019
  6. minor #31536 [Workflow] Update MethodMarkingStore (noniagriconomie)

    nicolas-grekas committed May 20, 2019
    This PR was squashed before being merged into the 4.3 branch (closes #31536).
    
    Discussion
    ----------
    
    [Workflow] Update MethodMarkingStore
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 (related to deprecation of single/multiple marking store)
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | .
    | License       | MIT
    | Doc PR        | already documented
    
    Minor fix
    
    Commits
    -------
    
    c863652 [Workflow] Update MethodMarkingStore
  7. [Workflow] Update MethodMarkingStore

    noniagriconomie authored and nicolas-grekas committed May 18, 2019
  8. bug #31537 [Workflow] use method marking store (noniagriconomie)

    nicolas-grekas committed May 20, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Workflow] use method marking store
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 (related to deprecation of single/multiple marking store)
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | .
    | License       | MIT
    | Doc PR        | already documented
    
    I think the deprecation of old marking store, the single one in the statemachine, was not patched here
    Or did i miss something?
    
    Thank you
    
    Cc @lyrixx
    
    Commits
    -------
    
    a219167 [Workflow] use method marking store
Older
You can’t perform that action at this time.