Skip to content
Permalink
Branch: 4.4
Commits on Jul 23, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jul 23, 2019
    * 4.3:
      fix typo
  2. fix typo

    nicolas-grekas committed Jul 23, 2019
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jul 23, 2019
    * 4.3:
      fix merge
  4. fix merge

    nicolas-grekas committed Jul 23, 2019
  5. minor #32678 [Lock] remove all mention to StoreInterface in comments …

    nicolas-grekas committed Jul 23, 2019
    …and tests (Simperfit)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Lock] remove all mention to StoreInterface in comments and tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | none <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    Update 4.4 with removing all mentions to StoreInterface in comments and tests whenever it's possible.
    
    cc @nicolas-grekas
    
    Commits
    -------
    
    699a88b [Lock] remove all mention to StoreInterface in comments and tests
  6. [Lock] remove all mention to StoreInterface in comments and tests

    Simperfit committed Jul 23, 2019
  7. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jul 23, 2019
    * 4.3:
      [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
      ignore not existing translator service
      [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
      revert private properties handling
      [HttpFoundation] Fix URLs
      [VarDumper] finish PHP 7.4 support and add tests
      [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
      Ignore missing translation dependency in FrameworkBundle
      [Security/Http] Don't mark AbstractAuthenticationListener as internal
      Remove dead tests fixtures
      Remove more dead tests fixtures
      [Mime] Add missing changelog entry for BC-break
      [Messenger] fix transport_name option not passing validation
      Remove dead tests fixtures
      [Debug][ExceptionHandler] Add tests for custom handlers
  8. Merge branch '4.2' into 4.3

    nicolas-grekas committed Jul 23, 2019
    * 4.2:
      [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
      ignore not existing translator service
      [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
      revert private properties handling
      [HttpFoundation] Fix URLs
      [VarDumper] finish PHP 7.4 support and add tests
      [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
      Ignore missing translation dependency in FrameworkBundle
      Remove dead tests fixtures
      Remove more dead tests fixtures
      Remove dead tests fixtures
      [Debug][ExceptionHandler] Add tests for custom handlers
  9. minor #32677 [FrameworkBundle] ignore not existing translator service…

    nicolas-grekas committed Jul 23, 2019
    … (xabbuh)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] ignore not existing translator service
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    12bf0b0 ignore not existing translator service
  10. minor #32626 [FrameworkBundle] [SecurityBundle] Rename internal WebTe…

    nicolas-grekas committed Jul 23, 2019
    …stCase to avoid confusion (janvt)
    
    This PR was squashed before being merged into the 4.2 branch (closes #32626).
    
    Discussion
    ----------
    
    [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
    
    FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase,
    one of which is only meant for internal tests. To avoid confusion the internal
    class has been renamed to AbstractWebTestCase and made abstract.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no (or, yes, but internal class)
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32577
    | License       | MIT
    
    This PR is to ease integration, as not all test classes are present in all currently
    maintained branches. This PR should patch relatively well onto 4.* branches.
    
    See #32617
    
    Commits
    -------
    
    01aaece [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
  11. [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avo…

    janvt authored and nicolas-grekas committed Jul 19, 2019
    …id confusion
  12. ignore not existing translator service

    xabbuh committed Jul 23, 2019
  13. Merge branch '3.4' into 4.2

    nicolas-grekas committed Jul 23, 2019
    * 3.4:
      [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
      revert private properties handling
      [HttpFoundation] Fix URLs
      [VarDumper] finish PHP 7.4 support and add tests
      [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
      Ignore missing translation dependency in FrameworkBundle
      [Debug][ExceptionHandler] Add tests for custom handlers
  14. feature #32582 [Routing] Deprecate ServiceRouterLoader and ObjectRout…

    nicolas-grekas committed Jul 23, 2019
    …eLoader in favor of ContainerLoader and ObjectLoader (fancyweb)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Routing] Deprecate ServiceRouterLoader and ObjectRouteLoader in favor of ContainerLoader and ObjectLoader
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #30926 (comment)
    | License       | MIT
    | Doc PR        | -
    
    This PR aims at deprecating some things to have a more consistent code.
    
    ### ServiceRouterLoader
    
    1. This class actually fetches an object from a container. In #30926 (comment), it was suggested that it should be renamed to `ContainerRouteLoader`. Actually I think it's better to rename it to `ContainerLoader` since all others route loaders does not have "Route" in their name. Let's be consistent!
    
    2. This class is in a `DependencyInjection` sub directory for historical reasons. Let's remove that! It accepts any PSR-11 container.
    
    ### ObjectRouteLoader
    
    1. This class has "Route" in its name too. Let's rename it!
    
    2. This class is supposed to be an abstract implementation for "object" loaders to reuse, but in its code it has a lot of references to "services". Let's remove those references! That means renaming some methods, altering messages, etc.. That also means removing the `supports` method from it to let extending classes implement it.
    
    3. IMHO, this abstract implementation is useless. We sould just deprecate the whole class and move the implemention in the `ContainerLoader` class.
    
    Commits
    -------
    
    1548101 [Routing] Deprecate ServiceRouterLoader and ObjectRouteLoader in favor of ContainerLoader and ObjectLoader
  15. minor #32619 [Debug][ExceptionHandler] Add tests for custom handlers …

    nicolas-grekas committed Jul 23, 2019
    …(fancyweb)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Debug][ExceptionHandler] Add tests for custom handlers
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    In #31694 I mixed many things but the whole PR was closed. I wrote some tests for custom handlers + the handle tests don't use mock anymore
    
    I think they are useful even if the `ExceptionHandler` will disappear in the new component because it will still exists in 4.4 for the next 3 years.
    
    Commits
    -------
    
    c53e253 [Debug][ExceptionHandler] Add tests for custom handlers
  16. minor #32625 [FrameworkBundle] [SecurityBundle] Rename internal WebTe…

    nicolas-grekas committed Jul 23, 2019
    …stCase to avoid confusion (janvt)
    
    This PR was squashed before being merged into the 3.4 branch (closes #32625).
    
    Discussion
    ----------
    
    [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
    
    FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase,
    one of which is only meant for internal tests. To avoid confusion the internal
    class has been renamed to AbstractWebTestCase and made abstract.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no (or, yes, but internal class)
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32577
    | License       | MIT
    
    This PR is to ease integration, as not all test classes are present in all currently
    maintained branches.
    
    See #32617
    
    Commits
    -------
    
    775d970 [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
  17. [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avo…

    janvt authored and nicolas-grekas committed Jul 19, 2019
    …id confusion
  18. minor #32672 [VarDumper] revert private properties handling (xabbuh)

    nicolas-grekas committed Jul 23, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [VarDumper] revert private properties handling
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    9bad905 revert private properties handling
  19. revert private properties handling

    xabbuh committed Jul 23, 2019
  20. minor #32671 [Lock] Add missing changelog entry for Factory deprecati…

    nicolas-grekas committed Jul 23, 2019
    …on (Simperfit)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Lock] Add missing changelog entry for Factory deprecation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets |    <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | None <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Add missing changelog entry for the deprecation of the Factory into LockFactory
    
    Commits
    -------
    
    c6daa61 [Lock] Add missing changelog entry for Factory deprecation
  21. [Lock] Add missing changelog entry for Factory deprecation

    Simperfit committed Jul 23, 2019
  22. feature #32661 [ErrorRenderer] Improving the exception page provided …

    fabpot committed Jul 23, 2019
    …by HtmlErrorRenderer (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32661).
    
    Discussion
    ----------
    
    [ErrorRenderer] Improving the exception page provided by HtmlErrorRenderer
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    As part of the component responsability, this proposal is intended to provide a full exception page (advanced) in debug mode, just like the one provided by TwigBundle which would be deprecated.
    
    Commits
    -------
    
    5d76eb7 [ErrorRenderer] Improving the exception page provided by HtmlErrorRenderer
  23. [ErrorRenderer] Improving the exception page provided by HtmlErrorRen…

    yceruto authored and fabpot committed Jul 22, 2019
    …derer
  24. minor #32632 [HttpFoundation] Fix URLs (Arman-Hosseini)

    fabpot committed Jul 23, 2019
    This PR was squashed before being merged into the 3.4 branch (closes #32632).
    
    Discussion
    ----------
    
    [HttpFoundation] Fix URLs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    be53c59 [HttpFoundation] Fix URLs
  25. [HttpFoundation] Fix URLs

    Arman-Hosseini authored and fabpot committed Jul 19, 2019
  26. bug #31303 [VarDumper] Use \ReflectionReference for determining if a …

    nicolas-grekas committed Jul 23, 2019
    …key is a reference (php >= 7.4) (dorumd, nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31135
    | License       | MIT
    | Doc PR        | -
    
    Prepare for PHP 7.4: use ReflectionReference in VarCloner
    
    Commits
    -------
    
    40f24ef [VarDumper] finish PHP 7.4 support and add tests
    e99a6b8 [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
  27. [VarDumper] finish PHP 7.4 support and add tests

    nicolas-grekas committed Jul 22, 2019
  28. [VarDumper] Use \ReflectionReference for determining if a key is a re…

    dorumd authored and nicolas-grekas committed Apr 28, 2019
    …ference (php >= 7.4)
Commits on Jul 22, 2019
  1. minor #32664 Ignore missing translation dependency in FrameworkBundle…

    Tobion committed Jul 22, 2019
    … (alcaeus)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Ignore missing translation dependency in FrameworkBundle
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    This applies the fix from #31156 to the validator.xml file. The error came up a couple of times in the test suite for DoctrineBundle. When using `symfony/framework-bundle` with `symfony/validator` installed but without `symfony/translation`, the call to `setTranslator` will error out because of the missing `translator` service. Thus, the call to `setTranslator` needs to ignore a missing translator dependency to support this scenario.
    
    I don't know how to best test this since the translation component is present in the `require-dev` directive of FrameworkBundle's `composer.json`. If you have any suggestions how to achieve this, please let me know.
    
    Commits
    -------
    
    19eb90d Ignore missing translation dependency in FrameworkBundle
  2. minor #32659 [ErrorRenderer] Fixed the priority order of the error re…

    Tobion committed Jul 22, 2019
    …nderers registration (yceruto)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [ErrorRenderer] Fixed the priority order of the error renderers registration
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Spotted in #31398 and #32504
    
    Commits
    -------
    
    710b51d Fixed the priority order of the error renderers registration
  3. minor #32660 [ErrorRenderer] Making debug = false by default and clea…

    Tobion committed Jul 22, 2019
    …nup (yceruto)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [ErrorRenderer] Making debug = false by default and cleanup
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Consistent with other places where the default value is `false`.
    
    Commits
    -------
    
    b28986f Making debug = false by default and cleanup
  4. Fixed the priority order of the error renderers registration

    yceruto committed Jul 22, 2019
  5. [Routing] Deprecate ServiceRouterLoader and ObjectRouteLoader in favo…

    fancyweb committed Jul 17, 2019
    …r of ContainerLoader and ObjectLoader
  6. minor #32610 [Mime] Add missing changelog entry for BC-break (Koc)

    Tobion committed Jul 22, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Mime] Add missing changelog entry for BC-break
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | mo
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32607
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    3a35432 [Mime] Add missing changelog entry for BC-break
  7. minor #32648 Remove hack to access class scope inside closures (carus…

    Tobion committed Jul 22, 2019
    …ogabriel)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    Remove hack to access class scope inside closures
    
    This is possible since 5.4.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    f84c71b Remove hack to access class scope inside closures
Older
You can’t perform that action at this time.