Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jul 26, 2015
  1. @fabpot

    feature #15347 [DependencyInjection][3.0] Add initialized to containe…

    fabpot authored
    …r interface (znerol)
    
    This PR was merged into the 3.0-dev branch.
    
    Discussion
    ----------
    
    [DependencyInjection][3.0] Add initialized to container interface
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15346
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    bfddac3 [DependencyInjection] Add initialized() to the ContainerInterface
  2. @znerol
  3. @fabpot

    Merge branch '2.8'

    fabpot authored
    * 2.8:
      [Yaml] throw a ParseException on invalid data type
      [TwigBridge] type-dependent path discovery
      Resources as string have the same problem
      Introduce failing test case when a SplFileInfo object is passed to the extract() method in the TwigExtractor.
      #15331 add infos about deprecated classes to UPGRADE-3.0
      [Asset] removed unused private property.
      [Twig+FrameworkBundle] Fix forward compat with Form 2.8
      [2.6] Static Code Analysis for Components
      [Security/Http] Fix test relying on a private property
      [Serializer] Fix bugs reported in b5990be#commitcomment-12301266
      [Form] Fix not-BC test assertion
      [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http
      [Security] removed useless else condition in SwitchUserListener class.
      [travis] Tests deps=low with PHP 5.6
      Implement resettable containers
      [Console] Fix console output with closed stdout
  4. @fabpot

    Merge branch '2.7' into 2.8

    fabpot authored
    * 2.7:
      [Yaml] throw a ParseException on invalid data type
      [TwigBridge] type-dependent path discovery
      Resources as string have the same problem
      Introduce failing test case when a SplFileInfo object is passed to the extract() method in the TwigExtractor.
      #15331 add infos about deprecated classes to UPGRADE-3.0
      [Asset] removed unused private property.
      [Security] removed useless else condition in SwitchUserListener class.
      [travis] Tests deps=low with PHP 5.6
      [Console] Fix console output with closed stdout
  5. @fabpot

    Merge branch '2.6' into 2.7

    fabpot authored
    * 2.6:
      [Yaml] throw a ParseException on invalid data type
      #15331 add infos about deprecated classes to UPGRADE-3.0
      [Security] removed useless else condition in SwitchUserListener class.
      [travis] Tests deps=low with PHP 5.6
      [Console] Fix console output with closed stdout
  6. @fabpot

    Merge branch '2.3' into 2.6

    fabpot authored
    * 2.3:
      #15331 add infos about deprecated classes to UPGRADE-3.0
      [Security] removed useless else condition in SwitchUserListener class.
      [travis] Tests deps=low with PHP 5.6
      [Console] Fix console output with closed stdout
  7. @fabpot

    minor #15332 [travis] Tests deps=low with PHP 5.6 (nicolas-grekas)

    fabpot authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [travis] Tests deps=low with PHP 5.6
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I noticed that testing deps=low with the lowest supported PHP skips some tests/features.
    I propose to merge the 5.6 and deps=low lines of the test matrix in order to both fix this issue and remove one line in the matrix (thus making tests a bit lighter/faster on travis).
    
    Commits
    -------
    
    d3874ec [travis] Tests deps=low with PHP 5.6
  8. @fabpot

    minor #15357 #15331 add infos about deprecated classes to UPGRADE-3.0…

    fabpot authored
    … (vincentaubert)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    #15331 add infos about deprecated classes to UPGRADE-3.0
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15331
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    e391446 #15331 add infos about deprecated classes to UPGRADE-3.0
  9. @fabpot

    bug #15369 [TwigBridge] type-dependent path discovery (marcosdsanchez…

    fabpot authored
    …, xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [TwigBridge] type-dependent path discovery
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15340
    | License       | MIT
    | Doc PR        |
    
    With the introduction of the `AbstractFileExtractor` in Symfony 2.7, the
    `extract()` method in the `TwigExtractor` class does not necessarily
    deal with `SplFileInfo` instances from the Finder component, but also
    receives `\SplFileInfo` objects initialized by the base extractor class.
    
    Commits
    -------
    
    1e15761 [TwigBridge] type-dependent path discovery
    2bf78e5 Resources as string have the same problem
    aa7cbbd Introduce failing test case when a SplFileInfo object is passed to the extract() method in the TwigExtractor.
  10. @fabpot

    bug #15361 [Yaml] throw a ParseException on invalid data type (xabbuh)

    fabpot authored
    This PR was submitted for the 2.8 branch but it was merged into the 2.6 branch instead (closes #15361).
    
    Discussion
    ----------
    
    [Yaml] throw a ParseException on invalid data type
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15234
    | License       | MIT
    | Doc PR        |
    
    Without this check, PHP would trigger a warning when an array was passed
    to `trim()`. The parser must throw a `ParseException` instance on a
    malformed YAML string instead.
    
    Commits
    -------
    
    adc6b30 [Yaml] throw a ParseException on invalid data type
  11. @xabbuh @fabpot

    [Yaml] throw a ParseException on invalid data type

    xabbuh authored fabpot committed
    Without this check, PHP would trigger a warning when an array was passed
    to `trim()`. The parser must throw a `ParseException` instance on a
    malformed YAML string instead.
  12. @fabpot

    minor #15367 [Asset] removed unused private property. (hhamon)

    fabpot authored
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Asset] removed unused private property.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Commits
    -------
    
    a1772b6 [Asset] removed unused private property.
  13. @xabbuh

    [TwigBridge] type-dependent path discovery

    xabbuh authored
    With the introduction of the `AbstractFileExtractor` in Symfony 2.7, the
    `extract()` method in the `TwigExtractor` class does not necessarily
    deal with `SplFileInfo` instances from the Finder component, but also
    receives `\SplFileInfo` objects initialized by the base extractor class.
  14. @marcosdsanchez @xabbuh

    Resources as string have the same problem

    marcosdsanchez authored xabbuh committed
  15. @marcosdsanchez @xabbuh

    Introduce failing test case when a SplFileInfo object is passed to th…

    marcosdsanchez authored xabbuh committed
    …e extract() method in the TwigExtractor.
    
    The problem is that when there's a twig error, symfony expects the `getRelativePath` method that the native object doesn't have.
  16. @vincentaubert
Commits on Jul 25, 2015
  1. @hhamon
Commits on Jul 24, 2015
  1. @nicolas-grekas

    Merge branch '2.7' into 2.8

    nicolas-grekas authored
    * 2.7:
      [Twig+FrameworkBundle] Fix forward compat with Form 2.8
      [2.6] Static Code Analysis for Components
      [Security/Http] Fix test relying on a private property
      [Serializer] Fix bugs reported in b5990be#commitcomment-12301266
    
    Conflicts:
    	src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
    	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/widget_attributes.html.php
    	src/Symfony/Component/Security/Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php
  2. @nicolas-grekas

    Merge branch '2.6' into 2.7

    nicolas-grekas authored
    * 2.6:
      [2.6] Static Code Analysis for Components
      [Security/Http] Fix test relying on a private property
  3. @fabpot

    minor #15337 [Form] Fix not-BC test assertion (nicolas-grekas)

    fabpot authored
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] Fix not-BC test assertion
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    The 2.6 branch is failing because of this case for `Validation::API_VERSION_2_4`, that can't work because `$this->context` is not a mock object, thus has no "expect" method.
    See https://travis-ci.org/symfony/symfony/jobs/72100346#L2902
    This got unnoticed because only 2.6 is testing the 2.4 validator api.
    
    Commits
    -------
    
    5ef7ae9 [Form] Fix not-BC test assertion
  4. @fabpot

    bug #15345 [Twig+FrameworkBundle] Fix forward compat with Form 2.8 (n…

    fabpot authored
    …icolas-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Twig+FrameworkBundle] Fix forward compat with Form 2.8
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    When these layouts are used with form 2.8, the readonly attribute is rendered twice. This has no practical consequence, but it breaks tests. This is the last fix required to make 2.7 green again.
    
    Commits
    -------
    
    75dc464 [Twig+FrameworkBundle] Fix forward compat with Form 2.8
Commits on Jul 23, 2015
  1. @nicolas-grekas
  2. @fabpot

    bug #15330 [Console] Fix console output with closed stdout (jakzal)

    fabpot authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Console] Fix console output with closed stdout
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15180
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    534d9fc [Console] Fix console output with closed stdout
  3. @fabpot

    bug #15339 [Serializer] Fix 2 bugs regarding private setters (dunglas)

    fabpot authored
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Serializer] Fix 2 bugs regarding private setters
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Fix two bugs reported in b5990be#commitcomment-12301266
    
    1. Arguments set in the constructor was not properly removed from `$data`
    2. `GetSetMethodNormalizer` was calling private setters, throwing an exception
    
    cc @StanAngeloff
    
    Commits
    -------
    
    65e9f26 [Serializer] Fix bugs reported in b5990be#commitcomment-12301266
  4. @fabpot

    minor #15317 [2.6] Static Code Analysis for Components (kalessil)

    fabpot authored
    This PR was squashed before being merged into the 2.6 branch (closes #15317).
    
    Discussion
    ----------
    
    [2.6] Static Code Analysis for Components
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Static Code Analysis with Php Inspections (EA Extended):
        - fixed couple potential issues when code is running in a phar-file
    
    Commits
    -------
    
    37a2353 [2.6] Static Code Analysis for Components
  5. @kalessil @fabpot

    [2.6] Static Code Analysis for Components

    kalessil authored fabpot committed
  6. @fabpot

    minor #15333 [Security] removed useless else condition in SwitchUserL…

    fabpot authored
    …istener class. (hhamon)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Security] removed useless else condition in SwitchUserListener class.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        |  ~
    
    Commits
    -------
    
    1fc0315 [Security] removed useless else condition in SwitchUserListener class.
  7. @fabpot

    minor #15338 [Security/Http] Fix test relying on a private property (…

    fabpot authored
    …nicolas-grekas)
    
    This PR was merged into the 2.6 branch.
    
    Discussion
    ----------
    
    [Security/Http] Fix test relying on a private property
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I'm not 100% sure what was tested by this, but this test was using a private property (`AnonymousToken->key`), that has been renamed to `secret` in later Sf versions.
    
    Commits
    -------
    
    2d29ac1 [Security/Http] Fix test relying on a private property
  8. @fabpot

    feature #15185 Implement resettable containers (stof)

    fabpot authored
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Implement resettable containers
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | small one
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13448
    | License       | MIT
    | Doc PR        | n/a
    
    This allows to release remove references to all services during shutdown, giving much more chances to destruct services and the container through refcounting rather than waiting GC, as it will break cycles between the container and container-aware services.
    
    There is a small BC break for a very edge case: if someone keeps a reference to the container and then shutdowns the kernel, the container would now be cleared and so would not work as intended anymore. But I don't think it is a supported use case. If you shutdown the kernel, the container of this kernel is released by the kernel and should not be used anymore IMO.
    Thus, shutting down the kernel generally does not happen except during tests on teardown.
    
    I'm not sure a doc PR is needed here: users of the fullstack framework should never use this feature (the kernel is using it for them). What do you think @weaverryan ?
    
    Commits
    -------
    
    4457745 Implement resettable containers
Commits on Jul 22, 2015
  1. @nicolas-grekas
  2. @dunglas
  3. @nicolas-grekas
  4. @nicolas-grekas
  5. @nicolas-grekas

    Fix merge

    nicolas-grekas authored
  6. @nicolas-grekas

    Merge branch '2.8'

    nicolas-grekas authored
    * 2.8: (27 commits)
      [2.8] Fix 3.0 incompatible deps
      [HttpKernel] Fix lowest dep
      [Security] fix check for empty usernames
      [Form] updated exception message of ButtonBuilder::setRequestHandler()
      [travis] Fix deps=high jobs
      Fix typo 'assets.package' => 'assets.packages' in UPGRADE-2.7
      [Serializer] Simplify AbstractNormalizer::prepareForDenormalization()
      [HttpFoundation] [PSR-7] Allow to use resources as content body and to return resources from string content
      [DependencyInjection] Forbid container cloning
      [HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3
      [WebProfilerBundle] Add link to show profile of latest request
      [DependencyInjection] Remove unused code in XmlFileLoader
      [HttpFoundation] Behaviour change in PHP7 for substr
      [Console] Set QuestionHelper max attempts in tests
      [Form] Fix a BC break in the entity
      fix broken ChoiceQuestion
      bumped Symfony version to 2.7.3
      updated VERSION for 2.7.2
      updated CHANGELOG for 2.7.2
      bumped Symfony version to 2.6.11
      ...
    
    Conflicts:
    	.travis.yml
    	CHANGELOG-2.3.md
    	CHANGELOG-2.6.md
    	CHANGELOG-2.7.md
    	UPGRADE-2.7.md
    	src/Symfony/Bridge/Twig/composer.json
    	src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTest.php
    	src/Symfony/Bundle/FrameworkBundle/composer.json
    	src/Symfony/Bundle/SecurityBundle/composer.json
    	src/Symfony/Component/Form/composer.json
    	src/Symfony/Component/HttpKernel/composer.json
Something went wrong with that request. Please try again.