Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 26, 2015
  1. Fabien Potencier

    minor #13800 [FrameworkBundle] Update assets configuration tests (jak…

    fabpot authored
    …zal)
    
    This PR was merged into the 3.0-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Update assets configuration tests
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Previously, assets where enabled if `templating` didn't contain asset configuration. This has been removed in #13666.
    
    Instead of enabling it back I propose to keep it disabled and update the tests instead, since we already discussed disabling all FrameworkBundle features by default for 3.0 (#13703).
    
    Commits
    -------
    
    5007b41 [Form] Replace use of bind() with submit() in a test.
    494e300 [SecurityBundle] Enable assets in functional tests.
    4c26875 [FrameworkBundle] Fix a default config test case and add a new one for enabling assets.
    b0f6a19 [FrameworkBundle] Remove a legacy test.
  2. Jakub Zalas
  3. Jakub Zalas
  4. Jakub Zalas
  5. Jakub Zalas
Commits on Feb 25, 2015
  1. Nicolas Grekas

    Merge branch '2.7'

    nicolas-grekas authored
    * 2.7:
      [Form] NativeRequestHandler file handling fix
      [VarDumper] Workaround stringy numeric keys
      [HttpKernel] Throw double-bounce exceptions
      [FrameworkBundle] silence E_USER_DEPRECATED in insulated clients
      [minor] composer.json fix
      [minor] composer.json fix
      Fixed absolute_url for absolute paths
      minor #13377 [Console] Change greater by greater or equal for isFresh in FileResource
      [2.3] [HttpFoundation] fixed param order for Nginx's x-accel-redirect
  2. Nicolas Grekas

    Merge branch '2.6' into 2.7

    nicolas-grekas authored
    * 2.6:
      [Form] NativeRequestHandler file handling fix
      [VarDumper] Workaround stringy numeric keys
      [HttpKernel] Throw double-bounce exceptions
      minor #13377 [Console] Change greater by greater or equal for isFresh in FileResource
      [2.3] [HttpFoundation] fixed param order for Nginx's x-accel-redirect
  3. Nicolas Grekas

    Merge branch '2.3' into 2.6

    nicolas-grekas authored
    * 2.3:
      [Form] NativeRequestHandler file handling fix
      [HttpKernel] Throw double-bounce exceptions
      minor #13377 [Console] Change greater by greater or equal for isFresh in FileResource
      [2.3] [HttpFoundation] fixed param order for Nginx's x-accel-redirect
  4. Fabien Potencier

    bug #13744 minor #13377 [Console] Change greater by greater or equal …

    fabpot authored
    …for isFresh in FileResource (bijibox)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    minor #13377 [Console] Change greater by greater or equal for isFresh in FileResource
    
    | Q             | A
    | ------------- | ---
    | Fixed tickets | #13377
    | License       | MIT
    
    FileResource and tests update
    
    Commits
    -------
    
    87800ae minor #13377 [Console] Change greater by greater or equal for isFresh in FileResource
  5. Fabien Potencier

    bug #13708 [2.3] [HttpFoundation] fixed param order for Nginx's x-acc…

    fabpot authored
    …el-mapping (phansys)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3] [HttpFoundation] fixed param order for Nginx's x-accel-mapping
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | kinda
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13502
    | License       | MIT
    | Doc PR        | n/a
    
    Inverted path and location directives for x-accel-mapping header (fixes #13502).
    
    Before:
    ```proxy_set_header X-Accel-Mapping /internal/=/var/www/example.com/```
    
    After:
    ```proxy_set_header X-Accel-Mapping /var/www/example.com/=/internal/```
    
    It could be a BC break since the response will fail if someone sends this header
    honoring the previous signature, thus I need some feedback in order to choose the right branch for this change.
    
    Commits
    -------
    
    9f9f230 [2.3] [HttpFoundation] fixed param order for Nginx's x-accel-redirect
  6. Fabien Potencier

    bug #13767 [HttpKernel] Throw double-bounce exceptions (nicolas-grekas)

    fabpot authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [HttpKernel] Throw double-bounce exceptions
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    0ebcf63 [HttpKernel] Throw double-bounce exceptions
  7. Fabien Potencier

    bug #13785 [VarDumper] Workaround stringy numeric keys (nicolas-grekas)

    fabpot authored
    This PR was merged into the 2.6 branch.
    
    Discussion
    ----------
    
    [VarDumper] Workaround stringy numeric keys
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13784
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    46bea3a [VarDumper] Workaround stringy numeric keys
  8. Fabien Potencier

    bug #13769 [Form] NativeRequestHandler file handling fix (mpajunen)

    fabpot authored
    This PR was squashed before being merged into the 2.3 branch (closes #13769).
    
    Discussion
    ----------
    
    [Form] NativeRequestHandler file handling fix
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13746
    | License       | MIT
    | Doc PR        | n/a
    
    `NativeRequestHandler` reused the local variable for the form name `$name` as a loop variable for processing the `$_FILES` array. A separate variable is now used.
    
    Two new test cases are included:
    - Handling a request with multiple files
    - Handling a request with file upload and a nameless form
    
    Both tests fail without the fix. The test cases could probably be better though.
    
    Commits
    -------
    
    9b3421f [Form] NativeRequestHandler file handling fix
  9. Mikael Pajunen Fabien Potencier

    [Form] NativeRequestHandler file handling fix

    mpajunen authored fabpot committed
  10. Nicolas Grekas
Commits on Feb 24, 2015
  1. Nicolas Grekas
  2. Nicolas Grekas

    Merge branch '2.6' into 2.7

    nicolas-grekas authored
    * 2.6:
      [FrameworkBundle] silence E_USER_DEPRECATED in insulated clients
  3. Nicolas Grekas

    Merge branch '2.3' into 2.6

    nicolas-grekas authored
    * 2.3:
      [FrameworkBundle] silence E_USER_DEPRECATED in insulated clients
  4. Fabien Potencier

    bug #13779 [FrameworkBundle] silence E_USER_DEPRECATED in insulated c…

    fabpot authored
    …lients (nicolas-grekas)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] silence E_USER_DEPRECATED in insulated clients
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    7558c23 [FrameworkBundle] silence E_USER_DEPRECATED in insulated clients
  5. Nicolas Grekas
  6. Fabien Potencier

    bug #13745 Fixed absolute_url for absolute paths (florianv)

    fabpot authored
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fixed absolute_url for absolute paths
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13724
    | License       | MIT
    
    The issue is that `asset()` and `absolute_url()` cannot be composed because `asset()` already returns an absolute path (using the `PathPackage`) and `absolute_url()` still prepends the base path. So the resulting url contains the base path twice.
    
    So this PR removes appending the base path to absolute paths (starting with `/`) passed to `absolute_url()`.
    
    Commits
    -------
    
    08aa7bc Fixed absolute_url for absolute paths
  7. Nicolas Grekas

    Merge branch '2.6' into 2.7

    nicolas-grekas authored
    * 2.6:
      [minor] composer.json fix
      [minor] composer.json fix
    
    Conflicts:
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/Templating/composer.json
  8. Nicolas Grekas
  9. Nicolas Grekas

    Merge branch '2.3' into 2.6

    nicolas-grekas authored
    * 2.3:
      [minor] composer.json fix
    
    Conflicts:
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/Templating/composer.json
  10. Nicolas Grekas
  11. Nicolas Grekas

    Merge branch '2.7'

    nicolas-grekas authored
    * 2.7:
      Minor hot fix
      [PROCESS] make sure /dev/tty is readable
      [PhpUnitBridge] Allow PHP 5.3.3 to use with Symfony 2.3
      [2.3] require-dev PHPUnit bridge
      [FrameworkBundle] Fixed Shell logo
      [2.3] Update CONTRIBUTING.md
      [2.3][Process] Fixed PhpProcess::getCommandLine() result
      [Debug] Deprecations exception for Symfony internals
      [Console] explicit assertion for ArgvInput::getFirstArgument() with no arguments
      [PropertyAccess] unify and fix doc
      Enforce UTF-8 charset for core controllers
      Fix the toolbar JS for IE
    
    Conflicts:
    	.travis.yml
    	src/Symfony/Bridge/PhpUnit/composer.json
  12. Florian Voutzinos
  13. Nicolas Grekas

    Merge branch '2.6' into 2.7

    nicolas-grekas authored
    * 2.6:
      Minor hot fix
      [PROCESS] make sure /dev/tty is readable
      [2.3] require-dev PHPUnit bridge
      [FrameworkBundle] Fixed Shell logo
      [2.3] Update CONTRIBUTING.md
      [2.3][Process] Fixed PhpProcess::getCommandLine() result
      [Console] explicit assertion for ArgvInput::getFirstArgument() with no arguments
      [PropertyAccess] unify and fix doc
      Enforce UTF-8 charset for core controllers
      Fix the toolbar JS for IE
    
    Conflicts:
    	.travis.yml
    	src/Symfony/Bridge/Doctrine/composer.json
    	src/Symfony/Bridge/Monolog/composer.json
    	src/Symfony/Bridge/Propel1/composer.json
    	src/Symfony/Bridge/ProxyManager/composer.json
    	src/Symfony/Bridge/Swiftmailer/composer.json
    	src/Symfony/Bridge/Twig/composer.json
    	src/Symfony/Bundle/DebugBundle/composer.json
    	src/Symfony/Bundle/FrameworkBundle/composer.json
    	src/Symfony/Bundle/SecurityBundle/composer.json
    	src/Symfony/Bundle/TwigBundle/composer.json
    	src/Symfony/Bundle/WebProfilerBundle/composer.json
    	src/Symfony/Component/Asset/Exception/ExceptionInterface.php
    	src/Symfony/Component/Asset/Exception/LogicException.php
    	src/Symfony/Component/BrowserKit/composer.json
    	src/Symfony/Component/ClassLoader/composer.json
    	src/Symfony/Component/Console/composer.json
    	src/Symfony/Component/Debug/composer.json
    	src/Symfony/Component/DependencyInjection/composer.json
    	src/Symfony/Component/DomCrawler/composer.json
    	src/Symfony/Component/EventDispatcher/composer.json
    	src/Symfony/Component/Form/composer.json
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/HttpKernel/composer.json
    	src/Symfony/Component/Intl/composer.json
    	src/Symfony/Component/Routing/composer.json
    	src/Symfony/Component/Security/Acl/composer.json
    	src/Symfony/Component/Security/Core/composer.json
    	src/Symfony/Component/Security/Csrf/composer.json
    	src/Symfony/Component/Security/Http/composer.json
    	src/Symfony/Component/Security/composer.json
    	src/Symfony/Component/Templating/composer.json
    	src/Symfony/Component/Translation/composer.json
    	src/Symfony/Component/Validator/composer.json
  14. Nicolas Grekas

    Merge branch '2.3' into 2.6

    nicolas-grekas authored
    * 2.3:
      Minor hot fix
      [PROCESS] make sure /dev/tty is readable
      [2.3] require-dev PHPUnit bridge
      [FrameworkBundle] Fixed Shell logo
      [2.3] Update CONTRIBUTING.md
      [2.3][Process] Fixed PhpProcess::getCommandLine() result
      [Console] explicit assertion for ArgvInput::getFirstArgument() with no arguments
      Enforce UTF-8 charset for core controllers
    
    Conflicts:
    	CONTRIBUTING.md
    	src/Symfony/Bridge/Monolog/composer.json
    	src/Symfony/Bundle/FrameworkBundle/composer.json
    	src/Symfony/Bundle/SecurityBundle/composer.json
    	src/Symfony/Bundle/TwigBundle/Controller/ExceptionController.php
    	src/Symfony/Bundle/WebProfilerBundle/Controller/ProfilerController.php
    	src/Symfony/Component/Console/composer.json
    	src/Symfony/Component/Debug/composer.json
    	src/Symfony/Component/DomCrawler/composer.json
    	src/Symfony/Component/EventDispatcher/composer.json
    	src/Symfony/Component/HttpFoundation/composer.json
    	src/Symfony/Component/Security/composer.json
    	src/Symfony/Component/Templating/composer.json
  15. Nicolas Grekas

    Minor hot fix

    nicolas-grekas authored
  16. Fabien Potencier

    minor #13772 [2.3] require-dev PHPUnit bridge (nicolas-grekas)

    fabpot authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [2.3] require-dev PHPUnit bridge
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    8b02796 [2.3] require-dev PHPUnit bridge
  17. Fabien Potencier

    bug #13715 Enforce UTF-8 charset for core controllers (WouterJ)

    fabpot authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    Enforce UTF-8 charset for core controllers
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #7532
    | License       | MIT
    | Doc PR        | -
    
    See #7617 and #7532 for the context of this PR.
    
    Commits
    -------
    
    3032014 Enforce UTF-8 charset for core controllers
  18. Fabien Potencier

    bug #13768 [Debug] Deprecations exception for Symfony internals (nico…

    fabpot authored
    …las-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Debug] Deprecations exception for Symfony internals
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13764
    | License       | MIT
    | Doc PR        | -
    
    Allowing 1st level check of the `Symfony\` namespace prevents trigerring deprecation notices for internal things, but keeps notices enabled for `Symfony\Cmf\` classes
    
    Commits
    -------
    
    323e957 [Debug] Deprecations exception for Symfony internals
  19. Fabien Potencier

    feature #13756 [3.0][Console] Added type hint (francisbesset)

    fabpot authored
    This PR was submitted for the 2.7 branch but it was merged into the 3.0-dev branch instead (closes #13756).
    
    Discussion
    ----------
    
    [3.0][Console] Added type hint
    
    The method `Symfony\Component\Console\Application::renderException()` have 2 parameters not type hint but the PHPDoc reveal types.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    e98c537 [Console] Added type hint
  20. Francis Besset Fabien Potencier

    [Console] Added type hint

    francisbesset authored fabpot committed
Something went wrong with that request. Please try again.