Permalink
Commits on Feb 22, 2017
  1. feature #21718 [SecurityBundle] Don't normalize username of in-memory…

    … users (chalasr)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [SecurityBundle] Don't normalize username of in-memory users
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    It's common to have e.g. emails as keys in `security.providers.in_memory.users` since keys are username. Actually they are normalized so `foo-bar@gmail.com` becomes `foo_bar@gmail.com` and authentication fails unexpectedly.
    
    Commits
    -------
    
    8d03332 [SecurityBundle] Don't normalize keys of in-memory users
    fabpot committed Feb 22, 2017
  2. [SecurityBundle] Don't normalize keys of in-memory users

    chalasr committed Feb 22, 2017
  3. feature #20107 Added a build method to the kernel to replace Bundle::…

    …build() (iltar)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    Added a build method to the kernel to replace Bundle::build()
    
    | Q | A |
    | --- | --- |
    | Branch? | master |
    | Bug fix? | no |
    | New feature? | yes |
    | BC breaks? | no |
    | Deprecations? | no |
    | Tests pass? | yes |
    | Fixed tickets | #20099 |
    | License | MIT |
    | Doc PR | ~ |
    
    Adds a DX method to make it easier to omit using an AppBundle in your application.
    
    **Old situation**
    
    ``` php
    // src/AppBundle.php
    class AppBundle extends Bundle
    {
        public function build(ContainerBuilder $container)
        {
            $container->addCompilerPass(new SomeCompilerPass());
            $container->addCompilerPass(new AnotherCompilerPass());
            $container->addCompilerPass(new YetAnotherCompilerPass());
        }
    }
    
    // src/DependencyInjection/AppExtension.php
    class AppExtension extends Extension
    {
        public function load(array $config, ContainerBuilder $container)
        {
            $binary = ExecutableResolver::getPath($container->getParameter('kernel.root_dir').'/../');
            $snappyConfig = ['pdf' => ['binary' => realpath($binary)]];
    
            $container->prependExtensionConfig('knp_snappy', $snappyConfig);
        }
    }
    ```
    
    **New situation**
    
    ``` php
    // rm src/AppBundle.php
    // rm src/DependencyInjection/AppExtension.php
    
    // app/AppKernel.php
    class AppKernel extends Kernel
    {
        protected function build(ContainerBuilder $container)
        {
            $binary = ExecutableResolver::getPath($container->getParameter('kernel.root_dir').'/../');
            $snappyConfig = ['pdf' => ['binary' => realpath($binary)]];
    
            $container->prependExtensionConfig('knp_snappy', $snappyConfig);
            $container->addCompilerPass(new SomeCompilerPass());
            $container->addCompilerPass(new AnotherCompilerPass());
            $container->addCompilerPass(new YetAnotherCompilerPass());
        }
    }
    ```
    
    Still missing tests, wondering if worth adding in this state first.
    
    Commits
    -------
    
    62e80fc Added build and class cache to kernel
    fabpot committed Feb 22, 2017
  4. Added build and class cache to kernel

    iltar committed Nov 30, 2016
  5. Merge branch '3.2'

    * 3.2:
      fixed bad merge
    fabpot committed Feb 22, 2017
  6. fixed bad merge

    fabpot committed Feb 22, 2017
  7. Merge branch '3.2'

    * 3.2:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  8. Merge branch '2.8' into 3.2

    * 2.8:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  9. Merge branch '2.7' into 2.8

    * 2.7:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  10. bug #21679 [SecurityBundle] fix priority ordering of security voters …

    …(xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] fix priority ordering of security voters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21660
    | License       | MIT
    | Doc PR        |
    
    Could be updated in the `3.2` branch to make use of the `PriorityTaggedServiceTrait `.
    
    Commits
    -------
    
    dcd19f3 fix priority ordering of security voters
    fabpot committed Feb 22, 2017
Commits on Feb 21, 2017
  1. Merge branch '3.2'

    * 3.2:
      fix phpunit bridge tests
    nicolas-grekas committed Feb 21, 2017
  2. fix phpunit bridge tests

    nicolas-grekas committed Feb 21, 2017
  3. Merge branch '3.2'

    * 3.2:
      fix deps
    nicolas-grekas committed Feb 21, 2017
  4. fix deps

    nicolas-grekas committed Feb 21, 2017
  5. Merge branch '3.2'

    * 3.2:
      fix deps
      [DoctrineBridge] Fixed validating custom doctrine type columns
    nicolas-grekas committed Feb 21, 2017
  6. Merge branch '2.8' into 3.2

    * 2.8:
      fix deps
    nicolas-grekas committed Feb 21, 2017
  7. fix deps

    nicolas-grekas committed Feb 21, 2017
  8. bug #21656 [DoctrineBridge] Fixed validating custom doctrine type col…

    …umns (dmaicher)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [DoctrineBridge] Fixed validating custom doctrine type columns
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21619
    | License       | MIT
    | Doc PR        | -
    
    This fixes #21619 by not assuming the invalid `$value` is a Doctrine entity if its an object
    
    Commits
    -------
    
    ad59370 [DoctrineBridge] Fixed validating custom doctrine type columns
    fabpot committed Feb 21, 2017
  9. Merge branch '3.2'

    * 3.2:
      Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  10. Merge branch '2.8' into 3.2

    * 2.8:
      Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  11. Merge branch '2.7' into 2.8

    * 2.7:
      Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  12. minor #21698 Use PHPUnit 6.0 on PHP 7.* test lines (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Use PHPUnit 6.0 on PHP 7.* test lines
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | need #21694 first
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    96ecd3c Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017
  13. Use PHPUnit 6.0 on PHP 7.* test lines

    nicolas-grekas committed Feb 21, 2017
  14. Fix phpunit-bridge blacklist

    nicolas-grekas committed Feb 21, 2017
  15. fix

    nicolas-grekas committed Feb 21, 2017
  16. Fix 5.3 compat of SymfonyTestsListener

    nicolas-grekas committed Feb 21, 2017
  17. feature #21694 [Bridge/PhpUnit] Add PHPUnit 6 support (nicolas-grekas)

    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [Bridge/PhpUnit] Add PHPUnit 6 support
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21125
    | License       | MIT
    | Doc PR        | -
    
    This PR makes our phpunit bridge compatible with all namespaced versions of phpunit, from 4.8.35 to 6.
    It takes another approach than #21668 and #21221, thus replaces them.
    Tested locally : tests pass when using phpunit 5.7, and fails with v6.0 because our own test suite is not yet compatible with it - but at least it runs nice.
    If this were handled as usual Symfony component, we would consider some changes to be BC breaks. But in this specific case - a phpunit bridge - it makes no sense to me to apply the bc policy here. I added `@final` and `@internal` annotations to make this clearer.
    
    Commits
    -------
    
    9e0745c [Bridge/PhpUnit] Add PHPUnit 6 support
    nicolas-grekas committed Feb 21, 2017
  18. minor #21697 Refactored other PHPUnit method calls to work with names…

    …paced PHPUnit 6 (peterrehm)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Continued work to make Symfony PHPUnit 6 compatible.
    
    Commits
    -------
    
    e9f3faf Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    nicolas-grekas committed Feb 21, 2017
  19. Refactored other PHPUnit method calls to work with namespaced PHPUnit 6

    peterrehm committed Feb 21, 2017
  20. Merge branch '3.2'

    * 3.2:
      Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
      Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
      Further refactorings to PHPUnit namespaces
      resolve parameters in definition classes
    nicolas-grekas committed Feb 21, 2017
  21. minor #21696 Refactored other PHPUnit method calls to work with names…

    …paced PHPUnit 6 (peterrehm)
    
    This PR was squashed before being merged into the 3.2 branch (closes #21696).
    
    Discussion
    ----------
    
    Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Continued work to make Symfony PHPUnit 6 compatible.
    
    Commits
    -------
    
    9eeec8d Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    nicolas-grekas committed Feb 21, 2017
  22. Merge branch '2.8' into 3.2

    * 2.8:
      Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
      Further refactorings to PHPUnit namespaces
      resolve parameters in definition classes
    nicolas-grekas committed Feb 21, 2017
  23. minor #21695 Refactored other PHPUnit method calls to work with names…

    …paced PHPUnit 6 (peterrehm)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Continued work to make Symfony PHPUnit 6 compatible.
    
    Commits
    -------
    
    dbe8898 Refactored other PHPUnit method calls to work with namespaced PHPUnit 6
    nicolas-grekas committed Feb 21, 2017
  24. Refactored other PHPUnit method calls to work with namespaced PHPUnit 6

    peterrehm committed Feb 21, 2017