Permalink
Commits on Feb 24, 2017
  1. Merge branch '3.2'

    * 3.2:
      Revamped the README file
      Fix missing namespace in AddConstraintValidatorPassTest
      [SecurityBundle] simplified code
      [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 24, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      Revamped the README file
      Fix missing namespace in AddConstraintValidatorPassTest
      [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 24, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Revamped the README file
      Fix missing namespace in AddConstraintValidatorPassTest
      [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 24, 2017
  4. minor #21744 Revamped the README file (javiereguiluz)

    This PR was squashed before being merged into the 2.7 branch (closes #21744).
    
    Discussion
    ----------
    
    Revamped the README file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21235
    | License       | MIT
    | Doc PR        |
    
    Here is a before/after comparison image:
    
    ![before-after-readme](https://cloud.githubusercontent.com/assets/73419/23294444/cb001e9a-fa6b-11e6-88f2-a8449470fb4e.png)
    
    Commits
    -------
    
    c7d30ca Revamped the README file
    fabpot committed Feb 24, 2017
  5. Revamped the README file

    javiereguiluz committed with fabpot Feb 23, 2017
Commits on Feb 23, 2017
  1. minor #21740 Fix missing namespace in test (chalasr)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Fix missing namespace in test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Tests pass?   | yes
    
    Commits
    -------
    
    1e9ca7b Fix missing namespace in AddConstraintValidatorPassTest
    nicolas-grekas committed Feb 23, 2017
  2. Fix missing namespace in AddConstraintValidatorPassTest

    chalasr committed Feb 23, 2017
  3. fixed typo

    fabpot committed Feb 23, 2017
  4. bug #21736 [Config] fixed glob file loader when there is an exception…

    … (fabpot)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [Config] fixed glob file loader when there is an exception
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Fixes a typo. When importing a glob, we definitely want to have errors like syntax errors in a YAML file.
    
    Commits
    -------
    
    d1b6601 [Config] fixed glob file loader when there is an exception
    fabpot committed Feb 23, 2017
  5. [Config] fixed glob file loader when there is an exception

    fabpot committed Feb 23, 2017
  6. minor #21729 [UPGRADE guide] Merged duplicated SecurityBundle section…

    … and ordered alphabetically (wouterj)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [UPGRADE guide] Merged duplicated SecurityBundle section and ordered alphabetically
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | -
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    67c3107 Merge duplicated SecurityBundle section and order alphabetically
    nicolas-grekas committed Feb 23, 2017
  7. Merge duplicated SecurityBundle section and order alphabetically

    wouterj committed on GitHub Feb 23, 2017
  8. minor #21709 [SecurityBundle] simplified code (fabpot)

    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] simplified code
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Simplified code for 3.2 (followup to #21679)
    
    Commits
    -------
    
    512742b [SecurityBundle] simplified code
    fabpot committed Feb 23, 2017
  9. [SecurityBundle] simplified code

    fabpot committed Feb 22, 2017
Commits on Feb 22, 2017
  1. feature #21718 [SecurityBundle] Don't normalize username of in-memory…

    … users (chalasr)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [SecurityBundle] Don't normalize username of in-memory users
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    It's common to have e.g. emails as keys in `security.providers.in_memory.users` since keys are username. Actually they are normalized so `foo-bar@gmail.com` becomes `foo_bar@gmail.com` and authentication fails unexpectedly.
    
    Commits
    -------
    
    8d03332 [SecurityBundle] Don't normalize keys of in-memory users
    fabpot committed Feb 22, 2017
  2. bug #21722 [ExpressionLanguage] Registering functions after calling e…

    …valuate(), compile() or parse() is not supported (maidmaid)
    
    This PR was squashed before being merged into the 2.7 branch (closes #21722).
    
    Discussion
    ----------
    
    [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    If we add expr. function after first eval/compile like this:
    
    ```php
    $el = new ExpressionLanguage();
    $el->evaluate('1 + 1');
    $el->addFunction(new ExpressionFunction('fn', function () {}, function () {}));
    $el->evaluate('fn()');
    ```
    A ``SyntaxError`` is thrown that says ``The function "fn" does not exist around position 1.``. It's the same bug with ``$el->compile('fn()')``.
    
    This PR fixes this (duplicate of #21098 that was closed).
    
    Commits
    -------
    
    e305369 [ExpressionLanguage] Registering functions after calling evaluate(), compile() or parse() is not supported
    fabpot committed Feb 22, 2017
  3. [ExpressionLanguage] Registering functions after calling evaluate(), …

    …compile() or parse() is not supported
    maidmaid committed with fabpot Dec 29, 2016
  4. [SecurityBundle] Don't normalize keys of in-memory users

    chalasr committed Feb 22, 2017
  5. feature #20107 Added a build method to the kernel to replace Bundle::…

    …build() (iltar)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    Added a build method to the kernel to replace Bundle::build()
    
    | Q | A |
    | --- | --- |
    | Branch? | master |
    | Bug fix? | no |
    | New feature? | yes |
    | BC breaks? | no |
    | Deprecations? | no |
    | Tests pass? | yes |
    | Fixed tickets | #20099 |
    | License | MIT |
    | Doc PR | ~ |
    
    Adds a DX method to make it easier to omit using an AppBundle in your application.
    
    **Old situation**
    
    ``` php
    // src/AppBundle.php
    class AppBundle extends Bundle
    {
        public function build(ContainerBuilder $container)
        {
            $container->addCompilerPass(new SomeCompilerPass());
            $container->addCompilerPass(new AnotherCompilerPass());
            $container->addCompilerPass(new YetAnotherCompilerPass());
        }
    }
    
    // src/DependencyInjection/AppExtension.php
    class AppExtension extends Extension
    {
        public function load(array $config, ContainerBuilder $container)
        {
            $binary = ExecutableResolver::getPath($container->getParameter('kernel.root_dir').'/../');
            $snappyConfig = ['pdf' => ['binary' => realpath($binary)]];
    
            $container->prependExtensionConfig('knp_snappy', $snappyConfig);
        }
    }
    ```
    
    **New situation**
    
    ``` php
    // rm src/AppBundle.php
    // rm src/DependencyInjection/AppExtension.php
    
    // app/AppKernel.php
    class AppKernel extends Kernel
    {
        protected function build(ContainerBuilder $container)
        {
            $binary = ExecutableResolver::getPath($container->getParameter('kernel.root_dir').'/../');
            $snappyConfig = ['pdf' => ['binary' => realpath($binary)]];
    
            $container->prependExtensionConfig('knp_snappy', $snappyConfig);
            $container->addCompilerPass(new SomeCompilerPass());
            $container->addCompilerPass(new AnotherCompilerPass());
            $container->addCompilerPass(new YetAnotherCompilerPass());
        }
    }
    ```
    
    Still missing tests, wondering if worth adding in this state first.
    
    Commits
    -------
    
    62e80fc Added build and class cache to kernel
    fabpot committed Feb 22, 2017
  6. Added build and class cache to kernel

    iltar committed Nov 30, 2016
  7. Merge branch '3.2'

    * 3.2:
      fixed bad merge
    fabpot committed Feb 22, 2017
  8. fixed bad merge

    fabpot committed Feb 22, 2017
  9. Merge branch '3.2'

    * 3.2:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  10. Merge branch '2.8' into 3.2

    * 2.8:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  11. Merge branch '2.7' into 2.8

    * 2.7:
      fix priority ordering of security voters
    fabpot committed Feb 22, 2017
  12. bug #21679 [SecurityBundle] fix priority ordering of security voters …

    …(xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] fix priority ordering of security voters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21660
    | License       | MIT
    | Doc PR        |
    
    Could be updated in the `3.2` branch to make use of the `PriorityTaggedServiceTrait `.
    
    Commits
    -------
    
    dcd19f3 fix priority ordering of security voters
    fabpot committed Feb 22, 2017
Commits on Feb 21, 2017
  1. Merge branch '3.2'

    * 3.2:
      fix phpunit bridge tests
    nicolas-grekas committed Feb 21, 2017
  2. fix phpunit bridge tests

    nicolas-grekas committed Feb 21, 2017
  3. Merge branch '3.2'

    * 3.2:
      fix deps
    nicolas-grekas committed Feb 21, 2017
  4. fix deps

    nicolas-grekas committed Feb 21, 2017
  5. Merge branch '3.2'

    * 3.2:
      fix deps
      [DoctrineBridge] Fixed validating custom doctrine type columns
    nicolas-grekas committed Feb 21, 2017
  6. Merge branch '2.8' into 3.2

    * 2.8:
      fix deps
    nicolas-grekas committed Feb 21, 2017
  7. fix deps

    nicolas-grekas committed Feb 21, 2017
  8. bug #21656 [DoctrineBridge] Fixed validating custom doctrine type col…

    …umns (dmaicher)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [DoctrineBridge] Fixed validating custom doctrine type columns
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21619
    | License       | MIT
    | Doc PR        | -
    
    This fixes #21619 by not assuming the invalid `$value` is a Doctrine entity if its an object
    
    Commits
    -------
    
    ad59370 [DoctrineBridge] Fixed validating custom doctrine type columns
    fabpot committed Feb 21, 2017
  9. Merge branch '3.2'

    * 3.2:
      Use PHPUnit 6.0 on PHP 7.* test lines
    nicolas-grekas committed Feb 21, 2017