Skip to content
This repository

Jul 09, 2014

  1. Fabien Potencier

    feature #10960 [Filesystem] Throw Exception on copying from an unread…

    …able file or to an unwritable file (djotto)
    
    This PR was squashed before being merged into the 2.6-dev branch (closes #10960).
    
    Discussion
    ----------
    
    [Filesystem] Throw Exception on copying from an unreadable file or to an unwritable file
    
    | Q  | A |
    | ------------- | ------------- |
    | Bug fix?  | No  |
    | New feature?  | No  |
    | BC breaks? | No |
    | Deprecations? | No |
    | Tests pass? | Yes |
    | Fixed tickets | |
    | License | MIT |
    
    In certain circumstances (overwrite set to true, target file not writable), Filesystem->copy() would return success even though the file was not successfully copied. Unit tests included.
    
    Commits
    -------
    
    cd5da9b [Filesystem] Throw Exception on copying from an unreadable file or to an unwritable file
    fabpot authored
  2. David Otton

    [Filesystem] Throw Exception on copying from an unreadable file or to…

    … an unwritable file
    djotto authored fabpot committed
  3. Fabien Potencier

    feature #11212 [HttpFoundation] Added a switch to delete file after t…

    …he response is send (WybrenKoelmans)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Added a switch to delete file after the response is send
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#3975
    
    I have not done any Unit Tests for this code as I suspect there may already be a way to solve my problem of deleting a file after the request was sent. Is it possible to use `sendContent` and delete the file after that? My attempts were unsuccessful.
    
    If this code is desirable, please assist me in how I would write an unit test for this. Thanks.
    
    TODO:
    - [x] Add unit tests
    - [x] Update documentation
    - [x] Mention that using `X-Sendfile` will overwrite deleteFileAfterSend
    
    Commits
    -------
    
    1fff158 [HttpFoundation] Added a switch to delete file after the response is send
    fabpot authored
  4. Fabien Potencier

    Merge branch '2.5'

    * 2.5:
      added missing test
      fixed CS
      [HttpFoundation] Remove content-related headers if content is empty
      bumped Symfony version to 2.5.2
      bumped Symfony version to 2.4.8
      updated VERSION for 2.5.1
      updated CHANGELOG for 2.5.1
      removed defaults from PHPUnit configuration
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot authored
  5. Fabien Potencier

    Merge branch '2.4' into 2.5

    * 2.4:
      added missing test
      fixed CS
      [HttpFoundation] Remove content-related headers if content is empty
      bumped Symfony version to 2.4.8
      removed defaults from PHPUnit configuration
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot authored
  6. Fabien Potencier

    added missing test

    fabpot authored
  7. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      fixed CS
      [HttpFoundation] Remove content-related headers if content is empty
      removed defaults from PHPUnit configuration
    fabpot authored
  8. Fabien Potencier

    fixed CS

    fabpot authored
  9. Simon Schick

    [HttpFoundation] Remove content-related headers if content is empty

    SimonSimCity authored fabpot committed

Jul 08, 2014

  1. Fabien Potencier

    feature #11210 [FrameworkBundle] Improving bad bundle exception in _c…

    …ontroller (weaverryan)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Improving bad bundle exception in _controller
    
    ...ntroller in a routeHi guys!
    
    This improves the exception message when you use a bad bundle name in the `_controller` syntax in a routing file. Here is the before and after of the message with this mistake (real bundle is `KnpUniversityBundle`):
    
    ```yaml
    some_route:
        pattern:  /
        defaults: { _controller: "Knp2UniversityBundle:Course:index" }
    ```
    
    ![screen shot 2014-06-23 at 9 27 55 pm](https://cloud.githubusercontent.com/assets/121003/3367065/448e8298-fb54-11e3-92ea-9bf04510cb6d.png)
    
    ![screen shot 2014-06-23 at 9 48 14 pm](https://cloud.githubusercontent.com/assets/121003/3367063/3c79cf36-fb54-11e3-87c4-29428248ee47.png)
    
    Notice the before and after behavior is the same `InvalidArgumentException` (just a different message).
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Catching the plain `InvalidArgumentException` from `Kernel::getBundles()` seems a bit "loose". Should we consider creating a new exception (e.g. `BundleDoesNotExistException`) that extends `InvalidArgumentException` and throw it from inside `Kernel::getBundles`? This would allow us to catch more precisely, and it seems like it would be BC.
    
    Suggestions and thoughts warmly welcome!
    
    Thanks!
    
    Commits
    -------
    
    f9b88c6 Improving the exception message when the bundle name is wrong for the controller in a route
    fabpot authored
  2. Fabien Potencier

    feature #11135 [FrameworkBundle] Use ProcessHelper for server:run com…

    …mand (romainneutron)
    
    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Use ProcessHelper for server:run command
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    
    Let's use our new process helper :)
    
    Commits
    -------
    
    6ca1c90 [FrameworkBundle] Use ProcessHelper for server:run command
    a5f36a8 [Console] Add threshold for ProcessHelper verbosity
    fabpot authored
  3. Fabien Potencier

    feature #11318 [WIP][Form] Improve transformation failure message by …

    …providing property path (jubianchi)
    
    This PR was squashed before being merged into the 2.6-dev branch (closes #11318).
    
    Discussion
    ----------
    
    [WIP][Form] Improve transformation failure message by providing property path
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   |
    | Fixed tickets | #11287
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    d56b7be [WIP][Form] Improve transformation failure message by providing property path
    fabpot authored
  4. Julien BIANCHI

    [WIP][Form] Improve transformation failure message by providing prope…

    …rty path
    jubianchi authored fabpot committed
  5. Fabien Potencier

    minor #11344 remove defaults from PHPUnit configuration (craue)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    remove defaults from PHPUnit configuration
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | --
    | License       | MIT
    | Doc PR        | --
    
    Follow-up to #11329.
    
    Commits
    -------
    
    afc4930 removed defaults from PHPUnit configuration
    fabpot authored
  6. Fabien Potencier

    bumped Symfony version to 2.5.2

    fabpot authored
  7. Fabien Potencier

    bumped Symfony version to 2.4.8

    fabpot authored
  8. Fabien Potencier

    updated VERSION for 2.5.1

    fabpot authored
  9. Fabien Potencier

    Merge branch '2.5'

    * 2.5:
      updated VERSION for 2.4.7
      updated CHANGELOG for 2.4.7
      bumped Symfony version to 2.3.18
      updated VERSION for 2.3.17
      update CONTRIBUTORS for 2.3.17
      updated CHANGELOG for 2.3.17
      added XSD to PHPUnit configuration
      fix the return types
      add missing docblock for ProcessBuilder::addEnvironmentVariables()
      bug #11319 [HttpKernel] Ensure the storage exists before purging it in ProfilerTest
      [Translation] Added unescaping of ids in PoFileLoader
      updated italian translation for validation messages
      [DomCrawler] Fix docblocks and formatting.
      [DomCrawler] Remove the query string and the anchor of the uri of a link
      Simplified the Travis test command
      Remove Expression Language services when the component is unavailable
      Added SK translations
      [Console] Make sure formatter is the same
    fabpot authored
  10. Fabien Potencier

    Merge branch '2.4' into 2.5

    * 2.4:
      updated VERSION for 2.4.7
      updated CHANGELOG for 2.4.7
      bumped Symfony version to 2.3.18
      updated VERSION for 2.3.17
      update CONTRIBUTORS for 2.3.17
      updated CHANGELOG for 2.3.17
      added XSD to PHPUnit configuration
      add missing docblock for ProcessBuilder::addEnvironmentVariables()
      bug #11319 [HttpKernel] Ensure the storage exists before purging it in ProfilerTest
      [Translation] Added unescaping of ids in PoFileLoader
      updated italian translation for validation messages
      [DomCrawler] Fix docblocks and formatting.
      [DomCrawler] Remove the query string and the anchor of the uri of a link
      Simplified the Travis test command
      Remove Expression Language services when the component is unavailable
      [Console] Make sure formatter is the same
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot authored
  11. Fabien Potencier

    updated VERSION for 2.4.7

    fabpot authored
  12. Fabien Potencier

    Merge branch '2.3' into 2.4

    * 2.3:
      bumped Symfony version to 2.3.18
      updated VERSION for 2.3.17
      update CONTRIBUTORS for 2.3.17
      updated CHANGELOG for 2.3.17
      added XSD to PHPUnit configuration
      bug #11319 [HttpKernel] Ensure the storage exists before purging it in ProfilerTest
      [Translation] Added unescaping of ids in PoFileLoader
      updated italian translation for validation messages
      [DomCrawler] Fix docblocks and formatting.
      [DomCrawler] Remove the query string and the anchor of the uri of a link
      Simplified the Travis test command
      [Console] Make sure formatter is the same
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot authored
  13. Fabien Potencier

    bumped Symfony version to 2.3.18

    fabpot authored

Jul 07, 2014

  1. Fabien Potencier

    updated VERSION for 2.3.17

    fabpot authored
  2. Christian Raue

    removed defaults from PHPUnit configuration

    craue authored
  3. Christian Raue

    added XSD to PHPUnit configuration

    craue authored fabpot committed
  4. Fabien Potencier

    minor #11328 Make @inheritdoc consistent (lowercase) (hacfi)

    This PR was merged into the 2.6-dev branch.
    
    Discussion
    ----------
    
    Make @inheritdoc consistent (lowercase)
    
    See symfony/symfony#10713
    
    | Q             | A
    | ------------- | ---
    | License       | MIT
    
    Commits
    -------
    
    aae45ad Make @inheritdoc consistent (lowercase)
    fabpot authored

Jul 06, 2014

  1. Christian Flothmann

    fix the return types

    xabbuh authored
  2. Christian Flothmann

    add missing docblock for ProcessBuilder::addEnvironmentVariables()

    xabbuh authored
  3. Jakub Zalas

    [Debug] Fix tests on PHP 5.6

    jakzal authored
  4. Romain Neutron

    [FrameworkBundle] Use ProcessHelper for server:run command

  5. Romain Neutron

    [Console] Add threshold for ProcessHelper verbosity

Jul 05, 2014

  1. hacfi

    Make @inheritdoc consistent (lowercase)

    hacfi authored
  2. Christian López Espínola

    bug #11319 [HttpKernel] Ensure the storage exists before purging it i…

    …n ProfilerTest
    penyaskito authored
  3. Ryan Weaver

    Improving the exception message when the bundle name is wrong for the…

    … controller in a route
    
    Usually, it is wrong because you've chosen the wrong bundle name in your _controller syntax.
    But this also tries to imply that you *might* be missing your bundle initialization in AppKernel
    (though I think this is much much less common).
    weaverryan authored

Jul 04, 2014

  1. Wybren Koelmans

    [HttpFoundation] Added a switch to delete file after the response is …

    …send
Something went wrong with that request. Please try again.