Permalink
Commits on Sep 28, 2016
  1. [FrameworkBundle] removed the Translation component dependency on Fra…

    …meworkBundle
    fabpot committed Sep 28, 2016
  2. bug #20066 [FrameworkBundle] fix yaml:lint when yaml is not installed…

    … along side framework-bundle (fabpot)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] fix yaml:lint when yaml is not installed along side framework-bundle
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    YAML is not an explicit dependency of FrameworkBundle. If it is not installed, the console is broken as the yaml:lint commands tries to extends the one in the YAML component. This bug only exists in master as this refactoring happened in 3.2
    
    Commits
    -------
    
    b1c5a68 [FrameworkBundle] fixed yaml:lint when yaml is not installed along side framwork-bundle
    fabpot committed Sep 28, 2016
  3. [FrameworkBundle] fixed yaml:lint when yaml is not installed along si…

    …de framwork-bundle
    fabpot committed Sep 28, 2016
  4. feature #20067 [FrameworkBundle] removed the Asset component dependen…

    …cy on FrameworkBundle (fabpot)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] removed the Asset component dependency on FrameworkBundle
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no (except for people using FrameworkBundle without requiring symfony/symfony which should be pretty rare; and fixing this is easy by adding symfony/asset explicitly)
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15748 partially
    | License       | MIT
    | Doc PR        | n/a
    
    Trying to reduce the number of required dependencies on FrameworkBundle. This PR removes the Asset component from the list.
    
    Commits
    -------
    
    1dd4e21 [FrameworkBundle] removed the Asset component dependency on FrameworkBundle
    fabpot committed Sep 28, 2016
  5. [FrameworkBundle] removed the Asset component dependency on Framework…

    …Bundle
    fabpot committed Sep 28, 2016
  6. bug #20051 Fix indexBy type extraction (lemoinem)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Fix indexBy type extraction
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8+
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    Bug found and patched by @ksom
    
    Since 3008228, the Doctrine Bridge's PropertyInfo Extractor tries to extract the type of the key in an indexed association. However, as you can see in 3008228#diff-7a8fb8072d57f95ea6e37898b05895bcR91, the extractor was using the metadata of the class containing the association instead of the target entity's metadata to retrieve the type of the index.
    
    The tests were green because in 3008228#diff-c7e914ed89ceffd939733efe08c039c2R44, the property used to `indexBy` was present in the classes on both sides of the relation with the same type.
    
    Once the test is fixed (by renaming the property in the targetEntity), the test provided at 3008228#diff-1b2e044d1df011c00caf802a07895bdbR88 gives the error
    
        1) Symfony\Bridge\Doctrine\PropertyInfo\Tests\DoctrineExtractorTest::testExtract with data set #9 ('indexedBar', array(Symfony\Component\PropertyInfo\Type Object (...)))
        InvalidArgumentException: "" is not a valid PHP type.
    
    The fix is to fetch the metadata of the target entity and check there for the property type.
    
    Commits
    -------
    
    138c6e3 Fix indexBy type extraction
    fabpot committed Sep 28, 2016
  7. Merge branch '3.1'

    * 3.1:
      format json fixtures
      cleanup
      apply rtrim
    fabpot committed Sep 28, 2016
  8. Merge branch '2.8' into 3.1

    * 2.8:
      format json fixtures
      apply rtrim
    fabpot committed Sep 28, 2016
  9. Merge branch '2.7' into 2.8

    * 2.7:
      format json fixtures
      apply rtrim
    fabpot committed Sep 28, 2016
  10. minor #20064 [Console] Format JSON fixtures (ro0NL)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Console] Format JSON fixtures
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | comma-separated list of tickets fixed by the PR, if any
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    Should make merging upstream easier due better diffs.
    
    ```php
    foreach (glob('src/Symfony/Component/Console/Tests/Fixtures/*.json') as $file) {
        file_put_contents($file, str_replace(PHP_EOL, "\n", json_encode(json_decode(trim(file_get_contents($file))), JSON_PRETTY_PRINT))."\n");
    }
    ```
    
    Should be re-applied on 2.8, 3.1 and master.
    
    Commits
    -------
    
    2ca7823 format json fixtures
    fabpot committed Sep 28, 2016
  11. bug #19951 [Finder] Trim trailing directory slash in ExcludeDirectory…

    …FilterIterator (ro0NL)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Finder] Trim trailing directory slash in ExcludeDirectoryFilterIterator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19599
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    In this context `path` equals `path/`
    
    Commits
    -------
    
    e0e5f0c apply rtrim
    fabpot committed Sep 28, 2016
Commits on Sep 27, 2016
  1. format json fixtures

    ro0NL committed Sep 27, 2016
Commits on Sep 26, 2016
  1. minor #20058 [Console] Cleanup legacy fixtures (ro0NL)

    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Console] Cleanup legacy fixtures
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | comma-separated list of tickets fixed by the PR, if any
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    Commits
    -------
    
    d50e3fe cleanup
    fabpot committed Sep 26, 2016
Commits on Sep 25, 2016
  1. cleanup

    ro0NL committed Sep 25, 2016
  2. Merge branch '3.1'

    * 3.1:
      fixed expected exception annotations
    fabpot committed Sep 25, 2016
  3. minor #20052 @expectedException expects FQCN (ro0NL)

    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    @expectedException expects FQCN
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | comma-separated list of tickets fixed by the PR, if any
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    Sorry.. almost there :) fixes 1 more false positive in `ObjectNormalizerTest`.
    
    FriendsOfPHP/PHP-CS-Fixer#2200 is almost ready :)
    
    Commits
    -------
    
    7574a92 fixed expected exception annotations
    fabpot committed Sep 25, 2016
  4. fixed expected exception annotations

    ro0NL committed Sep 25, 2016
Commits on Sep 24, 2016
  1. Fix indexBy type extraction

    lemoinem committed Sep 24, 2016
  2. feature #20037 [Cache] Handle arbitrary key length when the backend c…

    …ant using hashing (nicolas-grekas)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Cache] Handle arbitrary key length when the backend cant using hashing
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Saving some bits from #19521 :) Already awaited by PdoAdapter which defines the property.
    
    Commits
    -------
    
    11f448f [Cache] Handle arbitrary key length when the backend cant using hashing
    fabpot committed Sep 24, 2016
  3. feature #20040 [Bridge/PhpUnit] Handle native E_DEPRECATED (nicolas-g…

    …rekas)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Bridge/PhpUnit] Handle native E_DEPRECATED
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    PHP native deprecations should also be caught.
    
    Commits
    -------
    
    90e8224 [Bridge/PhpUnit] Handle native E_DEPRECATED
    fabpot committed Sep 24, 2016
  4. Merge branch '3.1'

    * 3.1:
      expectedException expects FQCN
      Fixed expectedException annotations
      [Cache] Fix password used to make the redis connection.
      Security and validators messages translation to Latvian
      [Form] FormView->isRendered() remove dead code and simplify the flow
      Fixed issue with legacy find() method not working as expected
    fabpot committed Sep 24, 2016
  5. Merge branch '2.8' into 3.1

    * 2.8:
      expectedException expects FQCN
      Fixed expectedException annotations
      Security and validators messages translation to Latvian
      [Form] FormView->isRendered() remove dead code and simplify the flow
    fabpot committed Sep 24, 2016
  6. Merge branch '2.7' into 2.8

    * 2.7:
      Fixed expectedException annotations
      Security and validators messages translation to Latvian
      [Form] FormView->isRendered() remove dead code and simplify the flow
    fabpot committed Sep 24, 2016
  7. minor #20043 @expectedException expects FQCN (ro0NL)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    @expectedException expects FQCN
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | comma-separated list of tickets fixed by the PR, if any
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    See #20028
    
    Almost there :)
    
    Commits
    -------
    
    526b852 expectedException expects FQCN
    fabpot committed Sep 24, 2016
  8. expectedException expects FQCN

    ro0NL committed Sep 24, 2016
  9. [Bridge/PhpUnit] Handle native E_DEPRECATED

    nicolas-grekas committed Sep 24, 2016
Commits on Sep 23, 2016
  1. [Cache] Handle arbitrary key length when the backend cant using hashing

    nicolas-grekas committed Aug 3, 2016
  2. minor #20028 Fixed expectedException annotations (ro0NL)

    This PR was squashed before being merged into the 2.7 branch (closes #20028).
    
    Discussion
    ----------
    
    Fixed expectedException annotations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | comma-separated list of tickets fixed by the PR, if any
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    See #19237... as this is not going to be fixed in phpunit nor php-cs-fixer and i believe by now these are the last 2 false positives.
    
    Found with `@expectedException\s+[^\s\\]`
    
    In master there are still +-25 consistency issues, ie. FQCN but without a root namespace. Shall we fix this?
    
    Commits
    -------
    
    b074a71 Fixed expectedException annotations
    fabpot committed Sep 23, 2016
  3. Fixed expectedException annotations

    ro0NL committed with fabpot Sep 22, 2016
  4. bug #19980 [Ldap] Fixed issue with legacy find() method not working a…

    …s expected (csarrazi)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Ldap] Fixed issue with legacy find() method not working as expected
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19804
    | License       | MIT
    | Doc PR        |
    
    This PR fixes two bugs. The first, with the legacy `LdapClient` class' `find()` method not working as expected, sometimes throwing errors, which is an after-effect of missing Ldap attributes normalisation in the ResultIterator, and the second one being that the `find()` method does not return the expected output, which should be the same as PHP's `ldap_get_entries()` method.
    
    As a reminder, this method should only be used by legacy software, which need to provide compatibility with Symfony 3.0 and Symfony 2.8.
    
    Commits
    -------
    
    3bae5ea Fixed issue with legacy find() method not working as expected
    fabpot committed Sep 23, 2016
  5. bug #20026 [Cache] Fixed password used to make the redis connection. …

    …(ErikSaunier)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [Cache] Fixed password used to make the redis connection.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #20025
    | License       | MIT
    | Doc PR        | http://symfony.com/blog/new-in-symfony-3-1-cache-component
    
    I do not know if it's possible to provide a test as `REDIS_HOST` is provided by Travis in [RedisAdapterTest.php](https://github.com/symfony/symfony/blob/3.1/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php).
    
    Commits
    -------
    
    77eea43 [Cache] Fix password used to make the redis connection.
    fabpot committed Sep 23, 2016
  6. bug #20034 fix composer install process, resolves #20032 (alcohol)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    fix composer install process, resolves #20032
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #20032
    | License       | MIT
    | Doc PR        | reference to the documentation PR, if any
    
    Commits
    -------
    
    f418cb8 fix composer install process, resolves #20032
    fabpot committed Sep 23, 2016
  7. [Cache] Fix password used to make the redis connection.

    ErikSaunier committed Sep 23, 2016
  8. fix composer install process, resolves #20032

    alcohol committed Sep 23, 2016
Commits on Sep 22, 2016
  1. minor #20027 Security and validators messages translation to Latvian …

    …(Rikijs)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Security and validators messages translation to Latvian
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    ff72f21 Security and validators messages translation to Latvian
    fabpot committed Sep 22, 2016