Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jun 28, 2015
  1. @michalmarcinkowski
  2. @WouterJ

    Very small typo fix

    WouterJ authored
  3. @ogizanagi
  4. @ogizanagi
  5. @fabpot

    bug #15083 [DependencyInjection] Fail when dumping a Definition with …

    fabpot authored
    …no class nor factory (nicolas-grekas)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Fail when dumping a Definition with no class nor factory
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I tried creating an anonymous inline service with a DefinitionDecorator, but that did not work.
    Here is the fix.
    
    Commits
    -------
    
    23ad4ad [DependencyInjection] Fail when dumping a Definition with no class nor factory
  6. @nicolas-grekas
  7. @fabpot

    bug #15127 [Validator] fix validation for Maestro UK card numbers (xa…

    fabpot authored
    …bbuh)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Validator] fix validation for Maestro UK card numbers
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15085
    | License       | MIT
    | Doc PR        |
    
    The issue with the fix in #15086 was, that the `[56-69]` part of the regular expression did not cover the numbers from 56 to 69 but only matched one number if it was 5, 6 or 9 which means that the regular expression itself was not only invalid, but also covered only a total maximum length of 18 digits.
    
    Commits
    -------
    
    f24532a fix validation for Maestro UK card numbers
  8. @fabpot

    bug #15128 DbalLogger: Small nonutf8 array fix (vpetrovych, weaverryan)

    fabpot authored
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    DbalLogger: Small nonutf8 array fix
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #9096
    | License       | MIT
    | Doc PR        | n/a
    
    Hi guys!
    
    Just a small triage of #9096. Actually, @vpetrovych did all the work, and I was able to rebase and keep his original commit for authorship :).
    
    This is obviously a very minor, edge issue - but the patch is simple. The new `normalizeParams` function is an exact copy-and-paste except for the changes in sha: 1882a2a
    
    Thanks!
    
    Commits
    -------
    
    1882a2a Normalizing recursively - see #9096
    8edd4c6 No change - the normalizeParams is a copy-and-paste of the earlier logic
    eae907c fixes issue with logging array of non-utf8 data
Commits on Jun 27, 2015
  1. @weaverryan
  2. @weaverryan
  3. @vpetrovych @weaverryan

    fixes issue with logging array of non-utf8 data

    vpetrovych authored weaverryan committed
  4. @xabbuh
  5. @Tobion

    Merge branch '2.6' into 2.7

    Tobion authored
  6. @Tobion

    Merge branch '2.3' into 2.6

    Tobion authored
    Conflicts:
    	src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig
    	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/choice_widget_collapsed.html.php
  7. @Tobion

    bug #15048 [Translation][Form][choice] empty_value shouldn't be trans…

    Tobion authored
    …lated when it has an empty value (Restless-ET)
    
    This PR was squashed before being merged into the 2.3 branch (closes #15048).
    
    Discussion
    ----------
    
    [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    The same fix provided at #14997 but against ```2.3``` branch.
    
    @webmozart As requested. :)
    
    Commits
    -------
    
    1a5c4c6 [Translation][Form][choice] empty_value shouldn't be translated when it has an empty value
  8. @Restless-ET @Tobion

    [Translation][Form][choice] empty_value shouldn't be translated when …

    Restless-ET authored Tobion committed
    …it has an empty value
  9. @fabpot

    minor #14935 [Validator][callback constraint] include class name in C…

    fabpot authored
    …onstraintDefinitionException. (aitboudad)
    
    This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #14935).
    
    Discussion
    ----------
    
    [Validator][callback constraint] include class name in ConstraintDefinitionException.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Fixed tickets  | ~
    | Tests pass?   | yes
    | License       | MIT
    
    Commits
    -------
    
    51212ac [Validator][callback constraint] include class name in ConstraintDefinitionException.
  10. @aitboudad @fabpot

    [Validator][callback constraint] include class name in ConstraintDefi…

    aitboudad authored fabpot committed
    …nitionException.
  11. @fabpot

    bug #15117 [Form] fixed sending non array data on submit to ResizeLis…

    fabpot authored
    …tener (BruceWouaigne)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Form] fixed sending non array data on submit to ResizeListener
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #13804, #13851
    | License       | MIT
    | Doc PR        |
    
    I agree with @Tobion that #13851 is a bug fix and therefore should be applied on the `2.3` branch too.
    
    Commits
    -------
    
    0f185c9 [Form] [EventListener] fixed sending non array data on submit to ResizeListener
  12. @fabpot

    bug #15122 [Console] respect multi-character shortcuts (xabbuh)

    fabpot authored
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Console] respect multi-character shortcuts
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15105
    | License       | MIT
    | Doc PR        |
    
    The `TextDescriptor` assumed that shortcuts will only consume one space
    when calculating the maximum width needed to display the option's
    synopsis.
    
    Commits
    -------
    
    bd49f23 [Console] respect multi-character shortcuts
  13. @fabpot

    minor #15116 [FrameworkBundle] update type hint in test (xabbuh)

    fabpot authored
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] update type hint in test
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    96a5653 update type hint
  14. @fabpot

    minor #15112 [2.7][DependencyInjection] improve deprecation messages …

    fabpot authored
    …(xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [2.7][DependencyInjection] improve deprecation messages
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Also include the service id in the deprecation message.
    
    Commits
    -------
    
    9e41fa7 [DependencyInjection] improve deprecation messages
  15. @fabpot

    minor #15113 [2.8][DependencyInjection] improve deprecation messages …

    fabpot authored
    …(xabbuh)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [2.8][DependencyInjection] improve deprecation messages
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Also include the service id in the deprecation message.
    
    Commits
    -------
    
    d144dbb [DependencyInjection] improve deprecation messages
  16. @fabpot

    bug #15012 [Validator] don't trigger deprecation with empty group arr…

    fabpot authored
    …ay (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Validator] don't trigger deprecation with empty group array
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    62f12cd [Validator] don't trigger deprecation with empty group array
Commits on Jun 26, 2015
  1. @xabbuh

    [Console] respect multi-character shortcuts

    xabbuh authored
    The `TextDescriptor` assumed that shortcuts will only consume one space
    when calculating the maximum width needed to display the option's
    synopsis.
  2. @xabbuh
  3. @fabpot

    minor #15107 Fix typo in Italian translation (garak)

    fabpot authored
    This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #15107).
    
    Discussion
    ----------
    
    Fix typo in Italian translation
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    26c4413 Fix typo in Italian translation
  4. @garak @fabpot

    Fix typo in Italian translation

    garak authored fabpot committed
  5. @BruceWouaigne @xabbuh

    [Form] [EventListener] fixed sending non array data on submit to Resi…

    BruceWouaigne authored xabbuh committed
    …zeListener
  6. @xabbuh

    update type hint

    xabbuh authored
  7. @xabbuh

    [DependencyInjection] improve deprecation messages

    xabbuh authored
    Also include the service id in the deprecation message.
  8. @xabbuh

    [DependencyInjection] improve deprecation messages

    xabbuh authored
    Also include the service id in the deprecation message.
  9. @Tobion

    minor #15066 [FrameworkBundle] Remove unused old_assets.xml (nicolas-…

    Tobion authored
    …grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Remove unused old_assets.xml
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commit f74a1f2 removed any reference to old_assets.xml
    
    Commits
    -------
    
    18e37c8 [FrameworkBundle] Remove unused old_assets.xml
Commits on Jun 25, 2015
  1. @aitboudad

    Merge remote-tracking branch 'origin/2.6' into 2.7

    aitboudad authored
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
    	src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
    	src/Symfony/Component/Validator/Constraints/EmailValidator.php
  2. @aitboudad

    bug #15102 [2.6][Translation][debug cmd] fixed failing tests. (aitbou…

    aitboudad authored
    …dad)
    
    This PR was merged into the 2.6 branch.
    
    Discussion
    ----------
    
    [2.6][Translation][debug cmd] fixed failing tests.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |  ~
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    3341315 [Translation][debug cmd] fixed failing tests.
Something went wrong with that request. Please try again.