Permalink
Commits on Jul 4, 2011
  1. @fabpot

    prepare 2.0 RC4 release

    fabpot committed Jul 4, 2011
  2. @fabpot
  3. @fabpot

    fixed unit tests

    fabpot committed Jul 4, 2011
  4. @fabpot

    merged branch paulkamer/master (PR #1520)

    Commits
    -------
    
    924ea92 made command consistent with other help texts (it's now './app/console', instead of 'php app/console')
    8361346 Corrected help text from './symfony' to 'php app/console'
    
    Discussion
    ----------
    
    [console] Incorrect help text
    
    When executing 'php app/console help', example commands starting with './symfony ' are shown.
    I've made it consistent with the help text shown for generate:bundle; './app/console '
    fabpot committed Jul 4, 2011
  5. @fabpot

    merged branch stloyd/datetime_fixes (PR #1485)

    Commits
    -------
    
    3917ed7 Revert "* DateType, DateTimeType, TimeType: - a bit changed readability"
    c85b815 Fixed few issues with Date and Time:
    
    Discussion
    ----------
    
    [Form] Fixed few issues with Date and Time
    
    Fixed few issues with Date and Time:
    
    * TimeType:
      - seconds are no longer populated if "with_seconds" = false
      - "widget = text" is now properly rendered (closes #1480)
    * DateTimeToStringTransformer:
      - fixed using not default "format" (probably fix #1183)
    * DateType, DateTimeType, TimeType:
      - fixed "input = datetime" and test covered
    fabpot committed Jul 4, 2011
  6. @paulkamer

    made command consistent with other help texts (it's now './app/consol…

    …e', instead of 'php app/console')
    paulkamer committed Jul 4, 2011
  7. @paulkamer
  8. @fabpot
  9. @fabpot

    merged branch stloyd/session_fix (PR #1517)

    Commits
    -------
    
    756ea8d Call session_name() only if user gave an new one. Closes #1418
    
    Discussion
    ----------
    
    [Session] Call session_name() only if user gave an new one
    
    Call `session_name()` only if user gave an new one, by default will use an "php.ini" option. Also added some phpdoc.
    
    Closes #1418.
    fabpot committed Jul 4, 2011
  10. @fabpot

    merged branch vicb/perf-array (PR #1516)

    Commits
    -------
    
    2af2260 Remove useless code
    
    Discussion
    ----------
    
    Remove useless code
    
    This PR is about removing useless code which could benefit to perfomances.
    
    Credits go to [Jordi](000229d) for this.
    
    As a minor modif, I can understand if this could not be merged while in RC.
    fabpot committed Jul 4, 2011
  11. @stloyd
  12. @vicb

    Remove useless code

    vicb committed Jul 4, 2011
  13. @fabpot
  14. @fabpot

    merged branch Herzult/testSecurity (PR #1447)

    Commits
    -------
    
    164aea4 [Security] Add tests for the channel listener
    d51cbc0 [Security] Remove useless attribute in basic authentication listener & test it
    91e6dc9 [Security] Add tests for the anonymous authentication listener
    3c2affb [Security] Update access listener constructor's prototype and add tests
    81afd77 [Security] Add tests for the firewall map
    aa6ae33 [Security] Remove useless attribute & var in firewall
    
    Discussion
    ----------
    
    Test security
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/06/29 13:41:07 -0700
    
    @schmittjoh is probably the person to review this change ..
    fabpot committed Jul 4, 2011
  15. @fabpot
  16. @fabpot

    merged branch jseverson/formnotboundexception (PR #1465)

    Commits
    -------
    
    49af102 Throwing FormNotBoundException when calling form isValid
    
    Discussion
    ----------
    
    Throwing FormNotBoundException when calling form isValid
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/06/28 12:20:04 -0700
    
    I'd have made that a `\LogicException`, but that's just me hating on custom exceptions. Otherwise as said on IRC, 👍.
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/06/28 12:27:27 -0700
    
    +1 but IMO `FormException` would be here good enough.
    fabpot committed Jul 4, 2011
  17. @fabpot

    merged branch nicodmf/master (PR #1469)

    Commits
    -------
    
    bf76bed Correct prefix from nothing to ORM\ for annotations
    
    Discussion
    ----------
    
    Correct prefix from nothing to ORM\ for annotations
    
    For yml et xml mapping, the commands generate:doctrine:entities and doctrine:generate:entities, don't prefixed the annotations, specially for the listenners methods (prepersist, preupdate...).
    fabpot committed Jul 4, 2011
  18. @fabpot

    merged branch stloyd/patch-2 (PR #1514)

    Commits
    -------
    
    00151db Call container directly (skip unnecesary method call)
    
    Discussion
    ----------
    
    [Controler] Call container directly
    
    This skip unnecesary call for `Controller::get($id)` .
    fabpot committed Jul 4, 2011
  19. @fabpot

    tweaked UPDATE file

    fabpot committed Jul 4, 2011
  20. @stloyd
  21. @fabpot

    merged branch beberlei/AnnotationAutoloading (PR #1508)

    Commits
    -------
    
    c867209 Adjust UPDATE.md to Annotation changes
    9069d06 Fix tests to run with Doctrine Common AnnotationRegistry
    d5c1bbe Disable call to AnnotationReader::setAutoloadAnnotations()
    
    Discussion
    ----------
    
    Annotation autoloading
    
    This pull request disables the annotation autoloading through the DIC. PHP Autoloading is now removed from the AnnotationReader and replaced with its own autoloading mechanism that offers much more control over possible error states.
    fabpot committed Jul 4, 2011
  22. @fabpot

    [Form] fixed error messages

    fabpot committed Jul 4, 2011
  23. @fabpot

    merged branch vicb/form/csrf (PR #1512)

    Commits
    -------
    
    06c3712 [Form csrf] FileTypeCsrdExtension is not required any more (as FileType now extends FieldType)
    
    Discussion
    ----------
    
    [Form csrf] FileTypeCsrdExtension is not required any more
    
    FileType now extends FieldType.
    fabpot committed Jul 4, 2011
  24. @vicb

    [Form csrf] FileTypeCsrdExtension is not required any more (as FileTy…

    …pe now extends FieldType)
    vicb committed Jul 4, 2011
Commits on Jul 3, 2011
  1. @beberlei
  2. @beberlei
  3. @beberlei
  4. @fabpot

    merged branch schmittjoh/doctrineAutoloadFix (PR #1501)

    Commits
    -------
    
    d28cf66 changed autoloading behavior to give better error message
    
    Discussion
    ----------
    
    changed autoloading behavior to give better error message
    fabpot committed Jul 3, 2011
Commits on Jul 2, 2011
  1. @schmittjoh
Commits on Jul 1, 2011
  1. @fabpot

    [Config] fixed a unit test

    fabpot committed Jul 1, 2011
  2. @fabpot

    merged branch Seldaek/router_esc (PR #1471)

    Commits
    -------
    
    418d6a0 [Routing] Fix syntax error when dumping routes with single quotes in the requirements or pattern
    2b5e22d [Routing] Fix ApacheDumper when a space appears in a default value
    6c7f484 [Routing] Fix dumper so it doesn't print trailing whitespace
    761724a [Routing] Adjust urlescaping rules, fixes #752
    
    Discussion
    ----------
    
    [Router] Bunch o' Fixes
    
    The first commit changes the escaping rule to fix issues I had previously, and #752 as well, here's from the full commit message:
    
        Only + and % are now encoded in generated routes, since they are the only characters that, if not encoded, could cause problems/conflicts when decoded. Namely + turns into a space, and % followed by numbers could do funky things.
    
        The matcher decodes everything which works since nothing will have %NN without being escaped, and + are escaped as well.
    
    Second commit is just a test fix for the first
    
    Third and fourth are simply dumper escaping issues, nothing to argue about.
    
    Note that all changes have had test cases added, and I spent a few hours torturing/testing all this stuff with both Apache and PHP dumpers, in many browsers, and with URLs as wonky as `/%01%02%03%04%05%06%07%08%0E%0F%10%11%12%13%14%15%16%17%18%19%1A%1B%1C%1D%1E%1F%20!%22$%25&%27%28%29*+,-./0123456789:;%3C=%3E@ABCDEFGHIJKLMNOPQRSTUVWXYZ%5B%5D%5E_%60abcdefghijklmnopqrstuvwxyz%7B|%7D~/baz` which essentially represent the 1-255 char range minus ? and #.
    
    The only issues I really encountered after all the patches were applied is that Apache refuses to match `%22` (= `"`) and `*` in a url. I guess it's just because they're not allowed chars in windows paths, but | and < > works fine though. Anyway this works with the PHP dumper, and it didn't work either without my patches so it's not like I broke it, I'm just saying for the record.
    fabpot committed Jul 1, 2011
  3. @stloyd
  4. @fabpot

    merged branch hhamon/file_loader_exception_tweak (PR #1491)

    Commits
    -------
    
    61c2d6f [Config] removed extra whitespace.
    fb4dea6 [Config] tweaked exception message when a resource can't be loaded. The new exception message reminds to check if the bundle is correctly loaded in the kernel class when trying to load a resource coming from a bundle.
    
    Discussion
    ----------
    
    [Config] tweaked exception message when a resource can't be loaded. The n
    
    [Config] tweaked exception message when a resource can't be loaded. The new exception message reminds to check if the bundle is correctly loaded in the kernel class when trying to load a resource coming from a bundle.
    fabpot committed Jul 1, 2011
  5. @hhamon
  6. @hhamon

    [Config] tweaked exception message when a resource can't be loaded. T…

    …he new exception message reminds to check if the bundle is correctly loaded in the kernel class when trying to load a resource coming from a bundle.
    hhamon committed Jul 1, 2011