Permalink
Commits on Aug 26, 2011
  1. updated VENDORS for 2.0.1

    fabpot committed Aug 26, 2011
  2. updated CHANGELOG for 2.0.1

    fabpot committed Aug 26, 2011
  3. update VERSION for 2.0.1

    fabpot committed Aug 24, 2011
  4. update CONTRIBUTORS for 2.0.1

    fabpot committed Aug 24, 2011
Commits on Aug 25, 2011
  1. [HttpKernel] added a test for uploading a file via an array instead o…

    fabpot committed Aug 25, 2011
    …f an UploadedFile instance
  2. merged branch stloyd/patch-4 (PR #2018)

    fabpot committed Aug 25, 2011
    Commits
    -------
    
    542cfd6 [ServerBag] Skip unnecessary loop in `getHeaders()`
    
    Discussion
    ----------
    
    [ServerBag] Skip unnecessary loop in `getHeaders()`
  3. merged branch jmikola/ContainerAwareEventDispatcher-key-conflict (PR #…

    fabpot committed Aug 25, 2011
    …2022)
    
    Commits
    -------
    
    84c1719 [FrameworkBundle] Avoid listener key conflicts in ContainerAwareEventDispatcher
    
    Discussion
    ----------
    
    [FrameworkBundle] Avoid listener key conflicts in ContainerAwareEventDispatcher
    
    Since the key was previously concatenating service ID and method without a separator, it's possible that two different listeners could conflict (e.g. service/method pairs: foo/bar and fo/obar).
Commits on Aug 24, 2011
  1. [FrameworkBundle] Avoid listener key conflicts in ContainerAwareEvent…

    jmikola committed Aug 24, 2011
    …Dispatcher
    
    Since the key was previously concatenating service ID and method without a separator, it's possible that two different listeners could conflict (e.g. service/method pairs: foo/bar and fo/obar).
  2. [DoctrineBundle] removed an unused and confusing parameter (the conne…

    fabpot committed Aug 24, 2011
    …ction class can be changed via the wrapper_class setting of a connection)
  3. fixed CS

    fabpot committed Aug 24, 2011
  4. merged branch Seldaek/toolbar_debugging (PR #2019)

    fabpot committed Aug 24, 2011
    Commits
    -------
    
    89f477e [WebProfilerBundle] Throw exception if a collector template isn't found
    6ca72cf [WebProfilerBundle] Allow .html.twig in collector template names
    
    Discussion
    ----------
    
    WDT debugging
    
    While implementing collectors I did a mistake in the template name and it never told me, so I was left wondering why my stuff didn't show up. Not so nice IMO. Also the first commit is to allow template names to be specified fully. I don't see why this shouldn't be allowed, since it is the way you specify templates everywhere else.
  5. tweaked CHANGELOG

    fabpot committed Aug 24, 2011
  6. added the 2.0.x CHANGELOG file

    fabpot committed Aug 24, 2011
Commits on Aug 23, 2011
  1. merged branch jmikola/remove-subscriber-with-priorities (PR #2014)

    fabpot committed Aug 23, 2011
    Commits
    -------
    
    39fabab [EventDispatcher] Fix removeSubscriber() to work with priority syntax
    
    Discussion
    ----------
    
    [EventDispatcher] Fix removeSubscriber() to work with priority syntax
    
    Previously only addSubscriber() was being tested with priority syntax. This adds a unit test for removeSubscriber() and fixes a bug that would have caused it to fail.
  2. Merge branch 'domcrawler-disabled-fields'

    fabpot committed Aug 23, 2011
    * domcrawler-disabled-fields:
      [DomCrawler] fixed disabled fields in forms (they are available in the DOM, but their values are not submitted -- whereas before, they were simply removed from the DOM)
      $node->hasAttribute('disabled') sf2 should not create disagreement between implementation and practice for a crawler. If sahi real browser can find an element that is disabled, then sf2 should too. https://github.com/Behat/Mink/pull/58#issuecomment-1712459
  3. merged branch danielholmes/patch-1 (PR #2008)

    fabpot committed Aug 23, 2011
    Commits
    -------
    
    e294211 [DomCrawler] Removed unused document property in Form
    
    Discussion
    ----------
    
    [DomCrawler] Removed unused document property in Form
  4. merged branch stloyd/patch-2 (PR #2010)

    fabpot committed Aug 23, 2011
    Commits
    -------
    
    06162e7 [WebProfiler] Use proper `Response` function to check is it an redirection
    
    Discussion
    ----------
    
    [WebProfiler] Use proper `Response` function
    
    Use proper `Response::isRedirection()` function to check is it an redirection.
  5. [DomCrawler] fixed disabled fields in forms (they are available in th…

    fabpot committed Aug 23, 2011
    …e DOM, but their values are not submitted -- whereas before, they were simply removed from the DOM)
  6. merged branch cordoval/patch-1 (PR #1890)

    fabpot committed Aug 23, 2011
    Commits
    -------
    
    8a980bd $node->hasAttribute('disabled') sf2 should not create disagreement between implementation and practice for a crawler. If sahi real browser can find an element that is disabled, then sf2 should too. https://github.com/Behat/Mink/pull/58#issuecomment-1712459
    
    Discussion
    ----------
    
    $node->hasAttribute('disabled') sf2 should not create disagreement betwee
    
    $node->hasAttribute('disabled') sf2 should not create disagreement between implementation and practice for a crawler. If sahi real browser can find an element that is disabled, then sf2 should too.
    https://github.com/Behat/Mink/pull/58#issuecomment-1712459
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2011/08/09 20:34:56 -0700
    
    @fabpot please let me know if this is going to be in sometime soon or not, just wondering why it is deviating ...
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/08/23 01:11:42 -0700
    
    I have just checked in a browser and the Symfony2 implementation is actually the right one.
    
    Try this in a browser:
    
        <form action='#' method="post">
            <input name="foo" disabled="disabled" value="foo" />
            <input name="bar" value="bar" />
    
            <input type="submit" />
        </form>
    
        <?php
    
        print_r($_POST);
    
        // output: Array ( [bar] => bar ) when the form is submitted
    
    And here is the discussion about it in the HTML4 spec: http://www.w3.org/TR/html4/interact/forms.html#h-17.12:
    
    "In this example, the INPUT element is disabled. Therefore, it cannot receive user input nor will its value be submitted with the form."
    
    And the same is tru for HTML5: http://www.w3.org/TR/html5/association-of-controls-and-forms.html#constructing-form-data-set
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2011/08/23 01:29:53 -0700
    
    @fabpot I guess you got my scenario wrong. I am not trying to submit any form. I am just happen to have a disabled box that is checked and I want to read with the DOM Crawler that is checked. Not to submit or anything but for the purposes of testing.
    
    Please consider also that this request comes from asserting values using behat mink, mink is fully dependent on sf2 driver for when it is used except it is told to use a different driver like a real browser like sahi. When testing in chrome and firefox, the verification with the DOM is made that the disabled box is checked properly. Symfony2 DOM Crawler however misses that spot for that use.
    
    Even in the case where Symfony2 DOM Crawler component would have been thought not for this purpose of testing, or further for this particular scenario it would be good to make it more reusable for this kind of scenario.
    
    Just saying....
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/08/23 02:00:34 -0700
    
    Indeed, I didn't get your issue right. So, basically, all fields should be in the form, but the disabled field values should not be submitted (that makes sense).
    
    I've prepared a fix in this patch: e885258 which is in the symfony/domcrawler-disabled-fields branch for now as I don't know if we can make this change in 2.0 or if we need to put it in 2.1.
    
    ---------------------------------------------------------------------------
    
    by cordoval at 2011/08/23 02:15:01 -0700
    
    oh no I was hoping to enter the authors, you already did the fix :'(
  7. merged branch Abhoryo/patch-1 (PR #1956)

    fabpot committed Aug 23, 2011
    Commits
    -------
    
    e9d2a67 CS
    3a64b08 Search in others user providers when a user is not found in the first user provider and throws the right exception.
    
    Discussion
    ----------
    
    Chain user provider doesn't search in all user providers
    
    I commit these changes because Chain user provider doesn't search in all user providers.
    
    Example with the Acme/DemoBundle:
    
        // security.yml
        ...
            providers:
                chain_provider:
                    providers: [in_memory, in_memory_extend]
                in_memory_extend:
                    users:
                        admin2: { password: adminpass2, roles: [ 'ROLE_ADMIN' ] }
                in_memory:
                    users:
                        user:  { password: userpass, roles: [ 'ROLE_USER' ] }
        ...
            firewalls:
        ...
                secured_area:
                    pattern:    ^/demo/secured/
                    provider: chain_provider OR in_memory_extend
        ...
    
    We can see these logs :
    
        security.INFO: User "admin2" has been authenticated successfully [] []
        security.DEBUG: Write SecurityContext in the session [] []
        security.DEBUG: Read SecurityContext from the session [] []
        security.DEBUG: Reloading user from user provider. [] []
        security.WARNING: Username "admin2" could not be found. [] []
    
    The new code search in others user providers when a user is not found in the first user provider and throws the right exception.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/08/14 12:20:04 -0700
    
    I wonder if it should be a provider option to continue on a failed user lookup. I can see cases where you really dont want to iterate over all providers and others where you do.
    
    ---------------------------------------------------------------------------
    
    by Abhoryo at 2011/08/14 17:27:16 -0700
    
    If someone need a provider like you describe, he can create one.
    Here we talk about a chain user provider.
    
    Doc : [using-multiple-user-providers](http://symfony.com/doc/current/book/security.html#using-multiple-user-providers)
    
    We can read in the doc: "The chain_provider will, in turn, try to load the user from both the in_memory and user_db providers."
    But its not the case right now.
  8. merged branch stloyd/issue_1986 (PR #2000)

    fabpot committed Aug 23, 2011
    Commits
    -------
    
    c29fa9d [Form] Fix for treatment zero as empty data. Closes #1986
    
    Discussion
    ----------
    
    [Form] Fix for treatment zero as empty data. Closes #1986
    
    For more info please read #1986.
Commits on Aug 22, 2011
  1. [Form] added missing DelegatingValidator registration in the Form Ext…

    fabpot committed Aug 22, 2011
    …ension class (used when using the Form component outside a Symfony2 project where the validation.xml is used instead)
  2. merged branch weaverryan/form_choice_missing_variable (PR #2005)

    fabpot committed Aug 22, 2011
    Commits
    -------
    
    fdd2e7a [Form] Fixing a bug where setting empty_value to false caused a variable to not be found
    
    Discussion
    ----------
    
    [Form] Fixing a bug where setting empty_value to false caused a variable
    
    Hey guys!
    
    I think was an edge case that was overlooked. In this one case, the `$emptyValue` variable is never set. It causes warnings, but there should be no behavior change since the missing variable is being set to `null`.
    
    Thanks!
  3. merged branch hidenorigoto/master (PR #2003)

    fabpot committed Aug 22, 2011
    Commits
    -------
    
    bc7edfe [FrameworkBundle] changed resource filename of Japanese validator translation
    
    Discussion
    ----------
    
    [FrameworkBundle] change resource filename of Japanese validator translation
    
    The country code of the translation resource file should be short notation because the long notation fallbacks to it.